Commit Graph

4739 Commits

Author SHA1 Message Date
orionlee 6f7b937d07 bugfix - video playback upon press back button (and pause), playback notification might reappear if one swipes it away quickly. 2019-03-09 14:16:53 -08:00
orionlee 7a905c0570 remove the commented stopService() call (to avoid future confusion) 2019-03-05 15:07:16 -08:00
orionlee 24915785eb remove the stopService() per review (which might unnecessarily
stop the playback when unsupported media buttons are pressed.)
2019-03-05 15:01:48 -08:00
orionlee e94e95e844 remove dead codes 2019-03-04 13:46:11 -08:00
orionlee 600e0e561e coding style fix per review 2019-03-04 13:44:53 -08:00
orionlee a3389490bb ensure the service continues to run in the event it takes a long time for the service to load the media to play, e.g.,
streaming over a slow network.
2019-02-27 14:59:31 -08:00
orionlee ab78c1d410 bug fix for Android8+: revert context.startService() calls back to
ContextCompat.startForegroundService(), to ensure PlaybackService
can be started.

While PlaybackService itself ensures it will be raised to foreground
when appropriate, Android 8+ forbids creating the (background)
services to begin with (and throw IllegalStateException) in some
situation (e.g., BroadcastReceiver).

https://developer.android.com/about/versions/oreo/android-8.0-changes#atap
2019-02-27 14:52:34 -08:00
orionlee 2c5db08e25 minor cleanup of Log codes and comments. 2019-02-27 14:52:34 -08:00
orionlee 221cd4b480 refactor stop PlaybackService setupNotification() - extract common
code as private helper.
2019-02-27 14:52:34 -08:00
orionlee f0f8623937 refactor stop PlaybackService codes - remove legacy dead codes 2019-02-27 14:52:34 -08:00
orionlee 584865ad18 review stop PlaybackService codes (stopSelf, stopForeground, etc.) 2019-02-27 14:52:34 -08:00
orionlee 3f14fac479 remove static PlaybackService.started, in favor of the start state
managed by inner ServiceManager.
Also add a generic java8-like Optional class for use with RxJava2 where
null was to be returned (RxJava2 requires non-null).
2019-02-27 14:52:34 -08:00
orionlee e26a54bdbc start playbackService code paths reviewed (context.startService() and
ContextCompat.startForegroundService())
2019-02-27 14:52:34 -08:00
orionlee 76fbab8e82 more #2716 - fix VideoPlayback upon hitting home button. 2019-02-27 14:52:34 -08:00
orionlee f3980091a9 #2716 Prototype for the revamped PlaybackService to fix phantom
notification. Many rough edges. Notable TODOs are marked with [2716].
2019-02-27 14:52:34 -08:00
H. Lehmann 335d287d5e
Merge pull request #3041 from ByteHamster/transifex-italian
Transifex: removed duplicate Italian translation
2019-02-26 08:39:45 +01:00
ByteHamster 6dafc8b127 Transifex: removed duplicate Italian translation
Using it_IT for all italian languages because it's 100% finished
2019-02-21 15:17:59 +01:00
H. Lehmann 91987460db
Merge pull request #2688 from orionlee/auto_download_12_hour_option_2685
Episode Cleanup (for automatic download) - support 12 hours after finishing
2019-02-01 16:31:45 +01:00
ByteHamster abe68ec7bd Merge remote-tracking branch 'upstream/develop' into auto_download_12_hour_option_2685 2019-02-01 16:25:20 +01:00
ByteHamster 73bb2f712e Removed misleading comment
Auto-generating the versionCode breaks F-Droid builds, see #3012
2019-02-01 16:00:13 +01:00
ByteHamster 39c6ff5f31 Finish when closing error dialog 2019-02-01 15:59:30 +01:00
Burt Wiley Snyder 7f100b3fa6 Null handling in OnlineFeedViewActivity (#3004) 2019-02-01 15:57:19 +01:00
Martin Fietz 3b67381656
Merge pull request #2994 from orionlee/android_gradle_330_upgrade
Upgrade android gradle plugin to v3.3.0
2019-01-27 11:47:13 +01:00
Martin Fietz 7f37987bda
Merge branch 'develop' into android_gradle_330_upgrade 2019-01-27 11:40:24 +01:00
Martin Fietz 9fe05d96b9
Merge pull request #3012 from hannesa2/SimplifyVersionCode
simplify versionCode
2019-01-27 11:38:44 +01:00
Martin Fietz bcfc951f1b
Merge branch 'develop' into android_gradle_330_upgrade 2019-01-27 11:35:46 +01:00
Hannes Achleitner 8e5abeea3a simplify versionCode
removed implementation was some Eclipse/ant style, now it's Gradle style
2019-01-27 10:57:45 +01:00
H. Lehmann 0474717ba1
Merge pull request #3005 from pachecosf/fix-ripple-effect
Reimplemented the ripple effect when choosing a nav item
2019-01-23 15:41:51 +01:00
pachecosf e0d6d35ca5 moved closing backet up one line 2019-01-23 05:22:39 -08:00
H. Lehmann de7a05f77c
Merge pull request #3006 from pachecosf/fixed-losing-media-data
Fixed losing media data on rotation
2019-01-23 12:30:44 +01:00
pachecosf 6753df01b5 changed location of setupGUI to prevent nullpointerexeptions when saved fragment had no initiliazed id 2019-01-23 00:01:18 -08:00
pachecosf 494b34d421 fixed losing media images and descriptions on rotate 2019-01-22 23:57:37 -08:00
pachecosf 8cb4cb16a5 fixed placing of the attr into nav_feedlistitem 2019-01-22 21:37:11 -08:00
pachecosf 4388c5a92f reimplemented the ripple effect when choosing a nav item 2019-01-22 21:30:15 -08:00
ByteHamster 6c2e9afad4 Fixed displaying feed url
Closes #2989
2019-01-19 10:56:10 +01:00
ByteHamster 24d72f93fa Re-added shorter lt description 2019-01-19 10:26:53 +01:00
H. Lehmann 20def27f22
Merge pull request #2993 from pachecosf/add-highlighting-of-drawer-item
Adding highlighting of drawer item functionality
2019-01-19 09:29:58 +01:00
pachecosf a421c490e4 cleaned up a couple of lines 2019-01-18 12:28:49 -08:00
pachecosf a80435a03b switched implementation to ussing attr 2019-01-18 12:09:24 -08:00
H. Lehmann 45dd9f6fc1
Merge pull request #2998 from ByteHamster/triplet
Play description update
2019-01-18 19:52:10 +01:00
ByteHamster 4df5dd9d5e Added title to every language 2019-01-18 19:43:50 +01:00
ByteHamster 765e975df0 Play publisher forces to provide all resources for all languages
Filling with English until it's translated
2019-01-18 19:38:50 +01:00
ByteHamster 497dd3b493 Disabled lt description until it's short enough 2019-01-18 19:22:56 +01:00
ByteHamster 81612ddea6 Added symlinks to alternative publisher locations 2019-01-18 18:49:45 +01:00
ByteHamster 33f8bd78a4 Allow to configure play api key 2019-01-18 18:41:00 +01:00
pachecosf fd83665970 Changed implementation using themeUtils instead 2019-01-17 16:21:34 -08:00
pachecosf 7da762b8ea Changed implementation using themeUtils instead 2019-01-17 16:18:50 -08:00
pachecosf ecff66eff6 fixed styles 2019-01-17 12:29:23 -08:00
orionlee 62711d9a11 Upgrade android gradle plugin to v3.3.0. Also upgraded plugins that would
otherwise generate warning message (dexcount, play-publisher).
2019-01-17 10:18:29 -08:00
pachecosf 43642a5e6b adding highlighting of drawer item functunality 2019-01-16 20:51:54 -08:00