Commit Graph

4768 Commits

Author SHA1 Message Date
Borjan Tchakaloff 6ebf1defe7 Validate that the item state is only changed when needed
Follow-up to commit 8172d87477 (#3067)
that adds test coverage for the resolved issue.

Also, fix that commit by making the update condition more explicit:
the FeedItem state is only changed when a state switch is necessary.
In other words, an item marked as *new* that gets downloaded should
lose the *new* mark and gain the *unplayed* mark instead.
2019-03-31 16:28:05 +02:00
Borjan Tchakaloff cba4059063 Require the Mockito library for unit testing 2019-03-31 16:26:26 +02:00
Borjan Tchakaloff 3c7fd274de Validate that the *new* and *played* states are exclusive 2019-03-31 16:26:26 +02:00
H. Lehmann c6344f5bc0
Merge pull request #3073 from deandreamatias/fix-button-shadow-3040
Fix #3040 Video playback control button shadow
2019-03-31 00:44:50 +01:00
Matias de Andrea 56456e0001 Delete unused drawable 2019-03-30 21:21:11 +01:00
Martin Fietz 2094caf7f2
Merge pull request #3074 from ByteHamster/fyydlin
Fixed fyyd feed search
2019-03-30 11:12:58 +01:00
Martin Fietz f900046c66
Merge pull request #3068 from bibz/develop
Do not reset item "played" flag on media download
2019-03-30 11:12:46 +01:00
Matias de Andrea 7f3f2180cc Fixes #3040
- Delete unused icons
2019-03-29 22:27:26 +01:00
Matias de Andrea 007f92c291 Change the icons in interface #3040 2019-03-29 22:23:52 +01:00
Matias de Andrea 9e21695486 Add new vector icons #3040 2019-03-29 22:21:04 +01:00
ByteHamster 8d8e333b84 Fixed fyyd feed search 2019-03-29 18:26:34 +01:00
Matias de Andrea 09087b354d Fix #3040
- Change the size of the button circle background
2019-03-29 12:57:52 +01:00
H. Lehmann 42cbdbd989
Merge pull request #3066 from orionlee/bugfix_statistics_played_duration_inflated_2162
bugfix - statistics - inflated actual played duration
2019-03-27 20:51:13 +01:00
Borjan Tchakaloff 8172d87477 Do not reset item "played" flag on media download
If an item has already been played, downloading its media will not
reset that "played" flag.

Fixes: #3067
2019-03-25 15:41:39 +01:00
orionlee 0a01f6e00b #2162 bugfix - statistics - inflated actual played duration 2019-03-24 13:00:37 -07:00
H. Lehmann 3e2efea0e7
Merge pull request #3062 from ByteHamster/feed-test-handler
Fixed FeedHandlerTest
2019-03-23 11:36:14 +01:00
ByteHamster 022a7f6981 Fixed FeedHandlerTest 2019-03-23 10:45:50 +01:00
H. Lehmann 0a9735e7da
Merge pull request #3057 from matdb/develop
Fix #3054: use UTF-8 to encode password and username for gpodder auth
2019-03-08 22:21:54 +01:00
Matthieu De Beule e25659a128 Fix #3054: use UTF-8 to encode password and username for gpodder auth 2019-03-08 17:46:30 +01:00
Matthieu 26d7e61f4d
Merge pull request #1 from AntennaPod/develop
catch up
2019-03-08 16:40:28 +01:00
H. Lehmann 6212455431
Merge pull request #3048 from ByteHamster/new-episodes-download
Fixed download status update in NewEpisodesFragment
2019-03-08 12:15:23 +01:00
ByteHamster f2306d2950 Fixed download status update in NewEpisodesFragment 2019-03-08 11:39:24 +01:00
H. Lehmann 2818bb62ab
Merge pull request #3055 from matdb/develop
Fix #3028: actually use encodedQuery from URLEncoder to avoid encoding issues
2019-03-08 11:27:15 +01:00
Matthieu De Beule c362a50e1b Fix #3028: actually use encodedQuery from URLEncoder to avoid encoding issues 2019-03-07 20:53:22 +01:00
H. Lehmann c1bfb9183c
Merge pull request #3013 from hannesa2/buildImprovements
Build improvements
2019-03-05 23:49:00 +01:00
H. Lehmann c0f534e825
Merge pull request #3050 from ByteHamster/add-backup-keyword
Add backup keyword to search
2019-03-04 18:57:37 +01:00
H. Lehmann cfa9304c82
Merge pull request #3047 from ByteHamster/move-to-unit-test
Moved some implementation tests to unit tests
2019-03-04 18:56:51 +01:00
H. Lehmann 3d9811d1e3
Merge pull request #3044 from mamehacker/min_max_speeds_from_preferences
Set min/max playback speeds from preferences
2019-03-04 18:53:34 +01:00
ByteHamster 579b263a86 Add backup keyword to search 2019-03-04 14:33:39 +01:00
ByteHamster c50d37fa1b Moved some implementation tests to unit tests 2019-03-03 23:55:52 +01:00
H. Lehmann 1593a06077
Merge pull request #3032 from shortspider/3031-TimecodeRegex
Change Timecode Regex
2019-03-03 23:26:32 +01:00
Nathan Mascitelli 1d0e701525 Another atempt at fixing the regex 2019-03-03 13:36:28 -05:00
Nathan Mascitelli 7e3ccd97da Fix regex 2019-03-02 12:12:26 -05:00
Nathan Mascitelli 6f69b4b140 Adjust regext to ignore X:Y timecodes 2019-03-02 08:47:52 -05:00
Shinichiro Fujiwara 6a56260157 Set min/max playback speeds from preferences 2019-02-27 22:29:28 +09:00
H. Lehmann 335d287d5e
Merge pull request #3041 from ByteHamster/transifex-italian
Transifex: removed duplicate Italian translation
2019-02-26 08:39:45 +01:00
ByteHamster 6dafc8b127 Transifex: removed duplicate Italian translation
Using it_IT for all italian languages because it's 100% finished
2019-02-21 15:17:59 +01:00
Nathan Mascitelli e94e4bc3d0 Use a single format for short timecodes
It is unlikely that multiple formats for short timecodes would be used
in one document. Therefor we will parse all the short timecodes to see
if they are all less then the duration as HH:MM. If they are we will use
that, otherwise we will parse them as MM:SS.
2019-02-13 21:06:19 -05:00
Nathan Mascitelli c49e98b546 Handle more then 23 hours 2019-02-12 20:53:17 -05:00
Nathan Mascitelli 39b9df5064 Timecode parsing logic now handles two short formats
We now handle both HH:MM and MM:SS when paring timecodes. We will move
in reverse order (assuming that the timecodes will increase over the
course of the document) and parse short codes as HH:MM. When we get a
result that does not fit into the duration we will change to parse as
MM:SS and use that for the rest of the document.
2019-02-12 19:43:57 -05:00
Nathan Mascitelli d0f617880c Converter handles HH:MM and MM:SS 2019-02-12 19:43:37 -05:00
Nathan Mascitelli 96b0336b2c Update Timeline regex
Regex now looks for the new types of short and long timestamps.
2019-02-10 18:01:00 -05:00
Nathan Mascitelli 9180be85ba Update tests to handle minute timestamps
The definition of 'short timestamp' now means minutes and seconds, while
'long timestamp' means hours, minutes, and seconds. The first part of a
timestamp may have one or two digits. Tests updated for this new
definition.
2019-02-10 18:00:28 -05:00
H. Lehmann 91987460db
Merge pull request #2688 from orionlee/auto_download_12_hour_option_2685
Episode Cleanup (for automatic download) - support 12 hours after finishing
2019-02-01 16:31:45 +01:00
ByteHamster abe68ec7bd Merge remote-tracking branch 'upstream/develop' into auto_download_12_hour_option_2685 2019-02-01 16:25:20 +01:00
ByteHamster 73bb2f712e Removed misleading comment
Auto-generating the versionCode breaks F-Droid builds, see #3012
2019-02-01 16:00:13 +01:00
ByteHamster 39c6ff5f31 Finish when closing error dialog 2019-02-01 15:59:30 +01:00
Burt Wiley Snyder 7f100b3fa6 Null handling in OnlineFeedViewActivity (#3004) 2019-02-01 15:57:19 +01:00
Hannes Achleitner 0663e422a6 unify lint options for all modules 2019-01-27 12:54:56 +01:00
Hannes Achleitner e9c10cdaa8 simplify build concerning maven repos 2019-01-27 12:45:32 +01:00