Commit Graph

2295 Commits

Author SHA1 Message Date
ByteHamster 06fe53f607 Added icons to podcast settings 2019-11-21 11:22:24 +01:00
ByteHamster 08cbb0bf96 Updated streaming icon 2019-11-21 11:08:31 +01:00
ByteHamster 4a6731d4e1 Explicitly set default download/streaming value for existing users
This mankes it easier to change the default later without affecting existing installs
2019-11-21 10:28:36 +01:00
H. Lehmann f7dc2d6a7d
Merge pull request #3624 from ByteHamster/fix-download-order
Fix download order list
2019-11-21 10:05:48 +01:00
ByteHamster 6c43263446 Show custom title on download log page 2019-11-20 20:41:11 +01:00
ByteHamster 5bd3698e81 Fix download order list 2019-11-20 19:52:19 +01:00
ByteHamster d8fce1ccbf Added different icon to debug version 2019-11-20 17:58:26 +01:00
H. Lehmann a6e4c4756c
Merge pull request #3611 from ByteHamster/feeditem-viewpager
Switched from gestures to ViewPager
2019-11-15 17:13:37 +01:00
ByteHamster 3c6540b82e Added pubDate test 2019-11-15 15:41:55 +01:00
ByteHamster 5f7a11a865 Fixed feeditem date update
Bug introduced in d88e1202b1
2019-11-15 15:25:39 +01:00
ByteHamster 4336c10fb1 Tiny layout improvements 2019-11-15 10:43:26 +01:00
ByteHamster 27b92532da Added overflow property 2019-11-13 11:02:20 +01:00
ByteHamster cf2e784792 Reformatted css for readability 2019-11-13 11:02:07 +01:00
H. Lehmann a3a5ac5de7
Merge pull request #3592 from orionlee/more_respect_download_order_2448_handle_cancel
More respect download order - handle cancel
2019-11-12 19:29:25 +01:00
H. Lehmann 60a070b56c
Merge pull request #3597 from ByteHamster/rework-about-screen
Rework about screen
2019-11-09 10:15:18 +01:00
ByteHamster dfe463393b Added developers list 2019-11-09 09:52:20 +01:00
ByteHamster 04e6764085 Made add podcast button even more prominent 2019-11-07 20:16:49 +01:00
orionlee dc6221fb82 respect download order - dequeue upon cancelling download 2019-11-06 14:03:26 -08:00
orionlee a6e5cd144d refactor downloadMedia() - make DownloadService accepts a batch of DownloadRequests.
- the DB logic originally in DBTasks.downloadFeedItems() are moved to DownloadService.
2019-11-06 14:03:21 -08:00
orionlee 7bc5ca74f1 make DownloadRequest ArrayList parcelable (support a batch of them) 2019-11-06 13:54:20 -08:00
orionlee fe33821e68 Refactor downloadMedia() : move entry points to DownloadRequester (from DBTasks) 2019-11-06 13:54:20 -08:00
H. Lehmann 3c0489890c
Merge pull request #3587 from ByteHamster/remove-commons-text
Removed commons text library that was just used 2 times
2019-11-06 19:38:01 +01:00
ByteHamster a6624a9d05 Moved robotium dependency to test flavour 2019-11-06 18:47:13 +01:00
ByteHamster d953692443 Removed commons text library that was just used 2 times 2019-11-06 17:18:08 +01:00
H. Lehmann 9df14af284
Merge pull request #3583 from ByteHamster/fix-headset-button-play
Fixed pressing play from headset button
2019-11-05 23:59:40 +01:00
H. Lehmann 17dc3c7471
Merge pull request #3584 from ByteHamster/fix-streaming-notification
Do not display streaming notification if continuous playback is disabled
2019-11-05 23:59:25 +01:00
ByteHamster 48dc4a8345 Do not display streaming notification if continuous playback is disabled 2019-11-05 23:51:38 +01:00
ByteHamster 24a7c11788 Fixed pressing play from headset button
When pausing, we stop the foreground service. This prevented re-entering
foreground state later, which lead to Android killing the service after a
few seconds.
2019-11-05 23:47:40 +01:00
H. Lehmann af3cebbd08
Merge pull request #3582 from ByteHamster/empty-view-subscriptions
Added empty view to subscription list
2019-11-05 23:39:02 +01:00
ByteHamster cbc4e9dc36 Added empty view to subscription list 2019-11-05 23:34:16 +01:00
H. Lehmann e7b0fb729b
Merge pull request #3581 from ByteHamster/feedview-dialog
Style OnlineFeedViewActivity like a dialog
2019-11-05 23:30:42 +01:00
orionlee 89d76702c0 code style - reduce nested ifs 2019-11-05 12:34:12 -08:00
orionlee 9d6db7b9fc enqueue respect download order: add test case for download failures. 2019-11-05 12:34:11 -08:00
orionlee 6e019f72de code style / comment tweak per review 2019-11-05 12:34:11 -08:00
orionlee b80973bc30 refactor - make enqueue position logic more readable per review. 2019-11-05 12:34:11 -08:00
orionlee 52f6a121f1 AFTER_CURRENTLY_PLAYING enqueue location option - test boundary condition handling 2019-11-05 12:34:11 -08:00
orionlee e233398753 code style fixes: naming, indentation. 2019-11-05 12:34:11 -08:00
orionlee bddd2bfa2e enqueue location: use the new 3-value settings 2019-11-05 12:34:11 -08:00
orionlee 52521ecddb #2652 the UI of a new setting enqueue location
- replaced existing enqueue at front
- the option after current episode will replace Keep In-Progress in Queue that was in the PR (30f104f4).
2019-11-05 12:34:11 -08:00
orionlee 406f1cceb8 refactor move generic Collection helpers to CollectionTestUtil 2019-11-05 12:34:11 -08:00
orionlee d24669d4c1 refactor extract common FeedItem List to IDs method 2019-11-05 12:34:11 -08:00
orionlee 69c0022472 code style fixes - naming, indentation, etc. 2019-11-05 12:34:11 -08:00
orionlee 418d4fa4d4 bugfix respect download order - obey user settings "Enqueue Downloaded" 2019-11-05 12:34:11 -08:00
orionlee fb6fa010f8 Enqueue tweaks - replace custom stub DownloadStateProvider with mockito mocks in test 2019-11-05 12:34:11 -08:00
orionlee 2f82a5d464 refactor - rename FeedFileDownloadStatusRequesterInterface to a more generic DownloadStateProvider. 2019-11-05 12:34:11 -08:00
orionlee cd3d20d613 refactor - move ItemEnqueuePositionCalculator to top-level per review. 2019-11-05 12:33:58 -08:00
orionlee 2d1ee52014 fix imports post androidX migration 2019-11-05 11:04:23 -08:00
orionlee fb7fb05b5e test case tweak: preserve download order test, fix test case name
(remove the incomplete expected from test case name)
2019-11-05 11:04:23 -08:00
orionlee 820b0b0793 test case bug fix: Bulk download 2nd item position should be 1 2019-11-05 11:04:23 -08:00
orionlee ce5aa26878 refactoring test - factor out common operations of calc position,
add to queue and verify result into common helper.
2019-11-05 11:04:23 -08:00
orionlee fb824b541d Test cases readability: change expected format from position to the actual queue
(list of IDs), to make the test case more readable.
2019-11-05 11:04:23 -08:00
orionlee 97905e5ed4 #2448: make podcast episode enqueue position respect download start order 2019-11-05 11:04:17 -08:00
orionlee 0973efa943 refactor test - break ItemEnqueuePositionCalculatorTest to be more modular
to prepare for testing more complex enqueue options.
2019-11-05 10:54:21 -08:00
orionlee 17e61335db #2652 (part of): Expose keep in-progress at front as a preference
(in Playback > Queue section)
2019-11-05 10:54:21 -08:00
orionlee 30f104f40b #2652 (part of): The in-progress podcast at the front of the queue
should remain at the front.
2019-11-05 10:54:21 -08:00
orionlee bfde3c7315 refactor - DBWriterTest: parametrize the set of tests 2019-11-05 10:54:21 -08:00
orionlee ba27ec6b31 refactor - DBWriter.addQueueItem() : refactor enqueue position calculation
to be a unit-testable component (static inner class)
2019-11-05 10:54:21 -08:00
ByteHamster 8aff9709c3 Style OnlineFeedViewActivity like a dialog
User study showed that new users do not get the difference between the actual
feed list and the preview. If the preview is a dialog, this is a lot easier to see.
Additionally, the "dialog" now closes after the subscription succeeded.
2019-11-05 15:28:32 +01:00
sevenmaster 386395629b Clearer button text for feching podcast (#3575)
When subscribing to a podcast, the old text might be confusing to new users (it's not downloading an episode, just the feed. That is not considered downloading for most users)

Signed-off-by: sevenmaster <seven-master@hotmail.de>
2019-10-31 23:00:39 +01:00
H. Lehmann 2a2ced1631
Merge pull request #3572 from ByteHamster/downloadservice-refactoring
DownloadService refactoring
2019-10-31 09:23:47 +01:00
H. Lehmann e7367e218d
Merge pull request #3571 from ByteHamster/hide-play-button-on-destroy
Updating notification play button in onDestroy
2019-10-30 19:30:20 +01:00
ByteHamster 69f3a1210f Do not refresh feeds more often than necessary 2019-10-30 19:27:38 +01:00
ByteHamster 6825cca32a Updating notification more often 2019-10-30 18:19:36 +01:00
ByteHamster dd5ba4d38d Do not access context in constructor 2019-10-30 18:16:34 +01:00
ByteHamster ea6b41116f Extracted DownloaderFactory to new class 2019-10-30 18:16:26 +01:00
ByteHamster 8f168948ad Reordered methods to have setup on top 2019-10-30 18:06:44 +01:00
ByteHamster 366e60990d Posting downloaders on executor 2019-10-30 18:05:26 +01:00
ByteHamster fe17f1bcb5 Extracted handling completed downloads to method 2019-10-30 17:51:22 +01:00
ByteHamster 74621170fe Converted our own FeedSyncThread to a task+executor 2019-10-30 11:10:44 +01:00
ByteHamster 798868db9c Extracted notification from DownloadService 2019-10-29 23:58:44 +01:00
ByteHamster 056d7db16b Extracted feed sync from DownloadService 2019-10-29 23:39:29 +01:00
ByteHamster 7ae5424479 Updating notification play button in onDestroy 2019-10-29 22:37:58 +01:00
Ptilopsis Leucotis 917e60fbe2 Fix incorrect progress string on widget
If option "pref_followQueue_title" is disabled, when played episode #1 is ended and next episode #2 is loaded, progress string on widget show incorrect information about position and duration of episode, because it show (position / duration) of ended episode #1 instead of (position / duration) of loaded episode #2.
2019-10-29 11:16:06 +03:00
ByteHamster 20e025bd2e Prefer image that is specified in feed over embedded image 2019-10-27 22:52:41 +01:00
H. Lehmann 57818ade38
Merge branch 'develop' into more-eventbus-migration 2019-10-25 11:40:18 +02:00
H. Lehmann a047e34f8e
Merge pull request #3528 from orionlee/podcast_screen_sort_2524
Sort Support in Podcast screen
2019-10-25 11:38:31 +02:00
ByteHamster 1de76f789f Removed EventDistributor 2019-10-25 11:25:21 +02:00
ByteHamster 728ed23077 Migrated feed list update event to EventBus 2019-10-25 11:19:52 +02:00
ByteHamster d4b9d0fd59 Migrated unread items update to EventBus 2019-10-25 11:12:48 +02:00
ByteHamster b5ab7d6d3c Migrated player status event to EventBus 2019-10-25 10:54:40 +02:00
fossterer ca83c59537 Fixes #3444 - Strip off HTML from podcast descriptions 2019-10-24 23:20:31 -04:00
orionlee baec984c0f Feed Sort Order DB column: changed from Integer to Text, to allow flexibility of multiple sorts without DB schema change 2019-10-24 15:32:51 -07:00
orionlee 7687ffb08e Misc code style fixes. 2019-10-24 13:49:32 -07:00
orionlee 007f1fbb87 Remove unused comparators after SortOrder refactoring 2019-10-24 13:39:28 -07:00
H. Lehmann 437f3f29c0
Merge pull request #3551 from ByteHamster/eventdistributor
Migrated some events from EventDistributor to EventBus
2019-10-24 22:28:33 +02:00
H. Lehmann 385bd3597b
Merge pull request #3550 from ByteHamster/remove-resume-intent
Removed resume intent
2019-10-24 22:27:48 +02:00
orionlee 9c895ef15a Test to ensure Feed only accepts INTRA_FEED sort order 2019-10-24 12:17:31 -07:00
orionlee bcd4b49dda feeditem sort - handle boundary conditions 2019-10-24 12:03:22 -07:00
orionlee 306b6f30a4 rename + refactor QueueSorter to FeedItemPermutors, to support both queue and podcast screen. 2019-10-24 11:32:06 -07:00
orionlee f56a02d513 sort in Podcast screen - implement all the sorts 2019-10-24 11:01:48 -07:00
orionlee 05dfccacc3 a new filter icon, to differentiate it from sort per review.
- Icon source: https://materialdesignicons.com/icon/filter-outline
2019-10-24 10:30:32 -07:00
H. Lehmann f41bdcbaf2
Merge pull request #3544 from M-arcel/develop
Transparent widget
2019-10-23 23:11:51 +02:00
ByteHamster ff44f97dd6 Showing a more interesting background image 2019-10-23 23:08:07 +02:00
ByteHamster 6642b79ac3 Code cleanup 2019-10-23 23:08:07 +02:00
ByteHamster 28cc00a016 Material design layout tweaks 2019-10-23 23:08:07 +02:00
Marcel Regeci b513608032 Transparent widget 2019-10-23 23:07:49 +02:00
ByteHamster 7d3b78091f Removed event that is never sent 2019-10-23 22:51:28 +02:00
ByteHamster d8ffa6c459 Migrated playback history events to EventBus 2019-10-23 22:51:21 +02:00
ByteHamster 68da2e022d Migrated download log events to EventBus 2019-10-23 22:41:20 +02:00
ByteHamster a8c1b3c87c Removed resume intent 2019-10-23 22:25:33 +02:00
H. Lehmann bc5f36336e
Merge pull request #3547 from ByteHamster/checkstyle-change
Checkstyle change
2019-10-22 22:59:42 +02:00
ByteHamster cc52fa04fa Enforce MultipleVariableDeclarations checkstyle 2019-10-22 16:53:35 +02:00
orionlee 562ddee7d7 sort in podcast screen - db persistence 2019-10-20 15:21:46 -07:00
orionlee be7db6cef1 sort in podcast screen - logic, no db persistence yet. 2019-10-20 15:21:46 -07:00
orionlee 1620d29549 Sort in Podcast screen - UI 2019-10-20 15:21:46 -07:00
ByteHamster fea84424e3 Removed code duplication from playback tests, added test for ExoPlayer 2019-10-20 23:49:14 +02:00
H. Lehmann f1f91478b6
Merge pull request #3520 from dsmith47/stream
Show stream button rather than download (in queue, podcast views)
2019-10-20 18:54:14 +02:00
H. Lehmann 38a670139f
Merge pull request #3505 from xgouchet/feature/3070_episode_image
Add an option to replace Episode cover with Podcast cover
2019-10-19 22:24:42 +02:00
H. Lehmann 4df98151a5
Merge pull request #3538 from ariedov/crash-on-equalizer-4.1
Fixes crash on equalizer open on Android 4.1
2019-10-19 01:53:08 +02:00
David Leibovych 5f3714a028 Fixes crash on equalizer open on Android 4.1 2019-10-19 00:20:53 +03:00
orionlee 250594827d unit test for get feeditem link with fallback 2019-10-18 11:31:46 -07:00
orionlee 5eaa4dbfb1 bugfix: Share Episode URL - handle empty link 2019-10-17 12:47:45 -07:00
Xavier Gouchet fd5a5d71a2 Add an option to replace Episode cover with Podcast cover
The default is to use the episode cover (keep the previous behavior).

Fixes #3070
2019-10-17 16:00:27 +02:00
Max Bechtold 87cca61dcd Merge remote-tracking branch 'origin/develop' into feat/simple-adjust-volume-per-feed 2019-10-17 13:13:19 +02:00
Max Bechtold cc9c8bb63a #3248 Extract @string resource for summary 2019-10-17 12:06:15 +02:00
Max Bechtold 14db72ac35 #3248 Merge FeedVolumeReduction into VolumeReductionSetting 2019-10-17 11:54:11 +02:00
Max Bechtold 3bc55a09b1 #3248 Rename PlaybackVolumeAdaptor -> ..Updater 2019-10-17 09:56:04 +02:00
Max Bechtold f9cf013b16 #3248 Enable volume reduction for video media 2019-10-17 09:40:18 +02:00
Doug Smith 0bc3294ca4 Implemented feature to show stream button (instead of Download/Play-Pause) in podcast episode views.
* Added user preference to specify that stream buttons are preferred
* Added StreamAction button to trigger streams on podcast options
2019-10-16 04:31:50 -04:00
H. Lehmann 54eeeb4355
Merge pull request #3516 from egsavage/reset-sleep-timer-on-play
Issue #2381 - restart sleep timer on play
2019-10-15 12:12:06 +02:00
Xavier Gouchet 504bbb0058 Remove duplicate string 2019-10-14 09:14:00 +02:00
Xavier Gouchet c81fcba22d Fix formatting 2019-10-14 09:14:00 +02:00
Xavier Gouchet 4f65aa015a Add confirmation dialog before reseting statistics 2019-10-14 09:14:00 +02:00
Xavier Gouchet 4289933155 Optimize the deletion of statistics data 2019-10-14 09:14:00 +02:00
Xavier Gouchet 5989d6daf6 Remove the unnecessary StatisticsEvent 2019-10-14 09:14:00 +02:00
Xavier Gouchet 91463ba877 Remove icon from "Reset statistics" option menu item 2019-10-14 09:14:00 +02:00
Xavier Gouchet f9b413332f Reset playback statistics
Fixes #1867
2019-10-14 09:14:00 +02:00
egsavage a59fd67178 Issue #2381 - restart sleep timer on play 2019-10-13 20:58:28 -04:00
ByteHamster c1d81408c1 Fixed notification reappearing if continuous playback is disabled 2019-10-09 12:26:11 +02:00
H. Lehmann 3980bcca6d
Merge pull request #3386 from orionlee/bugfix_skip_last_episode_in_queue_3383
Bugfix skip last episode in queue - episode status
2019-10-09 12:09:04 +02:00
H. Lehmann 0e614f96e9
Merge pull request #3497 from ByteHamster/position-in-notification
Showing progress in notification
2019-10-06 19:42:14 +02:00
H. Lehmann f750e06a1b
Merge pull request #3498 from ByteHamster/fix-mono-switch
Fixed downmixing if service is not bound
2019-10-06 12:57:07 +02:00
H. Lehmann 935e2ceee0
Merge pull request #3499 from ByteHamster/local-playable-improvements
Local playable improvements
2019-10-06 12:54:14 +02:00
H. Lehmann de10ca9548
Merge pull request #3415 from spacecowboy/per_feed_playbackspeed
Added per-feed playback speed setting
2019-10-06 12:52:55 +02:00
H. Lehmann 526c5744de
Merge pull request #3496 from ByteHamster/default-playback-speed
Added 0.75 to default playback speed list
2019-10-06 12:48:46 +02:00
ByteHamster 6f809b47e6 Speeding up notification update
startForeground() is significantly slower than just notify()
2019-10-06 12:45:22 +02:00
Jonas Kalderstam 138c29df0f Removed potentially misleading comment 2019-10-06 10:06:11 +02:00
ByteHamster b2d9455d6c Caching icon manually to prevent long locks 2019-10-06 10:04:06 +02:00
Jonas Kalderstam cab40dc466 Removed unnecessary comment 2019-10-06 10:04:05 +02:00
ByteHamster 69e51c148e Moved notification setup out of Thread
Fixes wrong thread for media player. Also, might fix race conditions.
2019-10-06 09:11:45 +02:00
ByteHamster e6ae4c23f0 Showing file name if title extraction fails 2019-10-05 23:48:50 +02:00
ByteHamster cf3e8107f3 Syntax cleanup
Mostly replaced tabs with spaces
2019-10-05 23:38:51 +02:00
ByteHamster b081e320e3 Fixed downmixing if service is not bound 2019-10-05 23:04:18 +02:00
ByteHamster 53ea702772 Showing progress in notification 2019-10-05 21:58:25 +02:00
ByteHamster cb942b646a Added 0.75 to default playback speed list
Users on Google Play seem to be confused that they can not select a
playback speed lower than 1x anymore. The reason is that they just
use the preference dialog and that dialog only displays the range
that is selected for the button.
2019-10-05 21:05:28 +02:00
Jonas Kalderstam 9539908f23 Removed unused imports and unnecessary whitespace changes 2019-10-05 02:24:47 +02:00
Jonas Kalderstam 6a37d33b97 Changed from db backed item speed to preferences backed global value 2019-10-05 02:15:26 +02:00
Jonas Kalderstam 97aa360611 Merge remote-tracking branch 'antennapod/develop' into per_feed_playbackspeed 2019-10-05 01:18:14 +02:00
ByteHamster e37bd24364 Fixed free build 2019-10-04 23:20:51 +02:00
ByteHamster 650c5503ad Moved SafeJobIntentService to correct package 2019-10-04 11:24:43 +02:00
ByteHamster 933790b0d3 Fixed compilation 2019-10-04 11:24:27 +02:00
ByteHamster 7574ca7920 Adapted dependency versions to stable ones 2019-10-04 11:23:50 +02:00
ByteHamster c130498fc6 Automatic AndroidX migration 2019-10-04 11:22:39 +02:00
ByteHamster 59d5c3cbf2 Changed color of default notification icon 2019-10-02 16:07:08 +02:00
ByteHamster 71a5a00fd0 Merge branch 'develop' into notification-default-icon 2019-10-02 16:03:11 +02:00
H. Lehmann cbee8c3043
Merge branch 'develop' into feat/simple-adjust-volume-per-feed 2019-10-02 15:58:58 +02:00
H. Lehmann 2db5c00d66
Merge pull request #3482 from ByteHamster/exoplayer-log-source
Added logging to ExoPlayer
2019-10-02 15:58:04 +02:00
ByteHamster cbdd3603aa Added logging to ExoPlayer 2019-10-02 15:42:55 +02:00
orionlee d84fc95f0d test for DownloadService, case media download successful. 2019-09-30 13:46:59 -07:00
H. Lehmann f3b3d5c422
Merge pull request #3476 from ByteHamster/fix-feed-without-identifying-value
Fixed feed without any identifying value
2019-09-30 21:34:56 +02:00
H. Lehmann f862d15753
Merge pull request #3471 from orionlee/bugfix2_player_not_using_downloaded_media_2947
New fix player stuck due to streaming rather than using downloaded media
2019-09-30 21:34:17 +02:00
ByteHamster f71b933c6b Fixed feed without any identifying value 2019-09-30 20:39:02 +02:00
H. Lehmann 694d0f8d34
Merge pull request #3472 from ByteHamster/do-not-spam-logcat
Reduced logcat output
2019-09-30 19:07:56 +02:00
ByteHamster 0ffa0e77d9 Reduced logcat output 2019-09-29 22:07:39 +02:00
orionlee 71de4607a3 bugfix: Ensure when media download completes and item update event is posted, the feed media has been updated, 2019-09-29 12:55:02 -07:00
orionlee 9469ebc6c3 bugfix: Ensure playback service use the updated feedItem after media download completes (rather than trying to stream) 2019-09-29 12:46:21 -07:00
H. Lehmann 5bf7216064
Merge branch 'develop' into feat/simple-adjust-volume-per-feed 2019-09-29 17:31:34 +02:00
H. Lehmann 1709877531
Merge pull request #3470 from ByteHamster/playbackservice-save-current-playable
Moved storing PlaybackPreferences to PlaybackPreferences.java
2019-09-29 17:10:34 +02:00
ByteHamster a3598daaa7 Moved storing PlaybackPreferences to PlaybackPreferences 2019-09-29 16:47:12 +02:00
ByteHamster 1c60a0134d Keep buffer depending on rewind time 2019-09-29 14:05:48 +02:00
H. Lehmann ea84dde76f
Merge pull request #3467 from ByteHamster/keep-back-buffer
Keep 30 seconds of back buffer
2019-09-29 12:56:04 +02:00
H. Lehmann 2dfe08df2a
Merge pull request #3454 from ByteHamster/update-progress
Update episode progress during playback
2019-09-29 12:52:48 +02:00
H. Lehmann c614e6e29c
Merge pull request #3466 from ByteHamster/no-reinit-on-pause
Do not reinit on pause
2019-09-29 12:50:47 +02:00
ByteHamster fc317e3b68 Keep 30 seconds of back buffer 2019-09-29 12:49:06 +02:00
ByteHamster 3beda73e3c Do not reinit on pause 2019-09-29 12:39:13 +02:00
ByteHamster 8d9c292ca1 Merge branch 'develop' into smart-spread-fix 2019-09-29 12:31:55 +02:00
H. Lehmann 373f31c53e
Merge pull request #3416 from orionlee/bugfix_autodownload_wifi_filter_on_android10_3387
Make Automatic Download WiFi filter UI work on Android 10+
2019-09-29 11:16:10 +02:00
H. Lehmann e3ef12e413
Merge pull request #3440 from orionlee/avoid_cast_init_unless_enabled
Avoid Cast initialization unless it is enabled
2019-09-29 11:13:33 +02:00
H. Lehmann fb377258f2
Merge pull request #3461 from ByteHamster/do-not-notify-cancelled-downloads
Do not notify cancelled downloads
2019-09-29 11:10:59 +02:00
orionlee cf5f0fbc28 #3383 Fix skip last episode in queue - the fix 2019-09-28 15:50:12 -07:00
orionlee 11270d91a6 #3383 Fix skip last episode in queue: android test to reproduce it. 2019-09-28 15:50:11 -07:00
Stephen Kitt 7ae3934794
Fix the smart shuffle spread calculation
We want to ensure that the total spread is divisible by all feed
sizes, so the modulo calculation needs to divide spread by the feed
size, not the other way round as is done currently.

In addition, this ensures the per-feed spread is never 0 (so the
degenerate case is equivalent to the old smart shuffle).

Signed-off-by: Stephen Kitt <steve@sk2.org>
2019-09-28 18:11:08 +02:00
ByteHamster 28a816b16c Enabled more checkstyle rules 2019-09-28 17:23:36 +02:00
ByteHamster 66cf4a8a43 Sending event if download was cancelled 2019-09-28 14:20:57 +02:00
ByteHamster 3041336b92 Do not notify cancelled downloads 2019-09-28 13:04:40 +02:00
orionlee 0b5f4e9dc0 Avoid Cast initialization unless it is enabled (to avoid triggering Google Play Service) 2019-09-27 11:19:29 -07:00
orionlee db2141a7b4 #3387 permission prompt - add warning icon to make it stand out. 2019-09-27 10:29:27 -07:00
orionlee d559a8b906 #3387 use ACCESS_FINE_LOCATION per Google feedback
https://issuetracker.google.com/issues/140696830
2019-09-27 10:29:27 -07:00
orionlee c8dda3c0c0 #3387 ask for location permission for Wi-Fi filter UI on Android 10+. 2019-09-27 10:29:26 -07:00
orionlee d80daee37e #3387 new permission for WiFi filter UI be compatible with Android 10+ 2019-09-27 10:29:26 -07:00
ByteHamster 107b64315e Merge branch 'develop' into update-progress 2019-09-27 12:58:56 +02:00
ByteHamster 3e01d66cbd Merge branch 'master' into develop 2019-09-27 12:55:24 +02:00
H. Lehmann a6bffa797a
Merge pull request #3458 from ByteHamster/store-foreground-state-correctly
Fixed another phantom service is running notification
2019-09-27 12:43:03 +02:00
ByteHamster 0c0e50d3ae Fixed another phantom service is running notification
Steps to reproduce:
- Send STOP key two times
- Service starts foreground but does not stop again because stateManager does not know about foreground state
2019-09-27 12:03:39 +02:00
H. Lehmann bbf4f8cc3f
Merge pull request #3453 from ByteHamster/refresh-subscriptions-view
Added refresh item to subscriptions view
2019-09-26 23:45:22 +02:00
ByteHamster 8b53268bfe Refactored method for readability 2019-09-26 19:06:26 +02:00
H. Lehmann b0a77bf000
Merge pull request #3455 from ByteHamster/rxjava-buffering
Using RxJava to update buffering
2019-09-26 19:01:28 +02:00
H. Lehmann 25bd5bbeed
Merge pull request #3450 from ByteHamster/undeliverable-exception
Fixed crashes when leaving search fragments
2019-09-26 18:58:04 +02:00
ByteHamster 56d08c4291 Using RxJava to update buffering 2019-09-26 18:53:04 +02:00
H. Lehmann 1e883758e4
Merge pull request #3451 from ByteHamster/fix-no-browser-installed
Fixed crash if there is no browser installed
2019-09-26 18:52:01 +02:00
ByteHamster b94595fe44 Using RxJava to update position on main thread 2019-09-26 18:47:24 +02:00
H. Lehmann 1cb30ef271
Merge pull request #3452 from ByteHamster/transparent-outline
Removed transparent notification button outline
2019-09-26 17:12:02 +02:00
ByteHamster 66cb923e9d Update playback position in queue 2019-09-25 17:07:24 +02:00
ByteHamster 72fc4f5eb0 Using PlaybackService to distribute position events instead of PlaybackController 2019-09-25 16:44:08 +02:00
ByteHamster 97c2b47a4a Removed ProgressEvent
Database upgrade is done on splash screen
2019-09-25 16:20:24 +02:00
ByteHamster 72d5c65c4f Removed transparent notification button outline 2019-09-25 15:24:23 +02:00
ByteHamster b65c688b53 Fixed crash if there is no browser installed 2019-09-25 15:00:33 +02:00
ByteHamster 2b8b262499 Fixed crashes when leaving search fragments 2019-09-25 14:45:47 +02:00
ByteHamster 96a42b1bbe Fixed HTTP redirects in ExoPlayer 2019-09-25 14:40:18 +02:00
orionlee 26b7f6c300 auto feed update mini-refactor: move periodic update entry point method from UserPreference to AutoUpdateManager 2019-09-24 11:14:35 -07:00
orionlee 33eddaa256 auto feed update - make the calls from UI use background thread rather than WorkManager to ensure the updates are immediate. 2019-09-24 11:07:43 -07:00
orionlee 8dc9939736 change refreshAllFeeds() main thread call guard to exception. 2019-09-24 10:15:25 -07:00
orionlee 0ddda3a0d2 remove unnecessary thread DBTasks.refreshAllFeeds(): it is invoked by FeedUpdateWorker in background only. 2019-09-24 10:15:24 -07:00
orionlee 608b874057 Make feed update work IDs not dependent on classname to avoid accidental changing of IDs due to class refactoring. 2019-09-24 10:12:14 -07:00
orionlee ce96eeafb6 simplify param logic (getInputData() is @NonNull) 2019-09-24 10:12:14 -07:00
orionlee 366146d22e prevent deadlock in case auto feed update is blocked per review. 2019-09-24 10:12:14 -07:00
orionlee 907867652f Refactor automatic feed update - remove extra threads no longer necessary. 2019-09-24 10:12:13 -07:00
H. Lehmann cade85b9c2
Merge branch 'develop' into notification-default-icon 2019-09-24 14:20:13 +02:00
H. Lehmann a92123340d
Merge pull request #3441 from ByteHamster/circleci-improvements
Circleci improvements
2019-09-24 14:19:18 +02:00
ByteHamster 58348908ea Fixed checkstyle violations 2019-09-24 11:27:08 +02:00
orionlee c41c8765b6 SSL android 4 fix - fix code styles 2019-09-23 14:22:16 -07:00
orionlee 6cae7df9bd SSL fix On Android 4.4 for certain web sites. 2019-09-23 14:13:20 -07:00
orionlee 39b202ff45 #2977 fix incorrect "share podcast url" label 2019-09-21 10:27:34 -07:00
H. Lehmann 3491377120
Merge pull request #3354 from ByteHamster/display-buffer-state
Displaying buffer state with ExoPlayer
2019-09-21 09:12:23 +02:00
H. Lehmann 64f26d0712
Merge pull request #3433 from ByteHamster/bug-report-section
Bug report section
2019-09-21 09:08:10 +02:00
H. Lehmann c5dba814d2
Merge pull request #3403 from ByteHamster/follow-system-theme
Add option to follow system theme
2019-09-20 23:47:31 +02:00
H. Lehmann fa3437960b
Merge pull request #3369 from ByteHamster/playback-speed-icon
Added playback speed icon
2019-09-20 23:46:59 +02:00
ByteHamster 2dce723a8d Added button to view mailing list 2019-09-20 23:38:13 +02:00
ByteHamster 742bbc5c92 Updated FAQ icon and text 2019-09-20 23:30:00 +02:00
ByteHamster b931828736 Renamed crash report to bug report 2019-09-20 23:29:48 +02:00
ByteHamster 9609eb6977 Removed link to known issues 2019-09-20 23:17:29 +02:00
H. Lehmann de4f782e54
Merge pull request #3414 from ByteHamster/bug-report-screen
Added screen that shows crash info
2019-09-20 23:10:31 +02:00
H. Lehmann 46c8679fe2
Merge branch 'develop' into follow-system-theme 2019-09-20 23:06:56 +02:00
H. Lehmann 08058152a7
Merge pull request #3408 from ByteHamster/update-speed-button-text
Allow to set playback speed while service is not running
2019-09-20 22:52:37 +02:00
H. Lehmann 4777d2df88
Merge pull request #3423 from ByteHamster/notification-icon-key
Updated key notification icon
2019-09-20 22:49:59 +02:00
ByteHamster d5130b21e3 Update playback speed button if service is not running 2019-09-20 22:49:03 +02:00
H. Lehmann aaafd5d715
Merge branch 'develop' into lock-queue 2019-09-20 22:09:57 +02:00
H. Lehmann 569ee7cfdc
Merge pull request #3421 from ByteHamster/removed-unused-resources
Removed unused resources
2019-09-20 22:08:01 +02:00
H. Lehmann ee02dc40fc
Merge pull request #3424 from ByteHamster/preferences-apply
Calling apply() on preferences edit
2019-09-20 22:06:19 +02:00
H. Lehmann f6c8279030
Merge pull request #3422 from ByteHamster/fix-id-language
Fixed indonesian translation folder
2019-09-20 22:05:57 +02:00
H. Lehmann d394996970
Merge pull request #3425 from ByteHamster/cleanup
Removed unused code
2019-09-20 22:05:39 +02:00
ByteHamster cf261871a8 Updated translations 2019-09-20 19:56:50 +02:00
orionlee 5bc1fc4f28 #3387 short-term (v1.7.3) fix for WiFi filter UI on Android 10+
(Requires user to grant location permission manually)
2019-09-16 12:25:08 -07:00
Jonas Kalderstam de78c0e31e Fixed playback speed not changing when episode ended and next started playing 2019-09-16 14:38:07 +02:00
ByteHamster 79c94112ef Removed unused code 2019-09-14 21:14:16 +02:00
ByteHamster 9a716ba4ac Calling apply() on preferences edit 2019-09-14 20:52:27 +02:00
ByteHamster 3a150bdb63 Updated key notification icon
Notification icons must be white and square
2019-09-14 19:35:23 +02:00
ByteHamster 29f429f897 Fixed indonesian translation folder 2019-09-14 19:28:03 +02:00
ByteHamster 498f4759cb Removed unused themes 2019-09-14 18:55:52 +02:00
ByteHamster b54849d459 Removed unused strings 2019-09-14 18:49:08 +02:00
ByteHamster 6f530d9c7d Removed unused colors and dimens 2019-09-14 18:39:55 +02:00
ByteHamster b805b41dd6 Using a single notification icon 2019-09-14 18:35:14 +02:00
ByteHamster 983b5ea060 Removed unused icons 2019-09-14 18:24:07 +02:00
Jonas Kalderstam d746121a9b Included Media playback speed into controller getter 2019-09-14 00:13:19 +02:00
Jonas Kalderstam 60eb41048f Converted playback speed in media preferences to a float instead of String 2019-09-14 00:09:24 +02:00
Jonas Kalderstam 684213c291 Moved logic for selecting playback speed entirely to UserPreferences 2019-09-13 23:53:42 +02:00
Jonas Kalderstam 19896f0ec2 Removed unused methods 2019-09-13 23:30:20 +02:00
Jonas Kalderstam d0f19a2b14 Inlined getFeedPlaybackSpeed method on FeedItem 2019-09-13 23:27:55 +02:00
Jonas Kalderstam 3bcb368bb3 Check the media's own speed before loading video speed 2019-09-13 23:22:13 +02:00
Jonas Kalderstam e5176c6a19 Updated database version to 1.7.4 2019-09-13 21:27:02 +02:00
Jonas Kalderstam b1190881ba Set a default value for last playback speed in database 2019-09-13 00:31:09 +02:00
Jonas Kalderstam 2edc40cd6e Changed database version in upgrade to be at least 1.7.4 2019-09-13 00:31:09 +02:00
Jonas Kalderstam 4746b16b12 Changed type of media last playback speed to float from string
Also sets default to "magic" -1 value
2019-09-13 00:31:09 +02:00
Jonas Kalderstam 7cc602a078 Set a descriptive summary on the per-feed playback speed setting 2019-09-12 11:06:05 +02:00
Jonas Kalderstam 6b1a7a9162 Fixed playback speed issues when switching to next media
Fixes some issues related to the playback speed when playback was
completed or playback was paused and the app went away for awhile.

Now a media item which is "in progress" will remember its playback
speed so that it can be restored properly. The per-feed-media speed is
cleared once playback finishes, either by reaching the end or by the
user starting to play something different.
2019-09-12 10:57:16 +02:00
Jonas Kalderstam 4054c330ac Added per-feed playback speed setting
Fixes #375
2019-09-12 00:50:07 +02:00
ByteHamster 5f01e5045a Added screen that shows crash info 2019-09-11 23:43:05 +02:00
ByteHamster facc5dccf5 Added warning when locking queue 2019-09-11 22:33:16 +02:00
ByteHamster 93812f1b15 Fixed widget if playbackservice is not running 2019-09-11 16:48:13 +02:00
H. Lehmann eedd3ce755
Merge pull request #3399 from ByteHamster/remove-unused-color
Removed unused color resource
2019-09-10 23:57:53 +02:00
ByteHamster c4c1780da4 Add option to follow system theme 2019-09-10 23:43:01 +02:00
ByteHamster fe56265114 Restart service when re-gaining audio focus 2019-09-10 14:18:14 +02:00
ByteHamster bb72636c68 Removed unused color resource 2019-09-09 19:31:28 +02:00
ByteHamster 0d0566e595 Fixed receiving audio events after service shutdown 2019-09-09 18:42:28 +02:00
ByteHamster 8802535e76 Making sure that intents are not overwritten 2019-09-06 08:09:53 +02:00
ByteHamster cff377ab71 Pulled translations 2019-09-04 23:42:55 +02:00
H. Lehmann cbaf8818bf
Merge pull request #3371 from ByteHamster/notification-action-foreground
Executing notification actions in foreground
2019-09-03 19:14:52 +02:00
ByteHamster dcc6642f33 Updated default notification icon 2019-09-03 15:58:33 +02:00
ByteHamster 5825b7645b Executing notification actions in foreground 2019-09-03 15:23:09 +02:00
ByteHamster 11e68419f0 Added playback speed icon 2019-09-02 14:57:30 +02:00
ByteHamster 7cc5f86979 Do not crash when cancelling gpodder podcast loading 2019-09-02 00:19:56 +02:00
ByteHamster 9dc0297c7f Pulled translations 2019-09-01 12:16:59 +02:00
ByteHamster ebd409f8ab Also ignore undeliverable InterruptedIOExceptions 2019-09-01 12:00:37 +02:00
H. Lehmann a0ee6a8ca7
Merge pull request #3352 from ByteHamster/delete-current-feed
Fixed deleting currently playing feed
2019-08-31 14:03:56 +02:00
ByteHamster be6c8c70b4 Added fast scroll to episodes fragment 2019-08-31 01:10:44 +02:00
ByteHamster c68f2f75ca Displaying buffer state with ExoPlayer 2019-08-31 00:18:08 +02:00
ByteHamster 4962f0693f Fixed deleting currently playing feed 2019-08-30 22:34:43 +02:00
H. Lehmann 8a3e4f8765
Merge pull request #3351 from ByteHamster/lazy-load-episodes
More episodes on all episodes
2019-08-30 15:10:45 +02:00
Jan-Peter von Hunnius 2ba91f4f33 More episodes on all episodes 2019-08-30 15:09:54 +02:00
ByteHamster e58dbfbd15 Allow to delete currently playing media 2019-08-30 14:26:57 +02:00
ByteHamster b74c6083c0 Added missing import 2019-08-30 14:01:15 +02:00
H. Lehmann 46af0e0c36
Merge pull request #3349 from ByteHamster/no-crash-after-dispose
Do not crash on undeliverable InterruptedException
2019-08-30 13:44:13 +02:00
ByteHamster af8dc2c9b9 Do not crash on undeliverable InterruptedException 2019-08-30 13:35:30 +02:00
H. Lehmann f263ca8cd7
Merge pull request #3347 from ByteHamster/remove-notification
Playback service notification improvements
2019-08-30 13:09:51 +02:00
ByteHamster 5521a7a4e1 Updated streaming confirmation icon 2019-08-30 13:07:58 +02:00
ByteHamster 4678297ec3 Added button to always allow streaming 2019-08-30 13:07:58 +02:00
ByteHamster e6ad131d37 Added media details to dummy notification 2019-08-30 13:07:58 +02:00
ByteHamster f0acfa4263 Do not hide notification on audio focus loss 2019-08-30 13:07:58 +02:00
H. Lehmann b0f97fdd89
Merge pull request #3348 from ByteHamster/translate-preference-search
Extracted preference search string resources
2019-08-30 13:03:21 +02:00
H. Lehmann 9ae179adce
Merge pull request #3343 from ByteHamster/video-playback-speed
Allow to adjust video playback speed
2019-08-30 13:03:06 +02:00