Commit Graph

12441 Commits

Author SHA1 Message Date
Matt Gibson b208866109
[PS-1854] Split folder service back/foreground (#4209)
* Split folder service back/foreground

Also splits for folderApiService, since that depends on folderService.

TODO: this split will need to be done for any dependents of a split
service.

* Prefer popup-specific services VaultFilterService

* Prefer popup-specific services i18n

* Prefer popup-specific services configService

* StateService is required for browserSync

* Add Policy Api Service

* Remove unused orgService from PolicyApiService

* Fixup missed dependency

* Attach cryptography services in popup context

* Improve session syncer initialization
2023-01-30 13:04:22 -06:00
Daniel James Smith b7d38f0f72
[PS-2320] Import API service refactor (#4529)
* Extract import methods from ApiService

Removed methods from ApiService impl and abstraction
Create import-api.service impl and abstraction
Moved import.service into abstractions/import/import.service.abstraction
Moved import.service into services/import/import.service
Change imports to use new services

* Fix import for tests

* Fix imports for CLI

* Fix imports for web

* Fix ModuleImports and dependencies

* Mark ImportApiService methods as async
2023-01-30 20:03:12 +01:00
Michał Chęciński 4584583691
Add individual packages hash files to release (#4254)
* Add script to export sha from latest.yaml to files

* Comment out for testing

* Comment out

* Fix

* Remove test comments

* Use new gh action

* Change get checksums action reference to commit hash from master

* Comment out for testing

* Change get-checksum version to branch fix-get-checksum-action

* Comment out gh release if

* Restore if in create release step

* TEst

* Remove comments

* Change path

* Remove unused script

* Add commit SHA for get checksum action

* Update .github/workflows/release-desktop.yml

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>

---------

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2023-01-30 11:19:40 -05:00
Jake Fink 64e0d45caf
[EC-1022] add hint to group name input about max chars (#4553) 2023-01-30 11:08:54 -05:00
Will Martin 62986be1a2
[SM-325] update header layout to support projected content (#4509)
* expose breadcrumbs to shared module; remove extra whitespace from breadcrumb

* update sm-header to accept projected content; update layout style & semantics

* remove searchTitle route data; change title to titleId

* update styles

* update SM pages to use new header

* add button slot to header

* remove breadcrumbs from shared module

* update project tabs

* update content projection to use slot attribute

* hide tabs container

* add icon input to header

* add breadcrumbs to service account page

* update padding

* update styles

* code style changes

* create access token button component

* simplify access token logic

* add create access token button to header

* update sm-no-items content projection

* revert irrelevant commits

* add header title slot; rename template vars for clarity

* add storybook stories

* remove sm-new-menu from default view; refactor search/button content projection

* remove unused styles; fix title truncate

* remove unnecessary classes

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

---------

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2023-01-30 10:58:40 -05:00
Bernd Schoolmann 01091fe260
[PS-2365] Kdf Configuration Options for Argon2 (#4578)
* Implement argon2 config

* Remove argon2 webassembly warning

* Replace magic numbers by enum

* Implement kdf configuration

* Update UI according to design feedback

* Further updates to follow design feedback

* Add oxford comma in argon2 description

* Fix typos in argon2 descriptions

* move key creation into promise with API call

* change casing on PBKDF2

* general improvements

* kdf config on set pin component

* SHA-256 hash argon2 salt

* Change argon2 defaults

* Change argon2 salt hash to cryptoFunctionService

* Fix isLowKdfIteration check

---------

Co-authored-by: Kyle Spearrin <kyle.spearrin@gmail.com>
Co-authored-by: Kyle Spearrin <kspearrin@users.noreply.github.com>
2023-01-30 09:07:51 -05:00
Daniel James Smith b1a1068906
[PS-2096] BEEEEP: Add Psono importer (#4286)
* Add psono json importer

Create types for psono export format
Add test files
Write tests for psono-json-importer
Write importer for psono export
Register 'psonojson' with `importOptions`
Import/register psono-json-importer with import.service
Add instructions on how to export from Psono

* Retain all imported data

Ensure all data is retained by adding unmapped properties into custom fields
Each item type has a set of mapped properties, anything not matching will be created as a custom field
Write extensive tests to ensure data is present

* Skipping GPG

We currently cannot import GPG Keys into notes or custom fields

* Add organizational test

Verify that folders get converted to collections when imported by an org

* Remove combined test-file (whole export)

* Remove redundant null type
2023-01-30 13:56:49 +01:00
Joseph Flinn 651968ca9c
Support deploying to more non-prod environments (#4585)
* Update the QA deploy workflow to deploy to multiple non-prod environments

* Fix linter issues

* Update with testing code if run with QA

* Fix bash typo

* revert name

* Fix name

* Adding some logging

* Fix environment branch typo

* Add QA configuration and renable

* Rename workflow file

* Update .github/workflows/deploy-non-prod-web.yml

Switch config logic to a more extensible one.

Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com>

* Fix a typo

* Add the original workflow in for QA for no disruptions

* Add line

---------

Co-authored-by: mimartin12 <77340197+mimartin12@users.noreply.github.com>
2023-01-27 13:40:50 -08:00
Kyle Spearrin 61d94c7e59
[PS-2367] CLI pkg ref for argon2 lib (#4579)
* pkg ref argon2

* add argon to cli package.json

* argon2 assets

* ci matrix for cli

* simplify builds for testing

* fix env

* zip for each os

* add os prefix back to zip

* create checksums

* make sums 256

* fix shasum command

* combine some steps for unix

* LOWER_RUNNER_OS

* SHORT_RUNNER_OS

* SHORT_RUNNER_OS on dist

* upload unix assets

* restore old build files

* fix formatting

* fix zip folder structure

* fix condition on upload unix zip asset

* compute shasum like other parts of build

* change matrix os targets
2023-01-27 09:52:08 -05:00
github-actions[bot] b7a5c2731d
Autosync the updated translations (#4583)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-01-27 12:18:43 +01:00
Daniel James Smith 75fbccb945
[PS-1137] Fix reseed storage (#4543)
* Fix storage reseed on logout

The check for the set vault-timeout needs to happen before all cleaning stateService
Remove check inside of reseedStorage as happens outside prior to calling it (logout/settings.component)

* Remove old limitation to only run on certain browsers

Execute on all browsers besides Safari as it does not support chrome.storage.local.get with an empty key

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea/get

* Revert "Remove old limitation to only run on certain browsers"

This reverts commit d7f71aa0b6.
2023-01-27 11:49:35 +01:00
github-actions[bot] 692201051a
Autosync the updated translations (#4584)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-01-27 01:42:30 +01:00
github-actions[bot] 43de86e2c2
Autosync the updated translations (#4582)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-01-27 01:41:55 +01:00
Joseph Flinn 05dec84f0f
Add new POC web artifact (#4581)
* Add the poc web artifact.

* Fix npm command typo
2023-01-26 13:38:41 -08:00
SmithThe4th f274540896
[SG-997] Add warning for low kdf iterations (#4570)
* Created low kdf component

* added low kdf transalation message

* Registered commponent

* Referenced low kdf child compoenent to vault

* Added showLowKdf variable to determine if card should be shown

* Removed test flag

* Updated renamed enum

* Capitalized kdf text
2023-01-26 14:55:24 -05:00
Will Martin c6c81c3a60
[SM-438] fix: table header styles (#4577) 2023-01-26 11:05:39 -05:00
Bernd Schoolmann e055e68991
[PS-2251] Implement argon2 kdf (#4468)
* Implement argon2

* Remove argon2 webassembly warning

* Replace magic numbers by enum

* move packages

* cleanup call to argon2

* update call to node argon2

* don't need  wasm-eval

* revert config changes

* Update libs/common/src/enums/kdfType.ts

Co-authored-by: Martin Weinelt <mweinelt@users.noreply.github.com>

* Update kdfType.ts

* apply DEFAULT_PBKDF2_ITERATIONS

* checkIfWasmSupported

Co-authored-by: Kyle Spearrin <kyle.spearrin@gmail.com>
Co-authored-by: Kyle Spearrin <kspearrin@users.noreply.github.com>
Co-authored-by: Martin Weinelt <mweinelt@users.noreply.github.com>
2023-01-26 09:20:12 -05:00
Oscar Hinton d02af23b30
Override eslint config for vscode workspace (#4566) 2023-01-26 14:26:21 +01:00
Jake Fink 989114f174
[EC-1019] add a button to members row around name (#4548) 2023-01-25 11:09:17 -05:00
Jake Fink 451d05e44d
[EC-1024] update groups search placeholder (#4545) 2023-01-25 11:06:02 -05:00
Jake Fink d8689a20b5
[EC-1016][EC-1017][EC-1018] add validation to collection dialog (#4528)
* [EC-1016] add validation to collection dialog

* [EC-1017] add validation to members dialog

* [EC-1017] remove unused imports from members tab

* [EC-1017] move validator out of shared module

* [EC-1018] add validation to group modal
2023-01-25 11:03:09 -05:00
Jake Fink e3f1150fcb
[EC-1026] Use primary action when clicking on vault row (#4541) 2023-01-25 11:01:46 -05:00
Jake Fink d78be8eaf3
[EC-1020] update invite helper text (#4527) 2023-01-25 11:00:42 -05:00
Jake Fink d822c8591d
[EC-1021] move padding to permission select (#4550) 2023-01-25 10:59:55 -05:00
Jake Fink 0ce33fcd3b
[EC-1023] add bitMenuItem to menu buttons (#4551) 2023-01-25 10:58:08 -05:00
Kyle Spearrin 8451cd5d43
resolve tsconfig eslint errors (#4562) 2023-01-25 09:19:15 -05:00
Michał Chęciński 3f3cbccf13
Change NPM api key in CLI release workflow (#4563) 2023-01-25 15:12:18 +01:00
Rui Tomé 4a3bb4b241
[EC-639] Replacing apostrophe char for email values in Policies API request (#4390)
* [EC-639] Replacing single quote char for email values in Policies API request

* [EC-639] Added Utils.encodeRFC3986URIComponent and used in PolicyApiService and TwoFactorAuthenticatorComponent

* [EC-639] Added unit tests for Utils.encodeRFC3986URIComponent
2023-01-25 14:00:46 +00:00
Jared Snider d40a891f71
Feature/SG-878 - Add open simple dialog method on dialog service (#4425)
* SG-878 - First draft - Dialog service now has backwards compatible method for opening a configurable simple dialog.

* SG-878 - People comp - test cases for simple dialog method - more testing required

* SG-878 - Much more simple dialog work - investigating different approaches to see what will work best. Lots of WIP on this one. Includes first draft but working solution for solving placeholder support for non-localized strings.

* SG-878 - (1) Broke out enums and types into separate files for better single responsibility (2) Allow null cancelButtonText for single accept button support

* SG-878 - Configurable simple dialog - removed separate comp approach as it is a maint problem to have simple dialog implemented in two places.

* SG-878 - Added js doc comments for dialog service openSimpleDialog method

* SG-878 - Don't export ConfigurableSimpleDialogComp as only dialogService should use it

* SG-878 - (1) Refactor configurable simple dialog to reduce icon class repetition in html (2) Update simple dialog options to use new Translation interface and update comp to properly process placeholders again

* SG-878 - Reverting all simple dialog changes as, per discussion with Oscar, going to use composition and go with configurable-simple-dialog comp for use in the dialog service

* SG-878 - Testing latest simple dialog changes

* SG-878 - Update simple-dialog-options

* SG-878 - (1) People & collections component now use dialogService.openSimpleDialog vs custom org upgrade dialog comp (2) Rename configurable-simple-dialog to simple-configurable-dialog for better folder placement

* SG-878 - Update formatting of Simple dialog options js doc comments

* SG-878 - Remove test code

* SG-878 -Remove org upgrade dialog component as it has been replaced with dialog service openSimpleDialog method call

* SG-878 - Move models to be near where they are used which is in the simple-configurable-dialog folder.

* SG-878 - Refactor icon classes into simple getter per Oscar's suggestions

* SG-878 - Refactor Translation placeholderValues to be just placeholders

* SG-878 - Refactor Simple Dialog Options to remove isLocalized as it doesn't buy us that much to have it. We can just check if a passed in value is a string or a Translation object to determine if we need to translate it.

* SG-878 - Dialog Svc - remove backdrop classes from openSimpleDialog method as standard open method applies them

* SG-878 - (1) Refactor simple configurable dialog to use comp properties instead of re-using option props (2) Reduce html complexity  (3) Create translate func for code simplification (4)  Remove isTranslation type guard as simple object check is sufficient

* SG-668 - Refactoring collections & people comps use of dialog service openSimpleDialog to condense options per PR feedback

* SG-878 - SimpleConfigDialog - (1) Footer classes were missing so btns were not spaced out properly (2) cancel btn text fixed to reference component property

* SG-878 - First pass at creating a storybook example for the new openSimpleDialog method on the dialogService.

* SG-878 - SimpleConfigurableDialog storybook - now displays callout with dialog results for better example

* SG-878 - SimpleConfigurableDialog - use text-main tailwind class for h2s so that text is colored properly on black background

* SG-878 - SimpleConfigurableDialog - Remove unstyled buttons and colored text and replace with plain secondary buttons to fix visibility issues on dark background.

* Update libs/components/src/dialog/simple-configurable-dialog/models/simple-dialog-type.enum.ts

SG-878 - Remove early commentary about use of simple-dialog-type enum

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/components/src/dialog/simple-configurable-dialog/simple-configurable-dialog.component.html

SG-878 - SimpleConfigurableDialog html - consolidate title html to 1 line

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/components/src/dialog/simple-configurable-dialog/simple-configurable-dialog.component.ts

SG-878 - SimpleConfigurableDialog comp ts - remove unnecessary comment.

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/components/src/dialog/simple-configurable-dialog/simple-configurable-dialog.service.stories.ts

SG-878 - SimpleConfigDialog storybook fixes

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/components/src/dialog/simple-configurable-dialog/simple-configurable-dialog.service.stories.ts

SG-878 - SimpleConfigDialog storybook fixes

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* Update libs/components/src/dialog/simple-configurable-dialog/simple-configurable-dialog.component.ts

SG-878 - SimpleConfigDialog comp - remove unnecessary comment

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>

* SG-668 / SG-878 - Migrate Free Org Upgrade Flows logic from deprecated collections component to vault component

* SG-878 - Refactor the free org upgrade dialog to leverage separate methods to improve code and decrease cyclomatic complexity

Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2023-01-24 16:38:14 -05:00
Brandon Maharaj 497b08df44
[SG-458] Master Password security checks (browser) (#4502)
* work: add base logic for password lookup

* work: added browser support for hibp

* work: SG-558 combine weak + leak warning

* fix: language stuff

* fix: form values are neater tho :(

* fix: no cast
2023-01-24 16:04:01 -05:00
Daniel James Smith ae3edcc34d
[PS-2108] Enpass importer add support for androidurl's (#4314)
* Move and rename importers ater new naming convention

Create a subfolder to hold all enpass-importers
Change names to new naming convention
Fix imports
Remove entries from whitelist

* Added types for exported enpass json file

* Add unit tests to verify for current behaviour

* Prefer types over enums

* Replace `any` types with defined Enpass types

* Add support for parsing Android urls

Fixes #2831
Added test-file with several combinations
Wrote test cases to verify
2023-01-24 21:03:11 +01:00
Patrick 3976271d61
SM-456 fix sentence casing (#4513)
* SM-456 fix sentence casing

Correct sentence case errors in various messages

* Update navigation.component.html

* Menu item

Remove duplicate "new" created by merge of OAVR branch, localize entire nav menu

* running prettier

Co-authored-by: CarleyDiaz-Bitwarden <cdiaz@bitwarden.com>
2023-01-24 14:01:03 -05:00
rr-bw 9e1e1ba4eb
add progress component, template, and stories (#4437) 2023-01-24 08:23:22 -08:00
rr-bw b27e2605d5
add button disabled state: cursor-not-allowed (#4436) 2023-01-24 08:22:10 -08:00
Daniel James Smith 5907ebad3f
[PS-2323] Add honorific title mx (#4533) 2023-01-24 16:54:52 +01:00
Andreas Coroiu 2376632603
[EC-822] fix: filter provider orgs (#4489) 2023-01-24 14:29:29 +01:00
Kyle Spearrin 2563fbd57d
update to 600k per latest owasp (#4546) 2023-01-24 06:34:09 -05:00
Brandon Maharaj e2c25c6aad
[SG-980] Organization name badge color doesn't match their organization avatar color from Vault (#4451)
* fix: adjusted color source priority to deprio  ids

* fix: CAPS LOCK ON

* undo: lets not touch base components :)

* fix: don't use id since orgs rely on names
2023-01-23 13:41:35 -05:00
Oscar Hinton 4d9029b77b
[SM-452] Remove imports view from secrets manager models (#4511) 2023-01-23 17:01:15 +01:00
Robyn MacCallum afcedbaf25
Add variable defining default locale as english (#4406) 2023-01-23 10:39:44 -05:00
Daniel James Smith 6d2a2aa852
dashlane-csv-importer: Set month on import (#4284) 2023-01-23 15:52:38 +01:00
Oscar Hinton 72ec05a3e6
[SM-451] Remove NavigationModule from SharedModule (#4510)
* Remove NavigationModule from SharedModule

* Update apps/web/src/app/shared/shared.module.ts
2023-01-23 10:10:25 +01:00
Brandon Maharaj 139826ffe6
work: frontend changes (#4477) 2023-01-20 13:11:23 -05:00
github-actions[bot] 7dcaff886e
Autosync the updated translations (#4520)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-01-20 18:44:47 +01:00
Justin Baur 9a98e8eb70
[PS-2303] MV3 Service Cache Enhancements (#4507)
* Add Should Listen Gate

* Fixed ServiceCache Being Sent to Wrong Arg

* Await Combined Listener
2023-01-20 12:33:41 -05:00
Jake Fink c5e99b807e
[EC-943] remove deprecated permissions (#4467)
* [EC-943] remove deprecated permissions

* [EC-943] Remove permissions from OAVR changes
2023-01-20 11:06:05 -05:00
github-actions[bot] e7e5918a68
Autosync the updated translations (#4525)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-01-20 16:57:07 +01:00
Andreas Coroiu 7efde3a64a
chore: Re-apply changes from #3971 (#4524) 2023-01-20 16:18:59 +01:00
Brandon Maharaj c62f3a9607
fix: flexy (#4450) 2023-01-20 09:29:21 -05:00
github-actions[bot] 9646f71cbc
Autosync the updated translations (#4519)
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com>
2023-01-20 13:09:57 +01:00