Commit Graph

398 Commits

Author SHA1 Message Date
Patrick H. Lauke cb7b8313a4
[PS-1198] Desktop / Browser: Accessibility - make TOTP countdown announce for assistive technology users (#2660)
* Make totp countdown `aria-hidden`, add copy of countdown as `sr-only` inside totp button, only make it conditionally "exist" on parent focus

* Make exact same changes to desktop totp

* Tweak copy button accessible name approach

instead of `aria-label`, which overrides the content of the button and, because JAWS has trouble announcing the live region in the desktop app, results in JAWS not announcing ANY countdown at all, this at least announces the current countdown number when the button receives focus in JAWS

* Add `aria-atomic="true"`

avoid JAWS/Firefox only announcing the specific digit that updates, rather than the number as a whole

* Update, run prettier, lint

* Remove orphaned jslibs

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2022-10-03 16:53:44 +02:00
github-actions[bot] 24c6f5d313
Bumped desktop version to 2022.9.2 (#3541)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-09-30 08:00:00 -07:00
github-actions[bot] 9ad9645ebe
Autosync the updated translations (#3656)
Co-authored-by: github-actions <>
2022-09-30 03:07:52 +02:00
github-actions[bot] ecde1f075a
Autosync the updated translations (#3655)
Co-authored-by: github-actions <>
2022-09-30 03:05:53 +02:00
github-actions[bot] 7700d31544
Autosync the updated translations (#3654)
Co-authored-by: github-actions <>
2022-09-30 02:55:51 +02:00
Oscar Hinton a0e89af120
[SM-255] Forbid absolute imports in libs (#3624) 2022-09-29 16:38:50 +02:00
Oscar Hinton 5915ef7ed9
[SM-247] Fix csp rules not working for local dev (#3588) 2022-09-29 15:24:04 +02:00
Oscar Hinton c7f85504c5
[SM-254] Rename web vault imports from src to web-vault (#3626) 2022-09-29 14:56:52 +02:00
Michał Chęciński b91e2919b6
Add EE specific web container image (#3604)
* Add build command for ee

* Add config for ee

* Add build workflow for ee

* Change build pipeline for web ee

* Fix name of workflow in trigger

* Build ee image in web build workflow

* Fix name on matrix

* FIx name of the artifact

* Comment out zip extract

* Add zip extract

* All listing dir before unzip

* Add pwd

* Comment out unzipping

* Fix

* Add matrix instead of two stages

* Remove build web ee workflow

* Fix name
2022-09-29 12:21:47 +02:00
Thomas Rittson 24a7abbba7
Fix alignment for long filter names (#3635) 2022-09-29 08:55:51 +10:00
Justin Baur 188ee5df4f
Add Types for Opera API (#3631)
* Add global types

* Update to self

* Remove main.backgroun changes

* Remove one more change
2022-09-28 18:06:10 -04:00
Gbubemi Smith 9c40ac4e14
updated submit button to use the block directive and add loader (#3644) 2022-09-28 18:23:48 +01:00
Justin Baur c6dccc354c
[PS-1092] Organization Service Observables (#3462)
* Update imports

* Implement observables in a few places

* Add tests

* Get all clients working

* Use _destroy

* Address PR feedback

* Address PR feedback

* Address feedback
2022-09-27 16:25:19 -04:00
Gbubemi Smith 2c68518f87
corrected typos (#3633) 2022-09-27 19:10:19 +01:00
Todd Martin cb746824e8
Added CSP rule for DDG email fowarder API (#3630)
Co-authored-by: Todd Martin <>
2022-09-27 13:44:13 -04:00
Colton Hurst d168d5ee9b
Fix last seen & spacing issue (#3567)
* Fix last seen & spacing issue

* Address PR comments, moving try catch to config service
2022-09-27 11:09:48 -04:00
Oscar Hinton 701d795000
Fix storybook (#3625) 2022-09-27 14:42:15 +02:00
Andreas Coroiu cd7c9bfd9f
[EC-556] refactor cl button (#3537)
* [EC-556] feat: convert button into component

* [EC-556] feat: implement loading state

* [EC-556] feat: remove loading from submit button

* [EC-556] fix: add missing import

* [EC-556] fix: disabling button using regular attribute

* [EC-556] fix: missing loading input in story templates

* [EC-556] feat: remove and replace submit button

* Fix packaging on Build Web workflow (#3613)

(cherry picked from commit 67c447d54c)

* [EC-556] fix: replaced buttons should be primary

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2022-09-27 11:25:53 +02:00
Gbubemi Smith 22a878792e
[SG-168] Passwordless login web MVP (#3424)
* passwordless login page redesign

* passwordless login page redesign

* restyled login form to use tailwind

* restyled login form to use tailwind

* moved texts on login device template to locales

* made reactive form changes for clients

* added request model

* made more changes

* added implmentation to auth request api

* fixed refrencing issue

* renamed model property

* Added resend notification functionality

* Added new file

* login with device first draft

* login with device first draft

* login with device first draft

* login with device first draft

* connection to anonymous hub

* connection to anonymous hub

* refactored confirm login response

* removed comment

* cleaned up login

* changed uptyped form builder

* changed uptyped form builder

* [SG-168] Update login strategy with passwordless login credentials.

* [SG-168] Removed logs. Changed inputs for passwordless logic strategy. Removed tokenRequestPasswordless it is using the same as password.

* code cleanup

* code cleanup

* removed login with device from self hosted

* fixed PR comments

* added module for login

* fixed post request bug

* added feature flag

* added feature flag

* added feature flag

Co-authored-by: André Bispo <abispo@bitwarden.com>
2022-09-26 23:26:10 +01:00
github-actions[bot] e8936eb4c6
Autosync the updated translations (#3618)
Co-authored-by: github-actions <>
2022-09-26 21:25:49 +02:00
github-actions[bot] 34178f6efd
Autosync the updated translations (#3619)
Co-authored-by: github-actions <>
2022-09-26 21:22:21 +02:00
github-actions[bot] a50d1004fa
Autosync the updated translations (#3617)
Co-authored-by: github-actions <>
2022-09-26 21:19:40 +02:00
Sammy Chang 96bc18d4ef
Update permission title to allow for translations (#3607) 2022-09-25 12:34:06 +02:00
J. Brock 5f74b9a694
Fix CLI Snap permissions (#3596) 2022-09-23 14:19:14 -06:00
Robyn MacCallum f4e61d1cec
[SG-520] Native messaging handler (#3566)
* [SG-523] Base test runner app for native messages (#3269)

* Base test runner app for native messages

* Remove default test script

* Add case for canceled status

* Modify to allow usage of libs crypto services and functions

* Small adjustments

* Handshake request (#3277)

* Handshake request

* Fix capitalization

* Update info text

* lock node-ipc to 9.2.1

* [SG-569] Native Messaging settings bug (#3285)

* Fix bug where updating setting wasn't starting the native messaging listener

* Update test runner error message

* [SG-532] Implement Status command in Native Messaging Service (#3310)

* Status command start

* Refactor ipc test service and add status command

* fixed linter errors

* Move types into a model file

* Cleanup and comments

* Fix auth status condition

* Remove .vscode settings file. Fix this in a separate work item

* Add active field to status response

* Extract native messaging types into their own files

* Remove experimental decorators

* Turn off no console lint rule for the test runner

* Casing fix

* Models import casing fixes

* Remove in progress file (merge error)

* Move models to their own folder and add index.ts

* Remove file that got un-deleted

* Remove file that will be added in separate command

* Fix imports that got borked

* [SG-533] Implement bw-credential-retrieval (#3334)

* Status command start

* Refactor ipc test service and add status command

* fixed linter errors

* Move types into a model file

* Cleanup and comments

* Fix auth status condition

* Remove .vscode settings file. Fix this in a separate work item

* Implement bw-credential-retrieval

* Add active field to status response

* Extract native messaging types into their own files

* Remove experimental decorators

* Turn off no console lint rule for the test runner

* Casing fix

* Models import casing fixes

* Add error handling for passing a bad public key to handshake

* [SG-534] and [SG-535] Implement Credential Create and Update commands (#3342)

* Status command start

* Refactor ipc test service and add status command

* fixed linter errors

* Move types into a model file

* Cleanup and comments

* Fix auth status condition

* Remove .vscode settings file. Fix this in a separate work item

* Implement bw-credential-retrieval

* Add active field to status response

* Add bw-credential-create

* Better response handling in test runner

* Extract native messaging types into their own files

* Remove experimental decorators

* Turn off no console lint rule for the test runner

* Casing fix

* Models import casing fixes

* bw-cipher-create move type into its own file

* Use LogUtils for all logging

* Implement bw-credential-update

* Give naming conventions for types

* Rename file correctly

* Update handleEncyptedMessage with EncString changes

* [SG-626] Fix Desktop app not showing updated credentials from native messages (#3380)

* Add MessagingService to send messages on login create and update

* Add `not-active-user` error to create and update and other refactors

* [SG-536] Implement bw-generate-password (#3370)

* implement bw-generate-password

* Fix merge conflict resolution errors

* Update apps/desktop/native-messaging-test-runner/src/bw-generate-password.ts

Co-authored-by: Addison Beck <addisonbeck1@gmail.com>

* Logging improvements

* Add NativeMessagingVersion enum

* Add version check in NativeMessagingHandler

Co-authored-by: Addison Beck <addisonbeck1@gmail.com>

* Refactor account status checks and check for locked state in generate command (#3461)

* Add feawture flag to show/hide ddg setting (#3506)

* [SG-649] Add confirmation dialog and tweak shared key retrieval  (#3451)

* Add confirmation dialog when completing handshake

* Copy updates for dialog

* HandshakeResponse type fixes

* Add longer timeout for handshake command

* [SG-663] RefactorNativeMessagingHandlerService and strengthen typing (#3551)

* NativeMessageHandlerService refactor and additional types

* Return empty array if no uri to retrieve command

* Move commands from test runner into a separate folder

* Fix bug where confirmation dialog messes with styling

* Enable DDG feature

* Fix generated password not saving to history

* Take credentialId as parameter to update

* Add applicationName to handshake payload

* Add warning text to confirmation modal

Co-authored-by: Addison Beck <addisonbeck1@gmail.com>
2022-09-23 15:47:17 -04:00
github-actions[bot] 32eac70c82
Autosync the updated translations (#3598)
Co-authored-by: github-actions <>
2022-09-23 02:02:54 +02:00
github-actions[bot] a8f54f1c45
Autosync the updated translations (#3597)
Co-authored-by: github-actions <>
2022-09-23 02:02:25 +02:00
Matt Gibson df9e6e21c9
Ps 1291/apply to from json pattern to state (#3425)
* Clean up dangling behaviorSubject

* Handle null in utils

* fix null check

* Await promises, even in async functions

* Add to/fromJSON methods to State and Accounts

This is needed since all storage in manifest v3 is key-value-pair-based
and session storage of most data is actually serialized into an
encrypted string.

* Simplify AccountKeys json parsing

* Fix account key (de)serialization

* Remove unused DecodedToken state

* Correct filename typo

* Simplify keys `toJSON` tests

* Explain AccountKeys `toJSON` return type

* Remove unnecessary `any`s

* Remove unique ArrayBuffer serialization

* Initialize items in MemoryStorageService

* Revert "Fix account key (de)serialization"

This reverts commit b1dffb5c2c, which was breaking serializations

* Move fromJSON to owning object

* Add DeepJsonify type

* Use Records for storage

* Add new Account Settings to serialized data

* Fix failing serialization tests

* Extract complex type conversion to helper methods

* Remove unnecessary decorator

* Return null from json deserializers

* Remove unnecessary decorators

* Remove obsolete test

* Use type-fest `Jsonify` formatting rules for external library

* Update jsonify comment

Co-authored-by: @eliykat

* Remove erroneous comment

* Fix unintended deep-jsonify changes

* Fix prettierignore

* Fix formatting of deep-jsonify.ts

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com>
2022-09-22 07:51:14 -05:00
github-actions[bot] 30f38dc916
Bumped web version to 2022.9.2 (#3586)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-09-21 22:25:36 -04:00
github-actions[bot] 0be448b4da
Autosync the updated translations (#3581)
Co-authored-by: github-actions <>
2022-09-21 19:07:01 +02:00
github-actions[bot] 174603b484
Autosync the updated translations (#3582)
Co-authored-by: github-actions <>
2022-09-21 19:06:02 +02:00
github-actions[bot] 73b95cf8c4
Autosync the updated translations (#3583)
Co-authored-by: github-actions <>
2022-09-21 19:05:10 +02:00
ATJB 8cc54181fc
Correct bw send get -h internal CLI documentation (#3576) 2022-09-21 10:43:23 -05:00
ATJB 144d0a8beb
Corrected help command string (#3560) 2022-09-21 09:48:17 -05:00
Patrick H. Lauke 0eb3f369dc
[SM-223] Web: change `<h2>` modal title to `<h1>`, tweak styles to keep same look (#3328)
Co-authored-by: Hinton <hinton@users.noreply.github.com>
2022-09-20 13:14:04 +02:00
cyprain-okeke 684eb7adf3
[Ps 1319] When the name of an entry is too long, the Icon indicating it is shared is not shown (#3500)
* fixing the bug ps-1319 by using ellipsis pipe which deafultg 25 character length

* pass 20 as the limit length instead default 25

Co-authored-by: dynwee <onwudiweokeke@gmail.com>
2022-09-17 11:53:55 +01:00
Oscar Hinton 1c2e74b6bd
Automatically build native rust for desktop in dev (#3510) 2022-09-16 11:53:29 +02:00
github-actions[bot] 0783bb2f7d
Autosync the updated translations (#3547)
Co-authored-by: github-actions <>
2022-09-16 03:24:59 +02:00
github-actions[bot] cf611141eb
Autosync the updated translations (#3546)
Co-authored-by: github-actions <>
2022-09-16 03:24:05 +02:00
github-actions[bot] cdafe26ec8
Autosync the updated translations (#3545)
Co-authored-by: github-actions <>
2022-09-16 03:22:46 +02:00
Gbubemi Smith 734f052faa
[SG-590] Missing error messages (#3514)
* added removed locale keys on clients

* resolved comments
2022-09-15 18:02:01 +01:00
Robyn MacCallum ed78f7e7cb
[SG-397] Configure jest for Desktop and add simple tests (#3467)
* Configure jest for Desktop and add simple tests

* Remove Jest from tsconfig types
2022-09-15 12:31:15 -04:00
github-actions[bot] 669a3572b8
Bumped web version to 2022.9.1 (#3539)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-09-15 11:52:51 -04:00
Todd Martin 722c73580b Merge branch 'master' of https://github.com/bitwarden/clients 2022-09-15 10:17:51 -04:00
Todd Martin 04c2088360 Modified Fastmail CSP to match QA and Production proxies. 2022-09-15 10:17:46 -04:00
Oscar Hinton d2736fe035
[PS-1469] Ensure the window is focused when prompting for biometrics (#3534) 2022-09-15 16:17:09 +02:00
Daniel James Smith 8b73658e54
[PS-1447] Fix issues with CLI stores (npm/choco/snapcraft) (#3477)
* Fix repository url to point to the clients repo

* Fix missing description in snapcraft.yml

* Nuspec: Fix links to point to clients repo

* Nuspec: Use the correct brand icon(same as desktop)

* Nuspec:Update description based on other stores (browser)
2022-09-15 15:27:08 +02:00
Daniel James Smith 02a4fe0236
Updated description based on what we show on other stores (#3478) 2022-09-15 15:26:55 +02:00
aj-rosado f5336a2839
[PS-1111] Added prefix "Vault:" for accessibility on vault selector items (#3188)
* PS-1111 Added prefix "Vault:" for accessibility to vault selector items

* improved html readability

* PS-1111 Added more screen reader accessibility data to the Vault selector on Desktop and Web clients

* PS-1111 removed duplicated aria-label

* PS-1111 Removed unnecessary aria-label attribute

* PS-1111 Changed browser vault item accessibility title from span to button
2022-09-15 12:27:21 +01:00
Justin Baur d2065cc91f
Update CSP rule for Angular CDK (#3529) 2022-09-14 14:02:34 -04:00