rixty/SillyTavern
1
0
Fork 0
mirror of https://github.com/SillyTavern/SillyTavern.git synced 2025-06-05 21:59:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Show error popup if extension update fails

Browse Source
This commit is contained in:
ceruleandeep
2024-12-11 19:37:21 +11:00
parent 19c18d54f5
commit 58ac746442
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
public/scripts/extensions.js
View File

@ -770,7 +770,7 @@ async function showExtensionsDetails() {
/** /**
* Handles the click event for the update button of an extension. * Handles the click event for the update button of an extension.
* This function makes a POST request to '/update_extension' with the extension's name. * This function makes a POST request to '/api/extensions/update' with the extension's name.
* If the extension is already up to date, it displays a success message. * If the extension is already up to date, it displays a success message.
* If the extension is not up to date, it updates the extension and displays a success message with the new commit hash. * If the extension is not up to date, it updates the extension and displays a success message with the new commit hash.
*/ */
@ -783,8 +783,11 @@ async function onUpdateClick() {
return; return;
} }
$(this).find('i').addClass('fa-spin'); const icon = $(this).find('i');
icon.addClass('fa-spin');
await updateExtension(extensionName, false); await updateExtension(extensionName, false);
// updateExtension eats the error, but we can at least stop the spinner
icon.removeClass('fa-spin');
} }
/** /**
@ -803,10 +806,17 @@ async function updateExtension(extensionName, quiet) {
}), }),
}); });
if (!response.ok) {
const text = await response.text();
toastr.error(text || response.statusText, t`Extension update failed`, { timeOut: 5000 });
console.error('Extension update failed', response.status, response.statusText, text);
return;
}
const data = await response.json(); const data = await response.json();
if (!quiet) { if (!quiet) {
showExtensionsDetails(); await showExtensionsDetails();
} }
if (data.isUpToDate) { if (data.isUpToDate) {