From 58ac7464426c4323a2f5af5cc47885dca17a32b5 Mon Sep 17 00:00:00 2001
From: ceruleandeep <deep@cerulean.navy>
Date: Wed, 11 Dec 2024 19:37:21 +1100
Subject: [PATCH] Show error popup if extension update fails

---
 public/scripts/extensions.js | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/public/scripts/extensions.js b/public/scripts/extensions.js
index c73a1fa27..df564e4e4 100644
--- a/public/scripts/extensions.js
+++ b/public/scripts/extensions.js
@@ -770,7 +770,7 @@ async function showExtensionsDetails() {
 
 /**
  * Handles the click event for the update button of an extension.
- * This function makes a POST request to '/update_extension' with the extension's name.
+ * This function makes a POST request to '/api/extensions/update' with the extension's name.
  * If the extension is already up to date, it displays a success message.
  * If the extension is not up to date, it updates the extension and displays a success message with the new commit hash.
  */
@@ -783,8 +783,11 @@ async function onUpdateClick() {
         return;
     }
 
-    $(this).find('i').addClass('fa-spin');
+    const icon = $(this).find('i');
+    icon.addClass('fa-spin');
     await updateExtension(extensionName, false);
+    // updateExtension eats the error, but we can at least stop the spinner
+    icon.removeClass('fa-spin');
 }
 
 /**
@@ -803,10 +806,17 @@ async function updateExtension(extensionName, quiet) {
             }),
         });
 
+        if (!response.ok) {
+            const text = await response.text();
+            toastr.error(text || response.statusText, t`Extension update failed`, { timeOut: 5000 });
+            console.error('Extension update failed', response.status, response.statusText, text);
+            return;
+        }
+
         const data = await response.json();
 
         if (!quiet) {
-            showExtensionsDetails();
+            await showExtensionsDetails();
         }
 
         if (data.isUpToDate) {