Merge pull request #9080 from lat9nq/sdl-audio-not-null

sdl2_sink: Avoid loading a null string into a vector
2022-10-17 02:56:38 -04:00
parent d574bb4610 4b773b15a6
commit f107e58fde
1 changed files with 3 additions and 1 deletions
--- a/src/audio_core/sink/sdl2_sink.cpp
+++ b/src/audio_core/sink/sdl2_sink.cpp
@@ -230,7 +230,9 @@ std::vector<std::string> ListSDLSinkDevices(bool capture) {

    const int device_count = SDL_GetNumAudioDevices(capture);
    for (int i = 0; i < device_count; ++i) {
-        device_list.emplace_back(SDL_GetAudioDeviceName(i, 0));
+        if (const char* name = SDL_GetAudioDeviceName(i, capture)) {
+            device_list.emplace_back(name);
+        }
    }

    return device_list;