octo
/
yuzu-mainline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

settings: Remove unnecessary std::move usages 

Addresses review feedback.

Co-authored-by: Mai M. <mathew1800@gmail.com>
This commit is contained in:
lat9nq 2021-07-30 16:12:15 -04:00
parent 7737bdfd1a
commit e9cf08c241
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/common/settings.h
View File

@ -170,11 +170,11 @@ public:
void SetValue(const Type& value) override {
Type temp;
if (value < minimum) {
temp = std::move(minimum);
temp = minimum;
} else if (value > maximum) {
temp = std::move(maximum);
temp = maximum;
} else {
temp = std::move(value);
temp = value;
}
std::swap(this->global, temp);
}
@ -188,11 +188,11 @@ public:
const Type& operator=(const Type& value) override {
Type temp;
if (value < minimum) {
temp = std::move(minimum);
temp = minimum;
} else if (value > maximum) {
temp = std::move(maximum);
temp = maximum;
} else {
temp = std::move(value);
temp = value;
}
std::swap(this->global, temp);
return this->global;
@ -344,11 +344,11 @@ public:
void SetValue(const Type& value) override {
Type temp;
if (value < this->minimum) {
temp = std::move(this->minimum);
temp = this->minimum;
} else if (value > this->maximum) {
temp = std::move(this->maximum);
temp = this->maximum;
} else {
temp = std::move(value);
temp = value;
}
if (this->use_global) {
std::swap(this->global, temp);
@ -367,11 +367,11 @@ public:
const Type& operator=(const Type& value) override {
Type temp;
if (value < this->minimum) {
temp = std::move(this->minimum);
temp = this->minimum;
} else if (value > this->maximum) {
temp = std::move(this->maximum);
temp = this->maximum;
} else {
temp = std::move(value);
temp = value;
}
if (this->use_global) {
std::swap(this->global, temp);