mii_types: Remove null terminator check
This is an OoB array access, causing a crash on at least the Linux Flatpak releases. Co-authored-by: german77 <juangerman-13@hotmail.com>
This commit is contained in:
		| @@ -606,15 +606,12 @@ struct Nickname { | ||||
|     static constexpr std::size_t MaxNameSize = 10; | ||||
|     std::array<char16_t, MaxNameSize> data; | ||||
|  | ||||
|     // Checks for null, non-zero terminated or dirty strings | ||||
|     // Checks for null or dirty strings | ||||
|     bool IsValid() const { | ||||
|         if (data[0] == 0) { | ||||
|             return false; | ||||
|         } | ||||
|  | ||||
|         if (data[MaxNameSize] != 0) { | ||||
|             return false; | ||||
|         } | ||||
|         std::size_t index = 1; | ||||
|         while (data[index] != 0) { | ||||
|             index++; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user