ipc_helpers: Only allow trivially copyable objects with PushRaw() and PopRaw()
It's undefined behavior to use non-trivially copyable objects with std::memcpy, so we can add asserts to catch usages of these at compile-time.
This commit is contained in:
		@@ -229,6 +229,8 @@ inline void ResponseBuilder::Push(u32 value) {
 | 
			
		||||
 | 
			
		||||
template <typename T>
 | 
			
		||||
void ResponseBuilder::PushRaw(const T& value) {
 | 
			
		||||
    static_assert(std::is_trivially_copyable_v<T>,
 | 
			
		||||
                  "It's undefined behavior to use memcpy with non-trivially copyable objects");
 | 
			
		||||
    std::memcpy(cmdbuf + index, &value, sizeof(T));
 | 
			
		||||
    index += (sizeof(T) + 3) / 4; // round up to word length
 | 
			
		||||
}
 | 
			
		||||
@@ -384,6 +386,8 @@ inline s32 RequestParser::Pop() {
 | 
			
		||||
 | 
			
		||||
template <typename T>
 | 
			
		||||
void RequestParser::PopRaw(T& value) {
 | 
			
		||||
    static_assert(std::is_trivially_copyable_v<T>,
 | 
			
		||||
                  "It's undefined behavior to use memcpy with non-trivially copyable objects");
 | 
			
		||||
    std::memcpy(&value, cmdbuf + index, sizeof(T));
 | 
			
		||||
    index += (sizeof(T) + 3) / 4; // round up to word length
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user