mirror of https://github.com/tooot-app/app
Fix `Image.getSize` in `useEffect` cleanup
This commit is contained in:
parent
f990ff0cb1
commit
f192939671
|
@ -20,30 +20,41 @@ const AttachmentImage: React.FC<Props> = ({
|
||||||
}) => {
|
}) => {
|
||||||
layoutAnimation()
|
layoutAnimation()
|
||||||
|
|
||||||
|
let isMounted = false
|
||||||
|
useEffect(() => {
|
||||||
|
isMounted = true
|
||||||
|
|
||||||
|
return () => {
|
||||||
|
isMounted = false
|
||||||
|
}
|
||||||
|
})
|
||||||
const [imageVisible, setImageVisible] = useState<string>()
|
const [imageVisible, setImageVisible] = useState<string>()
|
||||||
const [imageLoadingFailed, setImageLoadingFailed] = useState(false)
|
const [imageLoadingFailed, setImageLoadingFailed] = useState(false)
|
||||||
useEffect(
|
useEffect(() => {
|
||||||
() =>
|
const preFetch = () =>
|
||||||
|
isMounted &&
|
||||||
Image.getSize(
|
Image.getSize(
|
||||||
image.preview_url,
|
image.preview_url,
|
||||||
() => setImageVisible(image.preview_url),
|
() => isMounted && setImageVisible(image.preview_url),
|
||||||
() => {
|
() => {
|
||||||
|
isMounted &&
|
||||||
Image.getSize(
|
Image.getSize(
|
||||||
image.url,
|
image.url,
|
||||||
() => setImageVisible(image.url),
|
() => isMounted && setImageVisible(image.url),
|
||||||
() =>
|
() =>
|
||||||
image.remote_url
|
image.remote_url
|
||||||
? Image.getSize(
|
? isMounted &&
|
||||||
|
Image.getSize(
|
||||||
image.remote_url,
|
image.remote_url,
|
||||||
() => setImageVisible(image.remote_url),
|
() => isMounted && setImageVisible(image.remote_url),
|
||||||
() => setImageLoadingFailed(true)
|
() => isMounted && setImageLoadingFailed(true)
|
||||||
)
|
)
|
||||||
: setImageLoadingFailed(true)
|
: isMounted && setImageLoadingFailed(true)
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
),
|
|
||||||
[]
|
|
||||||
)
|
)
|
||||||
|
preFetch()
|
||||||
|
}, [isMounted])
|
||||||
|
|
||||||
const children = useCallback(() => {
|
const children = useCallback(() => {
|
||||||
if (imageVisible && !sensitiveShown) {
|
if (imageVisible && !sensitiveShown) {
|
||||||
|
|
|
@ -13,11 +13,22 @@ export interface Props {
|
||||||
const TimelineCard: React.FC<Props> = ({ card }) => {
|
const TimelineCard: React.FC<Props> = ({ card }) => {
|
||||||
const { theme } = useTheme()
|
const { theme } = useTheme()
|
||||||
|
|
||||||
|
let isMounted = false
|
||||||
|
useEffect(() => {
|
||||||
|
isMounted = true
|
||||||
|
|
||||||
|
return () => {
|
||||||
|
isMounted = false
|
||||||
|
}
|
||||||
|
})
|
||||||
const [imageLoaded, setImageLoaded] = useState(false)
|
const [imageLoaded, setImageLoaded] = useState(false)
|
||||||
useEffect(
|
useEffect(() => {
|
||||||
() => card.image && Image.getSize(card.image, () => setImageLoaded(true)),
|
const preFetch = () =>
|
||||||
[]
|
card.image &&
|
||||||
)
|
isMounted &&
|
||||||
|
Image.getSize(card.image, () => isMounted && setImageLoaded(true))
|
||||||
|
preFetch()
|
||||||
|
}, [isMounted])
|
||||||
const cardVisual = useMemo(() => {
|
const cardVisual = useMemo(() => {
|
||||||
if (imageLoaded) {
|
if (imageLoaded) {
|
||||||
return <Image source={{ uri: card.image }} style={styles.image} />
|
return <Image source={{ uri: card.image }} style={styles.image} />
|
||||||
|
|
|
@ -17,11 +17,20 @@ const AccountHeader: React.FC<Props> = ({
|
||||||
}) => {
|
}) => {
|
||||||
const [ratio, setRatio] = useState(accountState.headerRatio)
|
const [ratio, setRatio] = useState(accountState.headerRatio)
|
||||||
|
|
||||||
|
let isMounted = false
|
||||||
|
useEffect(() => {
|
||||||
|
isMounted = true
|
||||||
|
|
||||||
|
return () => {
|
||||||
|
isMounted = false
|
||||||
|
}
|
||||||
|
})
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (
|
if (
|
||||||
account?.header &&
|
account?.header &&
|
||||||
!account.header.includes('/headers/original/missing.png')
|
!account.header.includes('/headers/original/missing.png')
|
||||||
) {
|
) {
|
||||||
|
isMounted &&
|
||||||
Image.getSize(account.header, (width, height) => {
|
Image.getSize(account.header, (width, height) => {
|
||||||
if (!limitHeight) {
|
if (!limitHeight) {
|
||||||
accountDispatch &&
|
accountDispatch &&
|
||||||
|
@ -30,10 +39,11 @@ const AccountHeader: React.FC<Props> = ({
|
||||||
payload: height / width
|
payload: height / width
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
isMounted &&
|
||||||
setRatio(limitHeight ? accountState.headerRatio : height / width)
|
setRatio(limitHeight ? accountState.headerRatio : height / width)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}, [account])
|
}, [account, isMounted])
|
||||||
|
|
||||||
const windowWidth = Dimensions.get('window').width
|
const windowWidth = Dimensions.get('window').width
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue