Adam Brown
4bbb637ace
adding documentation around the two notifiable event lists which act as our notification source of truth
2021-10-26 20:03:10 +01:00
Adam Brown
c67b9ee81e
ensuring that we remove read messages when they come through by respecting the processed type when creating the notifications
2021-10-26 20:03:10 +01:00
Adam Brown
0bdc65b47f
diffing the notification events against the currently rendered events allow us to dismiss notifications from removed events
2021-10-26 20:03:10 +01:00
Adam Brown
b27fb264fc
using a process state of keep/removed rather than mapping to an ignored event id
...
- this state will be used to diff the currently rendered events against the new ones
2021-10-26 20:03:10 +01:00
Adam Brown
b7b4c01bde
splitting the event processing from the rendering
...
- this allows us to only synchronise of the event list modifications rather than the entire notification creation/rendering which should in turn reduce some of our ANRs https://github.com/vector-im/element-android/issues/4214
2021-10-26 20:03:10 +01:00
Adam Brown
587466e009
relying on the notification refreshing to cancel/update the notifications
2021-10-26 20:03:10 +01:00
Adam Brown
03fe45da60
ensuring that we removing the summary group before removing individual notifications
...
- adds some comments to explain the positioning
2021-10-26 20:03:10 +01:00
Adam Brown
a94a1a0523
formatting
2021-10-26 20:03:10 +01:00
Adam Brown
8fb6bef503
removing this usages for project convention
2021-10-26 20:03:10 +01:00
Adam Brown
0d316e69de
handling creating the summary when notification events are filtered to empty due to only containing removals
2021-10-26 20:03:10 +01:00
Adam Brown
3d567d0dcd
removing no longer needed hasBeenDisplayed state, the eventList is our source of truth
...
- when events have finished being displayed they should be removed from the eventList via notification delete actions
2021-10-26 20:03:10 +01:00
Adam Brown
c85afa96d3
lifting settings change to cancel all notifications out of the renderer
...
- the renderer's responsibility it handling events
2021-10-26 20:03:10 +01:00
Adam Brown
3023cb4d39
chaining the event process, notification creation and display logic into a NotificationRender
...
- extract the displaying into its own class to avoid leaking the entire notificationutils
- cancel/display notification actions are completely driven by the event or abscense of event from the eventList
- attempts to avoid redundant render passes by checking if the eventList has changed since the last render
2021-10-26 20:03:10 +01:00
Adam Brown
0f4ec65b7a
creating the notifications separate to where they're displayed
...
- also handles when the event diff means the notifications should be removed
2021-10-26 20:03:10 +01:00
Adam Brown
7b0c483134
creating dedicated class for the processing the serialized events
...
- updates the logic to track when events are removed as a way for the notifications to remove themselves, null events mean they've been removed
2021-10-26 20:03:10 +01:00
Adam Brown
4459aab558
making the event body non null and immutable to allow less cases to be handled -
...
also puts in the basis for a separate notification refreshing implementation
2021-10-26 20:03:10 +01:00
Adam Brown
beff5ab821
including the room name in the invitation event if the room sumary is available
2021-10-26 20:03:10 +01:00
Adam Brown
56e2b79774
formatting
2021-10-26 20:03:10 +01:00
Adam Brown
86b500445f
updating the push gateway property to reflect that it mean the event can be replaced
...
- makes the property immutable as only the creation of the event knows if it can be replace eg it came from a push or the /sync event stream
2021-10-26 20:03:10 +01:00
Adam Brown
b44a382893
separating the mutable vars from the immutable ones, they'll be removed or made immutable by the notification redesign
2021-10-26 20:03:10 +01:00
Adam Brown
db5d4ead38
making the noisy property immutable
2021-10-26 20:03:10 +01:00
Adam Brown
c99dd4a615
making the isRedacted event property immutable
...
- also makes the notifiable events sealed interfaces so that we can copy the data classes with new redacted values when it changes
2021-10-26 20:03:10 +01:00
Adam Brown
89d643a4be
removing unused property (written to but never read)
2021-10-26 20:03:10 +01:00
Adam Brown
81da185d8b
making non overriden properties immutable by passing the values intro the constructor
2021-10-26 20:03:10 +01:00
Adam Brown
51f7dee952
removing non common properties form the base event
2021-10-26 20:03:10 +01:00
Adam Brown
67211605aa
removing unused commented code
2021-10-26 20:03:10 +01:00
Adam Brown
0c809b5ed1
now that we ignore duplicated invite joined events at the source we can avoid eager notification cancels and rely on the main notification refresh flow
2021-10-26 20:03:10 +01:00
Benoit Marty
a19999a717
Merge pull request #4345 from vector-im/feature/adm/unable-to-join-by-name
...
Unable to join room by name
2021-10-26 19:35:44 +02:00
Benoit Marty
1d8a4a923a
Merge pull request #4344 from vector-im/feature/bma/device_id_param
...
Add optional deviceId to the login API
2021-10-26 19:24:09 +02:00
Adam Brown
272baa52ec
adding remaining activity missing hilt injection annotations
2021-10-26 17:56:22 +01:00
Adam Brown
881157a725
applying the room navigation interceptor to only the room activity navigation, not the bottomsheets
...
- the bottomsheets require the activity to stay around as they host the sheet instance, fixes missing join sheets
2021-10-26 17:15:19 +01:00
Adam Brown
49c969601d
adding missing bottomsheet handling for displaying the join room sheet when linking from the public rooms
...
- the activity is still finished causing the popup to not actually display
2021-10-26 17:14:24 +01:00
Benoit Marty
01a29f67d0
Version++
2021-10-26 17:33:23 +02:00
Benoit Marty
6c485d5f6e
Merge hotfix 1.3.6
2021-10-26 17:23:33 +02:00
Adam Brown
792444d1ac
adding missing hilt annotation for injectable activity
2021-10-26 16:23:32 +01:00
Benoit Marty
0236396c59
Add optional deviceId to the login API
2021-10-26 15:10:04 +02:00
Benoit Marty
3354cd1760
Merge pull request #4312 from vector-im/feature/fga/hilt_app_migration
...
Migrate App DI framework to Hilt
2021-10-25 12:41:02 +02:00
Benoit Marty
79d56319b7
Version++
2021-10-25 12:40:24 +02:00
Benoit Marty
8b6e0187d6
Merge pull request #4320 from vector-im/feature/adm/malformed-group-link
...
Fixing grouped notification causing malformed url
2021-10-25 12:20:04 +02:00
Adam Brown
325e78106e
fixing strange ide extract
2021-10-25 10:51:40 +01:00
Adam Brown
06b3cc3f4b
filters the unique notification uris from the link handling
...
- fixes malformed url errors appearing for uri we only create to force uniqueness in the notifications
2021-10-22 18:29:53 +01:00
ganfra
e1f4e4f934
Hilt: fix test
2021-10-22 18:38:48 +02:00
ganfra
c87d276f8a
Hilt: fix fdroid
2021-10-22 18:09:14 +02:00
ganfra
a82a5c9b32
Fix unread marker not showing #4313
2021-10-22 15:19:39 +02:00
ganfra
e6e8c7f7d1
Hilt: clean code and add changelog
2021-10-22 12:41:06 +02:00
ganfra
e9b58844b3
Merge branch 'develop' into feature/fga/hilt_app_migration
2021-10-22 11:30:49 +02:00
ganfra
b6501ce7b2
Hilt: continue cleaning up
2021-10-22 11:30:09 +02:00
Weblate
f75de0b2b7
Merge branch 'origin/develop' into Weblate.
2021-10-22 08:00:00 +00:00
Jeff Huang
dcda43fc93
Translated using Weblate (Chinese (Traditional))
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/zh_Hant/
2021-10-22 07:59:54 +00:00
sr093906
de320e671e
Translated using Weblate (Chinese (Simplified))
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/zh_Hans/
2021-10-22 07:59:54 +00:00
LinAGKar
5a3d1fb7ec
Translated using Weblate (Swedish)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sv/
2021-10-22 07:59:54 +00:00
lvre
2ddedf49d4
Translated using Weblate (Portuguese (Brazil))
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/pt_BR/
2021-10-22 07:59:54 +00:00
Linerly
df5c05fc1f
Translated using Weblate (Indonesian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/id/
2021-10-22 07:59:53 +00:00
Szimszon
2b0933139a
Translated using Weblate (Hungarian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/hu/
2021-10-22 07:59:53 +00:00
Glandos
3993a45825
Translated using Weblate (French)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fr/
2021-10-22 07:59:53 +00:00
Priit Jõerüüt
b83566c1c0
Translated using Weblate (Estonian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/et/
2021-10-22 07:59:53 +00:00
waclaw66
bc137af0e2
Translated using Weblate (Czech)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/cs/
2021-10-22 07:59:52 +00:00
ganfra
d724504662
Hilt: finish migration of latest view models
2021-10-21 20:17:49 +02:00
ariskotsomitopoulos
9d5f84b86a
Linter fixes
2021-10-21 20:02:21 +03:00
ariskotsomitopoulos
d6d46d1c21
Avoid using setRawInputType
2021-10-21 19:41:35 +03:00
Benoit Marty
a7d5c6a437
Merge pull request #4281 from vector-im/feature/aris/broken_edittext_4276
...
Fix Broken EditText when using FromEditTextItem
2021-10-21 17:28:41 +02:00
Benoit Marty
eb54eef595
Merge pull request #4296 from vector-im/feature/fga/fix_jsonviewer
...
Fix crash when clicking on ViewEvent source actions
2021-10-21 17:24:21 +02:00
ariskotsomitopoulos
beab9ab8f1
Refactored for clarity
2021-10-21 17:43:01 +03:00
ganfra
d41ff50097
Fix crash when clicking on ViewEvent source actions #4279
2021-10-21 16:34:20 +02:00
ariskotsomitopoulos
dc230f1c30
Refactor to handle more cases
2021-10-21 14:31:50 +03:00
ganfra
d33daaf799
Fix voice message record button wrong visibility #4283
2021-10-21 11:35:08 +02:00
ganfra
ac1e4e9e9c
Hilt: remove usage of ScreenComponent
2021-10-21 10:10:59 +02:00
ariskotsomitopoulos
3ea7b37df3
Improve imeOptions
2021-10-21 01:54:45 +03:00
ariskotsomitopoulos
b3f6b5e142
Fix Broken EditText when using FromEditTextItem
2021-10-21 01:46:05 +03:00
ganfra
188b4887ba
Hilt: continue migrating activities
2021-10-20 18:06:57 +02:00
Benoit Marty
7c9c4ecf5f
Version++
2021-10-20 10:49:40 +02:00
Benoit Marty
367795ee24
Fix crash reported by the PlayStore, for release 1.3.4
...
I did not find a way to reproduce, but this change should add some safety
2021-10-20 09:29:15 +02:00
Benoit Marty
628ccdc328
Add English - GB to the list of languages
2021-10-20 09:16:56 +02:00
Weblate
cf5fca082d
Merge branch 'origin/develop' into Weblate.
2021-10-20 06:28:17 +00:00
Kiel
c7fa40fd46
Translated using Weblate (English (United Kingdom))
...
Currently translated at 0.7% (21 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/en_GB/
2021-10-20 06:28:08 +00:00
DUCKCHI
d764bb659f
Translated using Weblate (Korean)
...
Currently translated at 48.3% (1292 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ko/
2021-10-20 06:28:06 +00:00
Benoit Marty
85983562fa
No need to add explicit dependencies on stdlib, this is added by the gradle plugin since 1.4
...
https://kotlinlang.org/docs/whatsnew14.html#dependency-on-the-standard-library-added-by-default
2021-10-19 19:06:27 +02:00
ganfra
92cd79c550
Hilt: migrate activities
2021-10-19 18:53:17 +02:00
ganfra
bb68e735f7
Hilt: continue migration VM
2021-10-19 17:31:56 +02:00
Jeff Huang
497d053c5d
Translated using Weblate (Chinese (Traditional))
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/zh_Hant/
2021-10-19 15:25:39 +00:00
LinAGKar
803d145892
Translated using Weblate (Swedish)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sv/
2021-10-19 15:25:39 +00:00
Viacheslav Raskulin
bda95fcc5e
Translated using Weblate (Russian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ru/
2021-10-19 15:25:39 +00:00
random
5cb55cb0d3
Translated using Weblate (Italian)
...
Currently translated at 99.8% (2669 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/it/
2021-10-19 15:25:38 +00:00
Linerly
61c64a872d
Translated using Weblate (Indonesian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/id/
2021-10-19 15:25:38 +00:00
Benoit Marty
4626199761
Slash commands: popDraft() only in case of success, and display a loading dialog during processing
2021-10-19 13:56:38 +02:00
Benoit Marty
364654b685
Fix crash on slash commands Exceptions
2021-10-19 12:33:47 +02:00
Benoit Marty
fe2ba28441
Implement /part command, with or without parameter
2021-10-19 11:55:09 +02:00
Benoit Marty
f5eaf2f05f
Align wording with Element Web
2021-10-19 11:35:49 +02:00
ganfra
1d73077184
Hilt: continue migration VM
2021-10-18 18:54:30 +02:00
Benoit Marty
2a47acc68a
Merge pull request #4236 from vector-im/feature/adm/fixing-home-menu-options
...
Fixing developer sync options always displaying
2021-10-18 18:19:20 +02:00
sr093906
be874d9927
Translated using Weblate (Chinese (Simplified))
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/zh_Hans/
2021-10-18 01:25:44 +00:00
LinAGKar
68591f3ddd
Translated using Weblate (Swedish)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sv/
2021-10-18 01:25:43 +00:00
joshua
b83a96e1c1
Translated using Weblate (Swedish)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sv/
2021-10-18 01:25:43 +00:00
Besnik Bleta
41167cdc23
Translated using Weblate (Albanian)
...
Currently translated at 99.3% (2655 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sq/
2021-10-18 01:25:41 +00:00
Nikita Epifanov
9b1b35084c
Translated using Weblate (Russian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ru/
2021-10-18 01:25:41 +00:00
lvre
e425532953
Translated using Weblate (Portuguese (Brazil))
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/pt_BR/
2021-10-18 01:25:40 +00:00
Linerly
1787a8a358
Translated using Weblate (Indonesian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/id/
2021-10-18 01:25:40 +00:00
Szimszon
ab5b907b7d
Translated using Weblate (Hungarian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/hu/
2021-10-18 01:25:40 +00:00
Danial Behzadi
0c80f6b8a5
Translated using Weblate (Persian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fa/
2021-10-18 01:25:39 +00:00
Priit Jõerüüt
ee301bc355
Translated using Weblate (Estonian)
...
Currently translated at 100.0% (2672 of 2672 strings)
Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/et/
2021-10-18 01:25:39 +00:00