filippodb/SchildiChat-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Floatine date: fix possible OOB crash when retrieving models

Browse Source 
Thread: main, Exception: java.lang.ArrayIndexOutOfBoundsException: length=191; index=-1
at java.util.ArrayList.get(ArrayList.java:439)
at java.util.Collections$UnmodifiableList.get(Collections.java:1356)
at com.airbnb.epoxy.EpoxyControllerAdapter.getModelAtPosition(EpoxyControllerAdapter.java:3)
at de.spiritcroc.recyclerview.StickyHeaderItemDecoration.getChildInContact(StickyHeaderItemDecoration.kt:3)
at de.spiritcroc.recyclerview.StickyHeaderItemDecoration.onDrawOver(StickyHeaderItemDecoration.kt:19)

Change-Id: I66fcaf7f4f041707534c3da4f712effec2a2df46
This commit is contained in:
SpiritCroc 2022-05-25 09:58:39 +02:00
parent a2486fccf5
commit 13b4fd9c33
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
vector/src/main/java/de/spiritcroc/recyclerview/StickyHeaderItemDecoration.kt
View File

@ -21,6 +21,7 @@ import com.airbnb.epoxy.EpoxyModel
import com.airbnb.epoxy.EpoxyViewHolder import com.airbnb.epoxy.EpoxyViewHolder
import org.matrix.android.sdk.api.extensions.orFalse import org.matrix.android.sdk.api.extensions.orFalse
import org.matrix.android.sdk.api.extensions.orTrue import org.matrix.android.sdk.api.extensions.orTrue
import org.matrix.android.sdk.api.extensions.tryOrNull
import kotlin.math.abs import kotlin.math.abs
const val FADE_DURATION = 200 const val FADE_DURATION = 200
@ -78,8 +79,8 @@ abstract class StickyHeaderItemDecoration(
val childInContact = getChildInContact(parent, contactPoint, headerPos) val childInContact = getChildInContact(parent, contactPoint, headerPos)
val childBelow = getChildInContact(parent, currentHeader.top, headerPos) val childBelow = getChildInContact(parent, currentHeader.top, headerPos)
val childInContactModel = childInContact?.let { epoxyController.adapter.getModelAtPosition(parent.getChildAdapterPosition(childInContact)) } val childInContactModel = childInContact?.let { tryOrNull { epoxyController.adapter.getModelAtPosition(parent.getChildAdapterPosition(childInContact)) } }
val childBelowModel = childBelow?.let { epoxyController.adapter.getModelAtPosition(parent.getChildAdapterPosition(childBelow)) } val childBelowModel = childBelow?.let { tryOrNull { epoxyController.adapter.getModelAtPosition(parent.getChildAdapterPosition(childBelow)) } }
val shouldBeVisible = if (childInContact != null) { val shouldBeVisible = if (childInContact != null) {
if (isHeader(childInContactModel)) { if (isHeader(childInContactModel)) {
@ -245,15 +246,18 @@ abstract class StickyHeaderItemDecoration(
open fun preventOverlay(model: EpoxyModel<*>?): Boolean = false open fun preventOverlay(model: EpoxyModel<*>?): Boolean = false
@Suppress("UNUSED_PARAMETER")
private fun getChildInContact(parent: RecyclerView, contactPoint: Int, currentHeaderPos: Int): View? { private fun getChildInContact(parent: RecyclerView, contactPoint: Int, currentHeaderPos: Int): View? {
var childInContact: View? = null var childInContact: View? = null
for (i in 0 until parent.childCount) { for (i in 0 until parent.childCount) {
var heightTolerance = 0 //var heightTolerance = 0
val child = parent.getChildAt(i) val child = parent.getChildAt(i)
//measure height tolerance with child if child is another header //measure height tolerance with child if child is another header
// Note: seems to be always 0 for us
/*
if (currentHeaderPos != i) { if (currentHeaderPos != i) {
val isChildHeader = isHeader(epoxyController.adapter.getModelAtPosition(parent.getChildAdapterPosition(child))) val isChildHeader = isHeader(tryOrNull { epoxyController.adapter.getModelAtPosition(parent.getChildAdapterPosition(child)) } )
if (isChildHeader) { if (isChildHeader) {
heightTolerance = mStickyHeaderHeight - child.height heightTolerance = mStickyHeaderHeight - child.height
} }
@ -265,6 +269,8 @@ abstract class StickyHeaderItemDecoration(
} else { } else {
child.bottom child.bottom
} }
*/
val childBottomPosition = child.bottom
if (childBottomPosition > contactPoint) { if (childBottomPosition > contactPoint) {
if (child.top <= contactPoint) { if (child.top <= contactPoint) {