filippodb/SchildiChat-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not fully discard chunks that start with duplicate events

Browse Source 
If we already have some events in a previously linked chunk, that
doesn't mean we have all of them. So we still want to continue
processing later events in that case.

Change-Id: I95e864ad7e786ea71b9facdbbf52c2685b36ee26
This commit is contained in:
SpiritCroc 2022-05-24 11:54:21 +02:00
parent d3addc24f1
commit a2486fccf5
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/TokenChunkEventPersistor.kt
View File

@ -232,7 +232,7 @@ internal class TokenChunkEventPersistor @Inject constructor(
val alreadyLinkedNext = currentChunk.doesNextChunksVerifyCondition { it == existingChunk }
val alreadyLinkedPrev = currentChunk.doesPrevChunksVerifyCondition { it == existingChunk }
if (alreadyLinkedNext || alreadyLinkedPrev) {
Timber.w("Avoid double link, shouldn't happen in an ideal world | " +
Timber.i("Avoid double link | " +
"direction: $direction " +
"room: $roomId event: $eventId " +
"linkedPrev: $alreadyLinkedPrev linkedNext: $alreadyLinkedNext " +
@ -240,6 +240,12 @@ internal class TokenChunkEventPersistor @Inject constructor(
"oldBackwardCheck: ${currentChunk.nextChunk == existingChunk} " +
"oldForwardCheck: ${currentChunk.prevChunk == existingChunk}"
)
if ((direction == PaginationDirection.FORWARDS && !alreadyLinkedNext /* && alreadyLinkedPrev */) ||
(direction == PaginationDirection.BACKWARDS && !alreadyLinkedPrev /* && alreadyLinkedNext */)) {
// Do not stop processing here: even though this event already exists in an already linked chunk,
// we still may have new events to add
return@forEach
}
// Stop processing here
return@processTimelineEvents
}