Chromium issues fixed (#52)

core/constants.js

@@ -103,42 +103,42 @@ const BrowserType = {
 const IconType = {
     'Enabled': {
         'Green': {
-            '16': chrome.runtime.getURL('icons/enabled.svg'),
-            '18': chrome.runtime.getURL('icons/enabled.svg'),
-            '19': chrome.runtime.getURL('icons/enabled.svg'),
-            '32': chrome.runtime.getURL('icons/enabled.svg'),
-            '36': chrome.runtime.getURL('icons/enabled.svg'),
-            '38': chrome.runtime.getURL('icons/enabled.svg'),
-            '64': chrome.runtime.getURL('icons/enabled.svg')
+            '16': chrome.runtime.getURL('icons/action/icon16-default.png'),
+            '18': chrome.runtime.getURL('icons/action/icon18-default.png'),
+            '19': chrome.runtime.getURL('icons/action/icon19-default.png'),
+            '32': chrome.runtime.getURL('icons/action/icon32-default.png'),
+            '36': chrome.runtime.getURL('icons/action/icon36-default.png'),
+            '38': chrome.runtime.getURL('icons/action/icon38-default.png'),
+            '64': chrome.runtime.getURL('icons/action/icon64-default.png')
         },
         'White': {
-            '16': chrome.runtime.getURL('icons/enabled-white.svg'),
-            '18': chrome.runtime.getURL('icons/enabled-white.svg'),
-            '19': chrome.runtime.getURL('icons/enabled-white.svg'),
-            '32': chrome.runtime.getURL('icons/enabled-white.svg'),
-            '36': chrome.runtime.getURL('icons/enabled-white.svg'),
-            '38': chrome.runtime.getURL('icons/enabled-white.svg'),
-            '64': chrome.runtime.getURL('icons/enabled-white.svg')
+            '16': chrome.runtime.getURL('icons/action/mono/icon16-default.png'),
+            '18': chrome.runtime.getURL('icons/action/mono/icon18-default.png'),
+            '19': chrome.runtime.getURL('icons/action/mono/icon19-default.png'),
+            '32': chrome.runtime.getURL('icons/action/mono/icon32-default.png'),
+            '36': chrome.runtime.getURL('icons/action/mono/icon36-default.png'),
+            '38': chrome.runtime.getURL('icons/action/mono/icon38-default.png'),
+            '64': chrome.runtime.getURL('icons/action/mono/icon64-default.png')
         }
     },
     'Disabled': {
         'Red': {
-            '16': chrome.runtime.getURL('icons/disabled.svg'),
-            '18': chrome.runtime.getURL('icons/disabled.svg'),
-            '19': chrome.runtime.getURL('icons/disabled.svg'),
-            '32': chrome.runtime.getURL('icons/disabled.svg'),
-            '36': chrome.runtime.getURL('icons/disabled.svg'),
-            '38': chrome.runtime.getURL('icons/disabled.svg'),
-            '64': chrome.runtime.getURL('icons/disabled.svg')
+            '16': chrome.runtime.getURL('icons/action/icon16-disabled.png'),
+            '18': chrome.runtime.getURL('icons/action/icon18-disabled.png'),
+            '19': chrome.runtime.getURL('icons/action/icon19-disabled.png'),
+            '32': chrome.runtime.getURL('icons/action/icon32-disabled.png'),
+            '36': chrome.runtime.getURL('icons/action/icon36-disabled.png'),
+            '38': chrome.runtime.getURL('icons/action/icon38-disabled.png'),
+            '64': chrome.runtime.getURL('icons/action/icon64-disabled.png')
         },
         'White': {
-            '16': chrome.runtime.getURL('icons/disabled-white.svg'),
-            '18': chrome.runtime.getURL('icons/disabled-white.svg'),
-            '19': chrome.runtime.getURL('icons/disabled-white.svg'),
-            '32': chrome.runtime.getURL('icons/disabled-white.svg'),
-            '36': chrome.runtime.getURL('icons/disabled-white.svg'),
-            '38': chrome.runtime.getURL('icons/disabled-white.svg'),
-            '64': chrome.runtime.getURL('icons/disabled-white.svg')
+            '16': chrome.runtime.getURL('icons/action/mono/icon16-disabled.png'),
+            '18': chrome.runtime.getURL('icons/action/mono/icon18-disabled.png'),
+            '19': chrome.runtime.getURL('icons/action/mono/icon19-disabled.png'),
+            '32': chrome.runtime.getURL('icons/action/mono/icon32-disabled.png'),
+            '36': chrome.runtime.getURL('icons/action/mono/icon36-disabled.png'),
+            '38': chrome.runtime.getURL('icons/action/mono/icon38-disabled.png'),
+            '64': chrome.runtime.getURL('icons/action/mono/icon64-disabled.png')
         }
     }
 };

core/state-manager.js

@@ -212,6 +212,9 @@ stateManager._handleStorageChanged = function (changes) {
     if (Setting.NEGATE_HTML_FILTER_LIST in changes) {
         stateManager.getInvertOption = changes.negateHtmlFilterList.newValue;
     }
+    if (Setting.USE_MONOCHROME_ICONS in changes) {
+        stateManager.useMonochromeIcons = changes.useMonochromeIcons.newValue;
+    }
 };
 
 stateManager._clearBadgeText = function (tabIdentifier) {
@@ -249,7 +252,7 @@ stateManager._domainIsListed = function (domain, listname) {
 stateManager._setIconDisabled = function (tabIdentifier) {
 
     wrappers.setIcon({
-        'path': stateManager.useMonochromeIcons ? IconType.Disabled.White : IconType.Disabled.Green,
+        'path': stateManager.useMonochromeIcons ? IconType.Disabled.White : IconType.Disabled.Red,
         'tabId': tabIdentifier
     });
 };
@@ -275,17 +278,13 @@ chrome.tabs.query({}, function (tabs) {
     tabs.forEach(stateManager._createTab);
 });
 
-chrome.storage.sync.get([Setting.SHOW_ICON_BADGE, Setting.USE_MONOCHROME_ICONS], function (items) {
+chrome.storage.sync.get([Setting.SHOW_ICON_BADGE], function (items) {
 
     if (items.showIconBadge === undefined) {
         items.showIconBadge = true;
     }
-    if (items.useMonochromeIcons === undefined) {
-        items.useMonochromeIcons = true;
-    }
 
     stateManager.showIconBadge = items.showIconBadge;
-    stateManager.useMonochromeIcons = items.useMonochromeIcons;
 });
 
 /**

manifest.json

@@ -14,10 +14,10 @@
 
   "description": "__MSG_extensionDescription__",
   "icons": {
-    "16": "icons/enabled.svg",
-    "48": "icons/enabled.svg",
-    "96": "icons/enabled.svg",
-    "128": "icons/enabled.svg"
+    "16": "icons/icon16.png",
+    "48": "icons/icon48.png",
+    "96": "icons/icon96.png",
+    "128": "icons/icon128.png"
   },
 
   "permissions": [
@@ -37,13 +37,13 @@
 
   "browser_action": {
     "default_icon": {
-      "16": "icons/enabled.svg",
-      "18": "icons/enabled.svg",
-      "19": "icons/enabled.svg",
-      "32": "icons/enabled.svg",
-      "36": "icons/enabled.svg",
-      "38": "icons/enabled.svg",
-      "64": "icons/enabled.svg"
+      "16": "icons/action/icon16-default.png",
+      "18": "icons/action/icon18-default.png",
+      "19": "icons/action/icon19-default.png",
+      "32": "icons/action/icon32-default.png",
+      "36": "icons/action/icon36-default.png",
+      "38": "icons/action/icon38-default.png",
+      "64": "icons/action/icon64-default.png"
     },
     "default_popup": "pages/popup/popup.html",
     "browser_style": false