Commit Graph

491 Commits

Author SHA1 Message Date
Fraunhofer IIS FDK c371e86ef4 QMF configuration flag QMF_FLAG_MPSLDFB has always priority over QMF_FLAG_CLDFB
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I7c851b9db88c6250b5ad30282b8b19ea306e4e12
2018-12-28 19:53:08 -05:00
Fraunhofer IIS FDK b07509996a Add missing parameter initialization in FDK_QmfDomain_Clear*() functions
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: Id5bd382ca256488c837b63eaf519b93e01abe02d
2018-12-28 19:46:31 -05:00
Fraunhofer IIS FDK f4fc574fdd Prevent energy overflow in acelp calc_period_factor()
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I5a28fcb09a1b0b0d1f8861642c64185937021154
2018-12-28 19:42:49 -05:00
Jean-Michel Trivi b622299482 Merge "Add valid bits check to adts header parser" 2018-12-28 23:04:36 +00:00
Jean-Michel Trivi 385764944d Merge "Skip CRC check when flushing or concealment is applied" 2018-12-28 23:04:26 +00:00
Jean-Michel Trivi 83e30f0f7b Merge "Fix element list in channel_configuration_14 description" 2018-12-28 23:04:16 +00:00
Jean-Michel Trivi 3e0a7a40c5 Merge "Setup lowdelay SBR LFE element via SBR callback" 2018-12-28 23:04:06 +00:00
Jean-Michel Trivi 58221178cc Merge "Extend PS concealment/error treatment" 2018-12-28 23:03:55 +00:00
Jean-Michel Trivi 6acfe3b799 Merge "Fix potential invalid memory access for concealment in decodeEnvelope()" 2018-12-28 23:03:46 +00:00
Jean-Michel Trivi c19c36cbfc Merge "Reset all noisefloor levels in leanSbrConcealment()" 2018-12-28 23:03:33 +00:00
Fraunhofer IIS FDK 5877c3e959 Add valid bits check to adts header parser
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I72509e3afbc4c7e5a3a6fe877edd4eed832d7204
2018-12-27 17:59:01 -05:00
Fraunhofer IIS FDK 0ca9742ad2 Skip CRC check when flushing or concealment is applied
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I0f340eb0fe7f5ee8778a73fbe27199ba4915de70
2018-12-27 17:55:50 -05:00
Fraunhofer IIS FDK b8467f6d32 Fix element list in channel_configuration_14 description
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I3d14ba2ed2af0eedc2bba5bc9248fe3dd1367a22
2018-12-27 17:52:10 -05:00
Fraunhofer IIS FDK 3cc09916b0 Setup lowdelay SBR LFE element via SBR callback
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I76ed994be312b6e718591db129e84b6be8ab214d
2018-12-27 17:34:06 -05:00
Fraunhofer IIS FDK 55d2c9582a Extend PS concealment/error treatment
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I19b87d33b1d0ed8b43b4ea57992f1c6df500d9f4
2018-12-27 17:31:46 -05:00
Fraunhofer IIS FDK 82383e3212 Fix potential invalid memory access for concealment in decodeEnvelope()
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I916a24c000ef792aa3d5befa02a6b6f673161844
2018-12-27 17:28:39 -05:00
Fraunhofer IIS FDK 5cb1030d72 Reset all noisefloor levels in leanSbrConcealment()
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I6d25e8c8844bdf8e15d1aab695cb5d19d6b232e2
2018-12-27 17:25:13 -05:00
Jean-Michel Trivi ecc96969d7 Merge changes I97471c4d,I8a8626a8,I1f176740,I10da23ee,I9f9064fb
* changes:
  Apply sbrDecoder_Parse() function for all explict SBR elements
  Call QMF transposer initialization only with successful SBR processing
  Add error path to generateFixFixOnly()
  Add missing break in order to avoid a fallthrough in setConcealMethod()
  Add FDK_FALLTHROUGH macro to prevent implicit-fallthrough compiler warnings
2018-12-27 22:18:54 +00:00
Fraunhofer IIS FDK 0cebd077b6 Apply sbrDecoder_Parse() function for all explict SBR elements
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I97471c4db309307a21100f1d5d88d3c4e24d2670
2018-12-27 14:51:52 -05:00
Fraunhofer IIS FDK 0271d6a6f3 Call QMF transposer initialization only with successful SBR processing
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I8a8626a83e1bd87b2c14fad7c90174e4172c01b6
2018-12-27 14:48:15 -05:00
Fraunhofer IIS FDK 804f41ac64 Add error path to generateFixFixOnly()
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I1f1767403068a9eafd7b20edb96669b71b0110fc
2018-12-27 14:45:29 -05:00
Fraunhofer IIS FDK 8f5b1e47d6 Add missing break in order to avoid a fallthrough in setConcealMethod()
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I10da23ee81cfc48d4a67c25006e6fd48ed985c69
2018-12-27 14:39:43 -05:00
Fraunhofer IIS FDK 64134e60b3 Add FDK_FALLTHROUGH macro to prevent implicit-fallthrough compiler warnings
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I9f9064fb63ac40e18f245c00b7375b4874f2925b
2018-12-27 14:17:51 -05:00
Jean-Michel Trivi f828d3e16a Merge "Limit too large shift exponent in apply_inter_tes()" 2018-12-27 19:14:22 +00:00
Jean-Michel Trivi cfc6616048 Merge "Limit too large scale_change exponent used in adjustTimeSlot" 2018-12-27 19:12:49 +00:00
Fraunhofer IIS FDK 29b81acd78 Limit too large shift exponent in apply_inter_tes()
Bug: 112892200
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I74e349ecb796343b475b825ac7d97497560a1e7a
2018-12-27 12:45:31 -05:00
Fraunhofer IIS FDK e93cd75ea4 Limit too large scale_change exponent used in adjustTimeSlot
Bug: 112892953
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I4fe66defb40a36612850582cb0f1da7fb07a8bed
2018-12-27 12:29:27 -05:00
Jean-Michel Trivi 55930c28af Merge "Signed Integer Overflows in imlt_block()" 2018-12-27 17:18:44 +00:00
Fraunhofer IIS FDK fa8a80d890 Signed Integer Overflows in imlt_block()
Bug: 112890242
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I98fda0eea7f7223d76df31776c6723b618e5b581
2018-12-26 21:15:07 -05:00
Jean-Michel Trivi 4899e80a17 Merge "Unsigned Integer Overflow in InitSegmentBitfield()" 2018-12-27 02:10:25 +00:00
Jean-Michel Trivi 2f5612ef84 Merge "Encoder returned an error while explicit flushing" 2018-12-27 02:01:43 +00:00
Jean-Michel Trivi a5cf260931 Merge "Unsigned Integer Overflow in CAacDecoder_PreRollExtensionPayloadParse()" 2018-12-27 01:58:50 +00:00
Jean-Michel Trivi ecdec651da Merge "Improve error robustness in arithmetic decoder" 2018-12-27 01:56:21 +00:00
Jean-Michel Trivi 4053380094 Merge "Prevent overflow in usac filters" 2018-12-27 01:54:49 +00:00
Jean-Michel Trivi 3bb4fe68a6 Merge "Signed Integer Overflow in CLpd_FAC_Acelp2Mdct()" 2018-12-27 01:51:53 +00:00
Jean-Michel Trivi aea2558c50 Merge "Signed Integer Overflow in E_UTIL_preemph()" 2018-12-27 00:57:22 +00:00
Jean-Michel Trivi 27894057af Merge "Fix SATURATE_LEFT_SHIFT_ALT() since it returned 0x80000000 in certain cases" 2018-12-27 00:55:34 +00:00
Fraunhofer IIS FDK 2aa9167aa6 Encoder returned an error while explicit flushing
Bug: 112663571
Test: atest EncoderTest

Change-Id: Ieaaaf2c32786a8344ba912f4587298654d508e67
2018-12-26 19:50:13 -05:00
Fraunhofer IIS FDK 950d8efb1a Unsigned Integer Overflow in InitSegmentBitfield()
Bug: 112662995
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: Ida3b1d49dc35a03a3ff02f6e150cfb55e9e1da11
2018-12-26 19:45:18 -05:00
Fraunhofer IIS FDK 512898b298 Unsigned Integer Overflow in CAacDecoder_PreRollExtensionPayloadParse()
Bug: 112661610
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I96e2c10328fec8fd12f9c752904860b87a72bed2
2018-12-26 19:39:27 -05:00
Fraunhofer IIS FDK 48a4bca8b3 Improve error robustness in arithmetic decoder
Bug: 112663564
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I3025adbf308bf510dc5bdc1d70c58979fb182187
2018-12-26 19:34:16 -05:00
Fraunhofer IIS FDK 8166502969 Prevent overflow in usac filters
Bug: 112663886
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: Ie7af65a1a556afb141ea5272f70bfea11881ac30
2018-12-26 19:19:34 -05:00
Fraunhofer IIS FDK 1450575edf Signed Integer Overflow in CLpd_FAC_Acelp2Mdct()
Bug: 112663384
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I5e41f1455ab35060c136abb7f4945fe9a545633c
2018-12-26 18:42:14 -05:00
Fraunhofer IIS FDK 9edc5864fa Signed Integer Overflow in E_UTIL_preemph()
Bug: 112661356
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: Ibc7120aba3d357bfb8d751d80d99a6e0f51473e4
2018-12-26 18:20:17 -05:00
Fraunhofer IIS FDK edbb4b0a14 Fix SATURATE_LEFT_SHIFT_ALT() since it returned 0x80000000 in certain cases
Bug: 112661911
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I16e522c975ad45ff8d47d4cabe44f1f2bf95b73b
2018-12-26 18:17:27 -05:00
Jean-Michel Trivi f59fd73d44 Merge "UBSAN overflow in FFT" 2018-12-26 22:57:01 +00:00
Jean-Michel Trivi 93e981d1e1 Merge "Unsigned Integer Overflow in transportDec_readHeader()." 2018-12-26 22:54:00 +00:00
Jean-Michel Trivi 7f3b4de053 Merge "Unsigned Integer Overflow in transportDec_AdjustEndOfAccessUnit()." 2018-12-26 22:51:50 +00:00
Fraunhofer IIS FDK bef1b4dd96 UBSAN overflow in FFT
An overflow in the fft was observed for certain configurations. The root cause was in the scaling of the fft input data in dct_IV and dst_IV.
The following patch revises the scaling in dct and removes the unused arm implementation.

Bug: 112661057
Bug: 109936783
Bug: 112022208
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: Idc9c44a9755b8151d5c7d8107696f43ac592413b
2018-12-26 16:09:37 -05:00
Fraunhofer IIS FDK 81933bc6eb Unsigned Integer Overflow in transportDec_readHeader().
Bug: 112662270
Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc
Change-Id: I0beedab38175fc57e5bd9eb5700a3850ef2bebf7
2018-12-26 15:35:51 -05:00