This avoids wraparounds, which can trigger failed asserts with
some inputs. This fixes
https://github.com/mstorsjo/fdk-aac/issues/158.
The implementation of saturated addition loses the contents of the
lowest bit though, thus this change affects the output - but the
change is said to be acceptable.
This matches how it is done in the autotools build. We try not to
rely on the C++ standard library, and this makes sure that this
property is maintained (even if developing with CMake).
CMake builds with -O3 by default, while autotools builds with -O2.
When optimizing in -O3 mode, GCC finds things to warn about with
-Wno-stringop-overflow that it doesn't find in -O2 mode. (This
happens at least with GCC 11, found in Ubuntu 22.04.)
macOS has marked the function vsprintf deprecated; this is used in
FDKsprintf with a number of uses in the codebase, that aren't
entirely trivial to move over to vsnprintf.
am skip reason: Merged-In Icf5305a7da47fb85235f428151f2fed10f4aa2f4 with SHA-1 820482ff3f is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/24181617
Change-Id: Ie65dd3e8b04ce8bd672f6b10d553ca0fe99a3295
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Icf5305a7da47fb85235f428151f2fed10f4aa2f4 with SHA-1 820482ff3f is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/24181617
Change-Id: Ibb561b2cd05103b265e643d3cf0cb02846546f53
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In Icf5305a7da47fb85235f428151f2fed10f4aa2f4 with SHA-1 820482ff3f is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/24181617
Change-Id: I581dd4e3327870449926487ed3d04d22f2c8cbde
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 46c53ba0cb is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497456
Change-Id: If2cffb48fda89f0017b6eaddb83795b9ac5f115d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 173576b2b3 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497460
Change-Id: I1ef9db17b64fdfe40959be64da62b8927ee01fd0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 35a37fd6ed is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497466
Change-Id: Id06d8d88ed513f1b272a169094b6dc29827256a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 cd6f219861 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497640
Change-Id: I38c4a2c0bc276618b25f4bbf63226eac16ee1e85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 2f8c08a4e7 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497642
Change-Id: I4f0db7440205448508ccbf8a1b9d43d94e923372
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 cf141c714f is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497643
Change-Id: I03103999c1ea98a150db50976efa36189ce21675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 46c53ba0cb is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497456
Change-Id: Ib6d49c4d3edccda4187b5628798673959be7928c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 173576b2b3 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497460
Change-Id: I2a728dcdc159d6706146e10cc994749057537acf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 35a37fd6ed is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497466
Change-Id: I8a374f1de63d737e593bed340e33206cd772b050
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 cd6f219861 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497640
Change-Id: I5b2bbabca70d23e506b44a164a155e56631d654e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 2f8c08a4e7 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497642
Change-Id: If9a7fb390307e2a35d3cfc1ecf03e10688e8be5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 46c53ba0cb is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497456
Change-Id: I2bbfbe5fddc0299b9f2ae8f9fa92edba71111e3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 173576b2b3 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497460
Change-Id: Iac0799bec7f8cdb5a15fc32a2c332386fe33aaca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 35a37fd6ed is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497466
Change-Id: Ifa66266d83f38139dc34aab3eb98cb35279e2134
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 cd6f219861 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497640
Change-Id: Ia8dde0a1d83cc4a79097ea633dfc642c7ff405d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
am skip reason: Merged-In I206973e0bb21140865efffd930e39f920f477359 with SHA-1 cf141c714f is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/aac/+/23497643
Change-Id: Ie536c6c901565819d198806feb09846eab532c47
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
