removing the info bubble related setting item

This commit is contained in:
tibbi 2020-03-10 10:46:07 +01:00
parent 61ca19d929
commit b45bc78db3
3 changed files with 3 additions and 52 deletions

View File

@ -35,7 +35,6 @@ class SettingsActivity : SimpleActivity() {
setupAppPasswordProtection()
setupFileDeletionPasswordProtection()
setupKeepLastModified()
setupShowInfoBubble()
setupEnableRootAccess()
updateTextColors(settings_holder)
setupSectionColors()
@ -49,7 +48,7 @@ class SettingsActivity : SimpleActivity() {
private fun setupSectionColors() {
val adjustedPrimaryColor = getAdjustedPrimaryColor()
arrayListOf(visibility_label, file_operations_label, scrolling_label, security_label).forEach {
arrayListOf(visibility_label, file_operations_label, security_label).forEach {
it.setTextColor(adjustedPrimaryColor)
}
}
@ -190,14 +189,6 @@ class SettingsActivity : SimpleActivity() {
}
}
private fun setupShowInfoBubble() {
settings_show_info_bubble.isChecked = config.showInfoBubble
settings_show_info_bubble_holder.setOnClickListener {
settings_show_info_bubble.toggle()
config.showInfoBubble = settings_show_info_bubble.isChecked
}
}
private fun setupEnableRootAccess() {
settings_enable_root_access_holder.beVisibleIf(config.isRootAvailable)
settings_enable_root_access.isChecked = config.enableRootAccess

View File

@ -93,7 +93,7 @@ class ItemsFragment : Fragment(), ItemOperationsListener, Breadcrumbs.Breadcrumb
}
mView.items_fastscroller.updateBubbleColors()
mView.items_fastscroller.allowBubbleDisplay = context!!.config.showInfoBubble
mView.items_fastscroller.allowBubbleDisplay = true
if (!isFirstResume) {
refreshItems()
}
@ -155,7 +155,7 @@ class ItemsFragment : Fragment(), ItemOperationsListener, Breadcrumbs.Breadcrumb
addVerticalDividers(true)
items_list.adapter = this
}
items_fastscroller.allowBubbleDisplay = context.config.showInfoBubble
items_fastscroller.allowBubbleDisplay = true
items_fastscroller.setViews(items_list, mView.items_swipe_refresh) {
items_fastscroller.updateBubbleText(storedItems.getOrNull(it)?.getBubbleText(context) ?: "")
}

View File

@ -212,46 +212,6 @@
</RelativeLayout>
<View
android:id="@+id/scrolling_divider"
android:layout_width="match_parent"
android:layout_height="1px"
android:background="@color/divider_grey"
android:importantForAccessibility="no"/>
<com.simplemobiletools.commons.views.MyTextView
android:id="@+id/scrolling_label"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/bigger_margin"
android:layout_marginTop="@dimen/activity_margin"
android:text="@string/scrolling"
android:textAllCaps="true"
android:textSize="@dimen/smaller_text_size"/>
<RelativeLayout
android:id="@+id/settings_show_info_bubble_holder"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/medium_margin"
android:background="?attr/selectableItemBackground"
android:paddingLeft="@dimen/normal_margin"
android:paddingTop="@dimen/activity_margin"
android:paddingRight="@dimen/normal_margin"
android:paddingBottom="@dimen/activity_margin">
<com.simplemobiletools.commons.views.MySwitchCompat
android:id="@+id/settings_show_info_bubble"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:background="@null"
android:clickable="false"
android:paddingStart="@dimen/medium_margin"
android:text="@string/show_info_bubble"
app:switchPadding="@dimen/medium_margin"/>
</RelativeLayout>
<View
android:id="@+id/security_divider"
android:layout_width="match_parent"