properly fix 'continue this thread' links - no need to req.url checking (ref #82)

This commit is contained in:
teddit 2022-06-27 21:48:40 +02:00
parent 2b22ffa105
commit 07050c9cf6
3 changed files with 8 additions and 16 deletions

View File

@ -1,5 +1,5 @@
module.exports = function() { module.exports = function() {
this.compilePostCommentsHtml = (comments, next_comment, post_id, post_url, morechildren_ids, post_author, viewing_comment, user_preferences, last_known_depth, req_url) => { this.compilePostCommentsHtml = (comments, next_comment, post_id, post_url, morechildren_ids, post_author, viewing_comment, user_preferences, last_known_depth) => {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
(async () => { (async () => {
let comments_html let comments_html
@ -115,9 +115,7 @@ module.exports = function() {
} }
} else { } else {
let link = comments.parent_id.split('_')[1] let link = comments.parent_id.split('_')[1]
if (req_url.slice(-1) === '/') { link = post_url + link
link = '../' + link
}
comments_html = ` comments_html = `
<div class="load-more-comments"> <div class="load-more-comments">
<a href="${link}/#c">continue this thread</a> <a href="${link}/#c">continue this thread</a>
@ -202,7 +200,7 @@ module.exports = function() {
if(comment.replies[j+1]) { if(comment.replies[j+1]) {
next_reply = comment.replies[j+1] next_reply = comment.replies[j+1]
} }
replies_html += await compilePostCommentsHtml(comment.replies[j], next_reply, post_id, post_url, null, post_author, viewing_comment, user_preferences, null, req_url) replies_html += await compilePostCommentsHtml(comment.replies[j], next_reply, post_id, post_url, null, post_author, viewing_comment, user_preferences)
} }
} }
} }
@ -219,9 +217,7 @@ module.exports = function() {
` `
} else { } else {
let link = comment.parent_id.split('_')[1] let link = comment.parent_id.split('_')[1]
if (req_url.slice(-1) === '/') { link = post_url + link
link = '../' + link
}
comments_html = ` comments_html = `
<div class="load-more-comments"> <div class="load-more-comments">
<a href="${link}/#c">continue this thread</a> <a href="${link}/#c">continue this thread</a>

View File

@ -365,8 +365,7 @@ async function finalizeJsonPost(
post_url, post_url,
morechildren_ids, morechildren_ids,
viewing_comment, viewing_comment,
user_preferences, user_preferences
req_url
) { ) {
let comments_html = `<div class="comments">`; let comments_html = `<div class="comments">`;
let comments = processed_json.comments; let comments = processed_json.comments;
@ -389,8 +388,7 @@ async function finalizeJsonPost(
processed_json.author, processed_json.author,
viewing_comment, viewing_comment,
user_preferences, user_preferences,
last_known_depth, last_known_depth
req_url
); );
} }

View File

@ -682,8 +682,7 @@ subredditRoutes.get(
post_url, post_url,
more_comments, more_comments,
viewing_comment, viewing_comment,
req.cookies, req.cookies
req.url
); );
return res.render('post', { return res.render('post', {
post: finalized_json.post_data, post: finalized_json.post_data,
@ -760,8 +759,7 @@ subredditRoutes.get(
post_url, post_url,
more_comments, more_comments,
viewing_comment, viewing_comment,
req.cookies, req.cookies
req.url
); );
return res.render('post', { return res.render('post', {
post: finalized_json.post_data, post: finalized_json.post_data,