Commit Graph

14935 Commits

Author SHA1 Message Date
Jared Snider e4981d64f0
PM-7392 - Add TODO 2024-05-13 14:22:15 -04:00
Jared Snider dd6d3017f7
PM-7392 - Per PR feedback, use a named callback for refreshAccessTokenErrorCallback in CLI 2024-05-13 14:10:36 -04:00
Jared Snider 4ded9e85ac
PM-7392 - Per PR feedback, REFRESH_ACCESS_TOKEN_ERROR_CALLBACK can be completely sync. + Refactor to method in main.background. 2024-05-13 14:09:27 -04:00
Jared Snider d79faadfa8
PM-7392 - Consolidate invalidSecurityStamp error handling 2024-05-13 11:23:09 -04:00
Jared Snider 870e04b9de
PM-7392 - Browser Popup - add comment clarifying expectation of seeing toasts. 2024-05-09 17:14:55 -04:00
Jared Snider 0d385c65c7
PM-7392 - Per feedback, use danger simple dialog type for error. 2024-05-09 17:06:20 -04:00
Jared Snider ff3b0ddfb4
PM-7392 - Main.background.ts - add clarifying comment. 2024-05-09 15:50:16 -04:00
Jared Snider 279ac758ce
PM-7392 - Add optional user id to logout callbacks. 2024-05-09 15:28:42 -04:00
Jared Snider 89d2d5ec4a
PM-7392 - Browser Popup app comp - restore done logging out message functionality + add new default logout message 2024-05-09 15:28:05 -04:00
Jared Snider 775598f448
PM-7392 - Web - app comp - only handle actually possible web logout scenarios. 2024-05-09 15:09:30 -04:00
Jared Snider dceeedd805
PM-7392 - Clean up web app comp 2024-05-09 14:49:59 -04:00
Jared Snider 4451947689
Merge branch 'main' into auth/pm-7392/token-service-add-secure-storage-fallback 2024-05-09 14:33:32 -04:00
SmithThe4th acc4251372
[PM-4577] Enhance passkey user verification to use configured unlock methods (#8746)
* initial commit

* fixed issue with clearing search index state

* clear user index before account is totally cleaned up

* added logout clear on option

* removed redundant clear index from logout

* Implemented user verification logic for the different use cases, added functions to pompt for user to set pin

* added missing await and removed else if conditionals

* fixed no return after user sets pin

* added comment to further explain user verification when user is coming from lock screen

* [PM-7836] UV not properly used when creating an item from [+] or Save passkey as new item (#8993)

* added user verification using the save new login button and + button

* removed commented out code

* [PM-7808][PM-7848] UV Preferred/Required, Item has MP reprompt, user without MP incorrectly bypasses UV and When UV = discouraged, cannot save passkey to item using [+] button (#9015)
2024-05-09 14:18:02 -04:00
Will Martin 9eef1f0953
fix merge error introduced in PM-5017 (#9102) 2024-05-09 13:47:05 -04:00
Jared Snider 52b83fe678
PM-7392 - Update sync service logoutCallback to include optional user id. 2024-05-09 13:32:48 -04:00
Jared Snider d088ec68bc
Merge branch 'auth/pm-7392/token-service-add-secure-storage-fallback' of https://github.com/bitwarden/clients into auth/pm-7392/token-service-add-secure-storage-fallback 2024-05-09 13:31:48 -04:00
Jared Snider 1e6f187960
PM-7392 - Previously, if a security stamp was invalid, the session was marked as expired. Restore that functionality. 2024-05-09 13:31:29 -04:00
Todd Martin a89e148804
[PM-7029] Remove key-rotation-feature-flag (#8816)
* Removed key rotation feature flag.

* Fixed tests

* Removed unused dependency.

* Remove KeyRotationImprovements from default const
2024-05-09 13:24:11 -04:00
Jared Snider 5791be9143
Merge branch 'main' into auth/pm-7392/token-service-add-secure-storage-fallback 2024-05-09 13:11:00 -04:00
Jared Snider c700e05fd5
PM-7392 - Remove logout reason from CLI as each logout call handles messaging on its own. 2024-05-09 12:07:05 -04:00
KiruthigaManivannan ff3b6f52ee
PM-5017 Migrate Organization Plans component (#8448)
* PM-5017 Migrated Organization plans component

* PM-5017 Addressed all the review comments

* PM-5017 Missed a minor change

---------

Co-authored-by: vinith-kovan <156108204+vinith-kovan@users.noreply.github.com>
2024-05-09 21:11:17 +05:30
vinith-kovan 0c2e8c15dc
[PM 5012] migrate adjust subscription component (#8239)
* adjust subscription component migration

* adjust subscription component migration

* adjust subscription component migration
2024-05-09 21:01:00 +05:30
vinith-kovan 30ef66139e
[PM 5007] migrate premium component (#8387)
* premium component migration

* premium component migration

* premium component migration

* premium component migration
2024-05-09 20:46:43 +05:30
KiruthigaManivannan 1180c60e91
Pm 7843 two factor verification is empty on organization duo 2 fa (#9086)
* PM-7843 Two Factor Verification is Empty on Organization duo 2fa

* PM-7843 Addressed review comments

* PM-7843 Bug fixed
2024-05-09 11:12:45 -04:00
Jake Fink c69cc37716
[PM-7747] add timeout to safari sendMessageWithResponse (#9082)
* add timeout to safari sendMessageWithResponse

* change to query views instead of sending message
2024-05-09 10:54:05 -04:00
Daniel James Smith da144410e8
Remove settings from options.component which had been moved to notifications.component (#9093)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-05-09 06:30:43 -04:00
Daniel James Smith 2227fd1190
Rename about.component to about-dialog.component (#9094)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-05-09 06:29:51 -04:00
Jared Snider 0788c354fb
PM-7392 - Fix browser build 2024-05-08 20:25:26 -04:00
Jared Snider 628190bde0
PM-7392 - Desktop App comp - Don't open n simple dialogs. 2024-05-08 20:12:22 -04:00
Jared Snider e75d6022e3
PM-7392 - Desktop App comp - don't show cancel btn on simple dialogs. 2024-05-08 19:54:11 -04:00
Jared Snider 24e31feed5
PM-7392 - Web app comp - fix issue 2024-05-08 19:48:17 -04:00
Jared Snider f731e9ba95
PM-7392 - Desktop App comp - replace toast usage with simple dialog to guarantee users will see the reason for them being logged out. 2024-05-08 19:42:09 -04:00
Jared Snider bcf9099229
PM-7392 - TokenSvc - Replace messageSender with logout callback per PR feedback. 2024-05-08 19:40:38 -04:00
Jared Snider d88766a028
PM-7392 - Revert ToastService changes 2024-05-08 19:23:50 -04:00
Jared Snider 5d85de822b
PM-7392 - Build new handlers for displaying the logout reason for desktop & web. 2024-05-08 17:30:33 -04:00
Jared Snider 6f5439b959
PM-7392 - More expired to logoutReason replacements 2024-05-08 17:29:50 -04:00
Jared Snider 7aae92e78e
PM-7392 - More replacements of expired with logoutReason 2024-05-08 17:25:57 -04:00
Jared Snider 18d84bd429
PM-7392 - Logout callback should simply pass along the LogoutReason instead of handling it - let each client's message listener handle it. 2024-05-08 17:24:18 -04:00
Alex Morask 59c9606df3
Prevent calls to Billing Status endpoint when FF is off (#9032) 2024-05-08 15:38:56 -04:00
Daniel James Smith 37d409578a
[PM-7740] Create notifications settings component (navigational changes) (#8919)
* Move about.component into tools ownership

* Split out account security settings

Move settings.component.ts to auth/popup/settings and rename to account-security.component.ts
Move controls from settings.component.html and create account-security.component.html
Move settings.component.html to tools/popup/settings.component.html
Create settings.component.ts under tools/popup/settings
Fixup module imports and routing
Add new strings to en/message.json

* Move vault-timeout-input.component to auth

* Move await-desktop-dialog.component to auth

* Add transition for account-security

* Create notifications settings component

* Move excluded-domains component over to be owned by team-autofill

* Add notifications entry to settings screen

* Move excluded domains from settings to notifications settings screen

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-05-08 15:04:41 -04:00
rr-bw 7bb8caed42
center secondary content (#9079) 2024-05-08 11:58:21 -07:00
Jake Fink b4257e1c1c
set user key once we detect session key (#9084) 2024-05-08 14:48:49 -04:00
rr-bw a42de41587
[PM-5363] PinService State Providers (#8244)
* move pinKeyEncryptedUserKey

* move pinKeyEncryptedUserKeyEphemeral

* remove comments, move docs

* cleanup

* use UserKeyDefinition

* refactor methods

* add migration

* fix browser dependency

* add tests for migration

* rename to pinService

* move state to PinService

* add PinService dep to CryptoService

* move protectedPin to state provider

* update service deps

* renaming

* move decryptUserKeyWithPin to pinService

* update service injection

* move more methods our of crypto service

* remove CryptoService dep from PinService and update service injection

* remove cryptoService reference

* add method to FakeMasterPasswordService

* fix circular dependency

* fix desktop service injection

* update browser dependencies

* add protectedPin to migrations

* move storePinKey to pinService

* update and clarify documentation

* more jsdoc updates

* update import paths

* refactor isPinLockSet method

* update state definitions

* initialize service before injecting into other services

* initialize service before injecting into other services (bw.ts)

* update clearOn and do additional cleanup

* clarify docs and naming

* assign abstract & private methods, add clarity to decryptAndMigrateOldPinKeyEncryptedMasterKey() method

* derived state (attempt)

* fix typos

* use accountService to get active user email

* use constant userId

* add derived state

* add get and clear for oldPinKeyEncryptedMasterKey

* require userId

* move pinProtected

* add clear methods

* remove pinProtected from account.ts and replace methods

* add methods to create and store pinKeyEncryptedUserKey

* add pinProtected/oldPinKeyEncrypterMasterKey to migration

* update migration tests

* update migration rollback tests

* update to systemService and decryptAndMigrate... method

* remove old test

* increase length of state definition name to meet test requirements

* rename 'TRANSIENT' to 'EPHEMERAL' for consistency

* fix tests for login strategies, vault-export, and fake MP service

* more updates to login-strategy tests

* write new tests for core pinKeyEncrypterUserKey methods and isPinSet

* write new tests for pinProtected and oldPinKeyEncryptedMasterKey methods

* minor test reformatting

* update test for decryptUserKeyWithPin()

* fix bug with oldPinKeyEncryptedMasterKey

* fix tests for vault-timeout-settings.service

* fix bitwarden-password-protected-importer test

* fix login strategy tests and auth-request.service test

* update pinService tests

* fix crypto service tests

* add jsdoc

* fix test file import

* update jsdocs for decryptAndMigrateOldPinKeyEncryptedMasterKey()

* update error messages and jsdocs

* add null checks, move userId retrievals

* update migration tests

* update stateService calls to require userId

* update test for decryptUserKeyWithPin()

* update oldPinKeyEncryptedMasterKey migration tests

* more test updates

* fix factory import

* update tests for isPinSet() and createProtectedPin()

* add test for makePinKey()

* add test for createPinKeyEncryptedUserKey()

* add tests for getPinLockType()

* consolidate userId verification tests

* add tests for storePinKeyEncryptedUserKey()

* fix service dep

* get email based on userId

* use MasterPasswordService instead of internal

* rename protectedPin to userKeyEncryptedPin

* rename to pinKeyEncryptedUserKeyPersistent

* update method params

* fix CryptoService tests

* jsdoc update

* use EncString for userKeyEncryptedPin

* remove comment

* use cryptoFunctionService.compareFast()

* update tests

* cleanup, remove comments

* resolve merge conflict

* fix DI of MasterPasswordService

* more DI fixes
2024-05-08 11:34:47 -07:00
Daniel James Smith c2812fc21d
[PM-7176] Create appearance settings component (navigational changes) (#8911)
* Move about.component into tools ownership

* Split out account security settings

Move settings.component.ts to auth/popup/settings and rename to account-security.component.ts
Move controls from settings.component.html and create account-security.component.html
Move settings.component.html to tools/popup/settings.component.html
Create settings.component.ts under tools/popup/settings
Fixup module imports and routing
Add new strings to en/message.json

* Move vault-timeout-input.component to auth

* Move await-desktop-dialog.component to auth

* Add transition for account-security

* Create appearance settings component

* Add entry in settings to navigate to the appearance settings page

* Add transition animation for settings to appearance and back

* Remove settings from options that are now under appearance

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2024-05-08 19:25:24 +02:00
Timshel 350ad890de
Check MasterPassword in web app during change (#8293) 2024-05-08 09:24:18 -07:00
Matt Gibson 7d5575882e
Allow selecting of version numbers for copy-pasting in issues (#9078)
* Allow selecting of version numbers for copy-pasting in issues

* Simplify user-select override

Expands selectable area to labels of versions
2024-05-08 11:34:07 -04:00
Jason Ng 6c05aacbba
[PM-6822] Create new Vault V2 component for extension refresh (#9065)
* created v2 component. added it to app routing
2024-05-08 10:18:19 -04:00
Alex Morask 5097a67b28
Change close to cancel (#9062) 2024-05-08 09:36:42 -04:00
Jared Snider 706935098b
PM-7392 - WIP - Enhancing logout callback to consider the logout reason + move show toast logic into logout callback 2024-05-07 20:37:39 -04:00
Jared Snider d0782554f2
Merge branch 'main' into auth/pm-7392/token-service-add-secure-storage-fallback 2024-05-07 19:44:16 -04:00