Update with linter suggestions (#1199)

This commit is contained in:
Vince Grassia 2021-12-17 12:26:26 -05:00 committed by GitHub
parent 3ad71103dd
commit b33d37e610
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 13 deletions

View File

@ -116,8 +116,7 @@ jobs:
sudo apt-get -y install pkg-config libxss-dev libsecret-1-dev rpm sudo apt-get -y install pkg-config libxss-dev libsecret-1-dev rpm
- name: Set up Snap - name: Set up Snap
run: | run: sudo snap install snapcraft --classic
sudo snap install snapcraft --classic
- name: Print environment - name: Print environment
run: | run: |
@ -214,8 +213,7 @@ jobs:
- name: Set up environment - name: Set up environment
shell: pwsh shell: pwsh
run: | run: choco install checksum --no-progress
choco install checksum --no-progress
- name: Print environment - name: Print environment
run: | run: |
@ -656,8 +654,7 @@ jobs:
env: env:
APPLE_ID_USERNAME: ${{ secrets.APPLE_ID_USERNAME }} APPLE_ID_USERNAME: ${{ secrets.APPLE_ID_USERNAME }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
run: | run: npm run pack:mac
npm run pack:mac
- name: Upload .zip artifact - name: Upload .zip artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700 # v2.2.3 uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700 # v2.2.3
@ -840,8 +837,7 @@ jobs:
run: ./scripts/safari-build.ps1 -mas -copyonly run: ./scripts/safari-build.ps1 -mas -copyonly
- name: Build application for App Store - name: Build application for App Store
run: | run: npm run pack:mac:mas
npm run pack:mac:mas
env: env:
APPLE_ID_USERNAME: ${{ secrets.APPLE_ID_USERNAME }} APPLE_ID_USERNAME: ${{ secrets.APPLE_ID_USERNAME }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
@ -1019,16 +1015,14 @@ jobs:
run: ./scripts/safari-build.ps1 -masdev -copyonly run: ./scripts/safari-build.ps1 -masdev -copyonly
- name: Build dev application for App Store - name: Build dev application for App Store
run: | run: npm run pack:mac:masdev
npm run pack:mac:masdev
env: env:
APPLE_ID_USERNAME: ${{ secrets.APPLE_ID_USERNAME }} APPLE_ID_USERNAME: ${{ secrets.APPLE_ID_USERNAME }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
- name: Zip masdev asset - name: Zip masdev asset
working-directory: ./dist/mas-dev-universal working-directory: ./dist/mas-dev-universal
run: | run: zip -r Bitwarden-${{ env.PACKAGE_VERSION }}-masdev-universal.zip Bitwarden.app
zip -r Bitwarden-${{ env.PACKAGE_VERSION }}-masdev-universal.zip Bitwarden.app
- name: Upload masdev artifact - name: Upload masdev artifact
uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700 # v2.2.3 uses: actions/upload-artifact@ee69f02b3dfdecd58bb31b4d133da38ba6fe3700 # v2.2.3

View File

@ -60,6 +60,6 @@ jobs:
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps) - [ ] Build/deploy pipeline (DevOps)
- [X] Other - [X] Other
## Objective ## Objective
Automated version bump to ${{ github.event.inputs.version_number }}" Automated version bump to ${{ github.event.inputs.version_number }}"