devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

dontShowCards and dontShowIdentities values are not inverted during migration to the new state (#8391)

This commit is contained in:
SmithThe4th 2024-03-20 10:08:06 -04:00 committed by GitHub
parent 93d05c6832
commit 72402852bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.spec.ts
View File

@ -87,12 +87,12 @@ describe("VaultSettingsKeyMigrator", () => {
expect(helper.setToUser).toHaveBeenCalledWith( expect(helper.setToUser).toHaveBeenCalledWith(
"user-1", "user-1",
{ ...vaultSettingsStateDefinition, key: "showCardsCurrentTab" }, { ...vaultSettingsStateDefinition, key: "showCardsCurrentTab" },
true, false,
); );
expect(helper.setToUser).toHaveBeenCalledWith( expect(helper.setToUser).toHaveBeenCalledWith(
"user-1", "user-1",
{ ...vaultSettingsStateDefinition, key: "showIdentitiesCurrentTab" }, { ...vaultSettingsStateDefinition, key: "showIdentitiesCurrentTab" },
true, false,
); );
}); });
}); });

4
libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.ts
View File

@ -30,7 +30,7 @@ export class VaultSettingsKeyMigrator extends Migrator<35, 36> {
await helper.setToUser( await helper.setToUser(
userId, userId,
{ ...vaultSettingsStateDefinition, key: "showCardsCurrentTab" }, { ...vaultSettingsStateDefinition, key: "showCardsCurrentTab" },
accountSettings.dontShowCardsCurrentTab, !accountSettings.dontShowCardsCurrentTab,
); );
delete account.settings.dontShowCardsCurrentTab; delete account.settings.dontShowCardsCurrentTab;
updateAccount = true; updateAccount = true;
@ -40,7 +40,7 @@ export class VaultSettingsKeyMigrator extends Migrator<35, 36> {
await helper.setToUser( await helper.setToUser(
userId, userId,
{ ...vaultSettingsStateDefinition, key: "showIdentitiesCurrentTab" }, { ...vaultSettingsStateDefinition, key: "showIdentitiesCurrentTab" },
accountSettings.dontShowIdentitiesCurrentTab, !accountSettings.dontShowIdentitiesCurrentTab,
); );
delete account.settings.dontShowIdentitiesCurrentTab; delete account.settings.dontShowIdentitiesCurrentTab;
updateAccount = true; updateAccount = true;