From 72402852bb790a0a8272b72b79b462fbcc80806f Mon Sep 17 00:00:00 2001
From: SmithThe4th <gsmith@bitwarden.com>
Date: Wed, 20 Mar 2024 10:08:06 -0400
Subject: [PATCH] dontShowCards and dontShowIdentities values are not inverted
 during migration to the new state (#8391)

---
 .../36-move-show-card-and-identity-to-state-provider.spec.ts  | 4 ++--
 .../36-move-show-card-and-identity-to-state-provider.ts       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.spec.ts b/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.spec.ts
index 64a7fd8efa..499ceae5fa 100644
--- a/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.spec.ts
+++ b/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.spec.ts
@@ -87,12 +87,12 @@ describe("VaultSettingsKeyMigrator", () => {
       expect(helper.setToUser).toHaveBeenCalledWith(
         "user-1",
         { ...vaultSettingsStateDefinition, key: "showCardsCurrentTab" },
-        true,
+        false,
       );
       expect(helper.setToUser).toHaveBeenCalledWith(
         "user-1",
         { ...vaultSettingsStateDefinition, key: "showIdentitiesCurrentTab" },
-        true,
+        false,
       );
     });
   });
diff --git a/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.ts b/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.ts
index 572e074cf1..8e86507a3b 100644
--- a/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.ts
+++ b/libs/common/src/state-migrations/migrations/36-move-show-card-and-identity-to-state-provider.ts
@@ -30,7 +30,7 @@ export class VaultSettingsKeyMigrator extends Migrator<35, 36> {
         await helper.setToUser(
           userId,
           { ...vaultSettingsStateDefinition, key: "showCardsCurrentTab" },
-          accountSettings.dontShowCardsCurrentTab,
+          !accountSettings.dontShowCardsCurrentTab,
         );
         delete account.settings.dontShowCardsCurrentTab;
         updateAccount = true;
@@ -40,7 +40,7 @@ export class VaultSettingsKeyMigrator extends Migrator<35, 36> {
         await helper.setToUser(
           userId,
           { ...vaultSettingsStateDefinition, key: "showIdentitiesCurrentTab" },
-          accountSettings.dontShowIdentitiesCurrentTab,
+          !accountSettings.dontShowIdentitiesCurrentTab,
         );
         delete account.settings.dontShowIdentitiesCurrentTab;
         updateAccount = true;