devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

[PM-8833] Reworking how we handle identifying current password fields within an update form

This commit is contained in:
Cesar Gonzalez 2024-10-01 11:50:16 -05:00
parent 9d3c166f1a
commit 5db1349716
No known key found for this signature in database
GPG Key ID: 3381A5457F8CCECF
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
View File

@ -146,8 +146,7 @@ export class InlineMenuFieldQualificationService
return this.isFieldForLoginFormFallback(field); return this.isFieldForLoginFormFallback(field);
} }
const isTotpField = this.isTotpField(field); if (this.isTotpField(field)) {
if (isTotpField) {
return false; return false;
} }
@ -230,7 +229,10 @@ export class InlineMenuFieldQualificationService
* @param pageDetails - The details of the page that the field is on. * @param pageDetails - The details of the page that the field is on.
*/ */
isFieldForAccountCreationForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean { isFieldForAccountCreationForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean {
if (this.isExcludedFieldType(field, this.excludedAutofillFieldTypesSet)) { if (
this.isExcludedFieldType(field, this.excludedAutofillFieldTypesSet) ||
this.isTotpField(field)
) {
return false; return false;
} }