From 5db1349716195368b17f14cb86448880754d6fc6 Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Tue, 1 Oct 2024 11:50:16 -0500 Subject: [PATCH] [PM-8833] Reworking how we handle identifying current password fields within an update form --- .../services/inline-menu-field-qualification.service.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts b/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts index 129b58fff1..c24c781194 100644 --- a/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts +++ b/apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts @@ -146,8 +146,7 @@ export class InlineMenuFieldQualificationService return this.isFieldForLoginFormFallback(field); } - const isTotpField = this.isTotpField(field); - if (isTotpField) { + if (this.isTotpField(field)) { return false; } @@ -230,7 +229,10 @@ export class InlineMenuFieldQualificationService * @param pageDetails - The details of the page that the field is on. */ isFieldForAccountCreationForm(field: AutofillField, pageDetails: AutofillPageDetails): boolean { - if (this.isExcludedFieldType(field, this.excludedAutofillFieldTypesSet)) { + if ( + this.isExcludedFieldType(field, this.excludedAutofillFieldTypesSet) || + this.isTotpField(field) + ) { return false; }