Merge pull request #1339 from bitwarden/fix/safari-app-crash-2

Fix completion handler nil crashes SFSafariWindow
2020-07-22 18:34:57 -04:00 · 2020-07-22 18:34:57 -04:00 · 25f2697dd2
parent f024441b6c 8f032fd03d
commit 25f2697dd2
1 changed files with 3 additions and 1 deletions
--- a/src/safari/safari/SafariExtensionViewController.swift
+++ b/src/safari/safari/SafariExtensionViewController.swift
@ -175,7 +175,9 @@ class SafariExtensionViewController: SFSafariExtensionViewController, WKScriptMe
        } else if command == "createNewTab" {
            if let data = m.data, let url = URL(string: data) {
                SFSafariApplication.getActiveWindow { win in
-                    win?.openTab(with: url, makeActiveIfPossible: true, completionHandler: nil)
+                    win?.openTab(with: url, makeActiveIfPossible: true, completionHandler: { _ in
+                        // Tab opened
+                    })
                }
            }
        } else if command == "reloadExtension" {