From 8f032fd03dc3d41a6ece283a477e074a0f64ac0e Mon Sep 17 00:00:00 2001 From: Chad Scharf <3904944+cscharf@users.noreply.github.com> Date: Wed, 22 Jul 2020 18:12:08 -0400 Subject: [PATCH] Fix completion handler nil crashes SFSafariWindow --- src/safari/safari/SafariExtensionViewController.swift | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/safari/safari/SafariExtensionViewController.swift b/src/safari/safari/SafariExtensionViewController.swift index 93f4465df7..c33716b53a 100644 --- a/src/safari/safari/SafariExtensionViewController.swift +++ b/src/safari/safari/SafariExtensionViewController.swift @@ -175,7 +175,9 @@ class SafariExtensionViewController: SFSafariExtensionViewController, WKScriptMe } else if command == "createNewTab" { if let data = m.data, let url = URL(string: data) { SFSafariApplication.getActiveWindow { win in - win?.openTab(with: url, makeActiveIfPossible: true, completionHandler: nil) + win?.openTab(with: url, makeActiveIfPossible: true, completionHandler: { _ in + // Tab opened + }) } } } else if command == "reloadExtension" {