bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-02-03 20:47:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make the |url| parameter to OnBeforePopup() optional.

Browse Source 
git-svn-id: https://chromiumembedded.googlecode.com/svn/trunk@434 5089003a-bbd8-11dd-ad1f-f1f9622dbc98
This commit is contained in:
Marshall Greenblatt 2011-12-20 22:07:45 +00:00
parent 6b195a8739
commit ec797bafe5
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/cef.h
View File

@ -1142,7 +1142,7 @@ public:
// modify the object that |client| points to. To change the settings for the // modify the object that |client| points to. To change the settings for the
// new window modify the |settings| structure. // new window modify the |settings| structure.
/// ///
/*--cef()--*/ /*--cef(optional_param=url)--*/
virtual bool OnBeforePopup(CefRefPtr<CefBrowser> parentBrowser, virtual bool OnBeforePopup(CefRefPtr<CefBrowser> parentBrowser,
const CefPopupFeatures& popupFeatures, const CefPopupFeatures& popupFeatures,
CefWindowInfo& windowInfo, CefWindowInfo& windowInfo,

5
libcef_dll/cpptoc/life_span_handler_cpptoc.cc
View File

@ -40,10 +40,6 @@ int CEF_CALLBACK life_span_handler_on_before_popup(
DCHECK(windowInfo); DCHECK(windowInfo);
if (!windowInfo) if (!windowInfo)
return 0; return 0;
// Verify param: url; type: string_byref_const
DCHECK(url);
if (!url)
return 0;
// Verify param: client; type: refptr_same_byref // Verify param: client; type: refptr_same_byref
DCHECK(client); DCHECK(client);
if (!client) if (!client)
@ -52,6 +48,7 @@ int CEF_CALLBACK life_span_handler_on_before_popup(
DCHECK(settings); DCHECK(settings);
if (!settings) if (!settings)
return 0; return 0;
// Unverified params: url
// Translate param: popupFeatures; type: struct_byref_const // Translate param: popupFeatures; type: struct_byref_const
CefPopupFeatures popupFeaturesObj; CefPopupFeatures popupFeaturesObj;

5
libcef_dll/ctocpp/life_span_handler_ctocpp.cc
View File

@ -31,10 +31,7 @@ bool CefLifeSpanHandlerCToCpp::OnBeforePopup(
DCHECK(parentBrowser.get()); DCHECK(parentBrowser.get());
if (!parentBrowser.get()) if (!parentBrowser.get())
return false; return false;
// Verify param: url; type: string_byref_const // Unverified params: url
DCHECK(!url.empty());
if (url.empty())
return false;
// Translate param: client; type: refptr_same_byref // Translate param: client; type: refptr_same_byref
cef_client_t* clientStruct = NULL; cef_client_t* clientStruct = NULL;