diff --git a/include/cef.h b/include/cef.h index 6d2d947f6..a3a24bafe 100644 --- a/include/cef.h +++ b/include/cef.h @@ -1142,7 +1142,7 @@ public: // modify the object that |client| points to. To change the settings for the // new window modify the |settings| structure. /// - /*--cef()--*/ + /*--cef(optional_param=url)--*/ virtual bool OnBeforePopup(CefRefPtr parentBrowser, const CefPopupFeatures& popupFeatures, CefWindowInfo& windowInfo, diff --git a/libcef_dll/cpptoc/life_span_handler_cpptoc.cc b/libcef_dll/cpptoc/life_span_handler_cpptoc.cc index 4d52e3796..ea2a6a8b0 100644 --- a/libcef_dll/cpptoc/life_span_handler_cpptoc.cc +++ b/libcef_dll/cpptoc/life_span_handler_cpptoc.cc @@ -40,10 +40,6 @@ int CEF_CALLBACK life_span_handler_on_before_popup( DCHECK(windowInfo); if (!windowInfo) return 0; - // Verify param: url; type: string_byref_const - DCHECK(url); - if (!url) - return 0; // Verify param: client; type: refptr_same_byref DCHECK(client); if (!client) @@ -52,6 +48,7 @@ int CEF_CALLBACK life_span_handler_on_before_popup( DCHECK(settings); if (!settings) return 0; + // Unverified params: url // Translate param: popupFeatures; type: struct_byref_const CefPopupFeatures popupFeaturesObj; diff --git a/libcef_dll/ctocpp/life_span_handler_ctocpp.cc b/libcef_dll/ctocpp/life_span_handler_ctocpp.cc index 69045f686..7c2812dec 100644 --- a/libcef_dll/ctocpp/life_span_handler_ctocpp.cc +++ b/libcef_dll/ctocpp/life_span_handler_ctocpp.cc @@ -31,10 +31,7 @@ bool CefLifeSpanHandlerCToCpp::OnBeforePopup( DCHECK(parentBrowser.get()); if (!parentBrowser.get()) return false; - // Verify param: url; type: string_byref_const - DCHECK(!url.empty()); - if (url.empty()) - return false; + // Unverified params: url // Translate param: client; type: refptr_same_byref cef_client_t* clientStruct = NULL;