bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Properly disable the notification and push APIs (fixes issue #2951)

Browse Source
This commit is contained in:
Cristian Amarie
2020-07-20 18:16:48 +00:00
committed by Marshall Greenblatt
parent 149ccf946f
commit 7c5e746ea4
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libcef/renderer/content_renderer_client.cc
View File

@@ -261,9 +261,6 @@ void CefContentRendererClient::WebKitInitialized() {
// Create global objects associated with the default Isolate. // Create global objects associated with the default Isolate.
CefV8IsolateCreated(); CefV8IsolateCreated();
// TODO(cef): Enable these once the implementation supports it.
blink::WebRuntimeFeatures::EnableNotifications(false);
const CefContentClient::SchemeInfoList* schemes = const CefContentClient::SchemeInfoList* schemes =
CefContentClient::Get()->GetCustomSchemes(); CefContentClient::Get()->GetCustomSchemes();
if (!schemes->empty()) { if (!schemes->empty()) {
@@ -365,6 +362,13 @@ void CefContentRendererClient::RunSingleProcessCleanup() {
} while (!complete); } while (!complete);
} }
void CefContentRendererClient::PostIOThreadCreated(
base::SingleThreadTaskRunner*) {
// TODO(cef): Enable these once the implementation supports it.
blink::WebRuntimeFeatures::EnableNotifications(false);
blink::WebRuntimeFeatures::EnablePushMessaging(false);
}
void CefContentRendererClient::RenderThreadStarted() { void CefContentRendererClient::RenderThreadStarted() {
const base::CommandLine* command_line = const base::CommandLine* command_line =
base::CommandLine::ForCurrentProcess(); base::CommandLine::ForCurrentProcess();

2
libcef/renderer/content_renderer_client.h
View File

@@ -103,6 +103,8 @@ class CefContentRendererClient
void RunSingleProcessCleanup(); void RunSingleProcessCleanup();
// ContentRendererClient implementation. // ContentRendererClient implementation.
void PostIOThreadCreated(
base::SingleThreadTaskRunner* io_thread_task_runner) override;
void RenderThreadStarted() override; void RenderThreadStarted() override;
void ExposeInterfacesToBrowser(mojo::BinderMap* binders) override; void ExposeInterfacesToBrowser(mojo::BinderMap* binders) override;
void RenderThreadConnected() override; void RenderThreadConnected() override;