From 7c5e746ea49c72f53c812574c9d2ba74b53d92f7 Mon Sep 17 00:00:00 2001
From: Cristian Amarie <camarie@bitdefender.com>
Date: Mon, 20 Jul 2020 18:16:48 +0000
Subject: [PATCH] Properly disable the notification and push APIs (fixes issue
 #2951)

---
 libcef/renderer/content_renderer_client.cc | 10 +++++++---
 libcef/renderer/content_renderer_client.h  |  2 ++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/libcef/renderer/content_renderer_client.cc b/libcef/renderer/content_renderer_client.cc
index 8115e07ba..f7c5dff73 100644
--- a/libcef/renderer/content_renderer_client.cc
+++ b/libcef/renderer/content_renderer_client.cc
@@ -261,9 +261,6 @@ void CefContentRendererClient::WebKitInitialized() {
   // Create global objects associated with the default Isolate.
   CefV8IsolateCreated();
 
-  // TODO(cef): Enable these once the implementation supports it.
-  blink::WebRuntimeFeatures::EnableNotifications(false);
-
   const CefContentClient::SchemeInfoList* schemes =
       CefContentClient::Get()->GetCustomSchemes();
   if (!schemes->empty()) {
@@ -365,6 +362,13 @@ void CefContentRendererClient::RunSingleProcessCleanup() {
   } while (!complete);
 }
 
+void CefContentRendererClient::PostIOThreadCreated(
+  base::SingleThreadTaskRunner*) {
+  // TODO(cef): Enable these once the implementation supports it.
+  blink::WebRuntimeFeatures::EnableNotifications(false);
+  blink::WebRuntimeFeatures::EnablePushMessaging(false);
+}
+
 void CefContentRendererClient::RenderThreadStarted() {
   const base::CommandLine* command_line =
       base::CommandLine::ForCurrentProcess();
diff --git a/libcef/renderer/content_renderer_client.h b/libcef/renderer/content_renderer_client.h
index 19e83d614..3239357f6 100644
--- a/libcef/renderer/content_renderer_client.h
+++ b/libcef/renderer/content_renderer_client.h
@@ -103,6 +103,8 @@ class CefContentRendererClient
   void RunSingleProcessCleanup();
 
   // ContentRendererClient implementation.
+  void PostIOThreadCreated(
+      base::SingleThreadTaskRunner* io_thread_task_runner) override;
   void RenderThreadStarted() override;
   void ExposeInterfacesToBrowser(mojo::BinderMap* binders) override;
   void RenderThreadConnected() override;