bcarrella/cef
1
0
Fork 0
mirror of https://bitbucket.org/chromiumembedded/cef synced 2025-06-05 21:39:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

build: Remove GN arg is_cef_sandbox_build (see #3824)

Browse Source 
This argument is no longer used after removing cef_sandbox patches.
This commit is contained in:
Marshall Greenblatt
2025-05-16 12:35:21 -04:00
parent 992b9d3435
commit 353b6fb138
5 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
BUILD.gn
View File

@ -1223,7 +1223,6 @@ if (is_win) {
configs += [ ":libcef_includes_config" ]
deps = [
":make_config_header",
"libcef/features:buildflags",
"//sandbox",
]
}

1
libcef/features/BUILD.gn
View File

@ -84,7 +84,6 @@ buildflag_header("buildflags") {
flags = [
"ENABLE_CEF=$enable_cef",
"IS_CEF_SANDBOX_BUILD=$is_cef_sandbox_build",
]
}

7
libcef/features/features.gni
View File

@ -5,13 +5,6 @@
declare_args() {
enable_cef = true
# Enables base target customizations necessary for distribution of the
# cef_sandbox static library. This value will be set via gn_args.py for the
# official sandbox build configurations only. DO NOT SET THIS VALUE MANUALLY
# FOR OTHER CHROMIUM/CEF BUILD CONFIGURATIONS AS ITS USE MAY HAVE SIGNIFICANT
# PERFORMANCE AND/OR SECURITY IMPLICATIONS.
is_cef_sandbox_build = false
# Optionally configure the CEF API version. This impacts wrapper-side only.
cef_api_version = ""
}

17
libcef_dll/sandbox/sandbox_win.cc
View File

@ -5,7 +5,6 @@
#include "sandbox/win/src/sandbox.h"
#include "base/notreached.h"
#include "cef/libcef/features/features.h"
#include "include/cef_sandbox_win.h"
#include "sandbox/win/src/sandbox_factory.h"
@ -39,19 +38,3 @@ void* cef_sandbox_info_create() {
void cef_sandbox_info_destroy(void* sandbox_info) {
delete static_cast<sandbox::SandboxInterfaceInfo*>(sandbox_info);
}
#if BUILDFLAG(IS_CEF_SANDBOX_BUILD)
// Avoid bringing in partition_alloc dependencies.
namespace partition_alloc {
bool ReleaseReservation() {
DCHECK(false);
return false;
}
void TerminateBecauseOutOfMemory(size_t size) {
DCHECK(false);
}
} // namespace partition_alloc
#endif // BUILDFLAG(IS_CEF_SANDBOX_BUILD)

4
tools/gn_args.py
View File

@ -544,10 +544,6 @@ def GetConfigArgsSandbox(platform, args, is_debug, cpu):
# generally incompatible with default platform ld/link versions and
# shouldn't be distributed due to the external .o file dependencies.
'use_thin_archives': False,
# Enable base target customizations necessary for distribution of the
# cef_sandbox static library.
'is_cef_sandbox_build': True,
}
if not is_debug: