2014-09-04 19:53:40 +02:00
|
|
|
diff --git desktop_aura/desktop_screen_win.cc desktop_aura/desktop_screen_win.cc
|
|
|
|
index aede179..abad021 100644
|
|
|
|
--- desktop_aura/desktop_screen_win.cc
|
|
|
|
+++ desktop_aura/desktop_screen_win.cc
|
|
|
|
@@ -36,6 +36,8 @@ gfx::Display DesktopScreenWin::GetDisplayMatching(
|
2013-12-07 02:55:22 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
HWND DesktopScreenWin::GetHWNDFromNativeView(gfx::NativeView window) const {
|
|
|
|
+ if (!window)
|
|
|
|
+ return NULL;
|
2014-04-04 18:50:38 +02:00
|
|
|
aura::WindowTreeHost* host = window->GetHost();
|
|
|
|
return host ? host->GetAcceleratedWidget() : NULL;
|
2013-12-07 02:55:22 +01:00
|
|
|
}
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git desktop_aura/desktop_screen_x11.cc desktop_aura/desktop_screen_x11.cc
|
|
|
|
index f4c03da..bb253cf 100644
|
|
|
|
--- desktop_aura/desktop_screen_x11.cc
|
|
|
|
+++ desktop_aura/desktop_screen_x11.cc
|
|
|
|
@@ -157,6 +157,9 @@ std::vector<gfx::Display> DesktopScreenX11::GetAllDisplays() const {
|
2014-07-01 00:30:29 +02:00
|
|
|
|
|
|
|
gfx::Display DesktopScreenX11::GetDisplayNearestWindow(
|
|
|
|
gfx::NativeView window) const {
|
|
|
|
+ if (!window)
|
|
|
|
+ return GetPrimaryDisplay();
|
|
|
|
+
|
|
|
|
// Getting screen bounds here safely is hard.
|
|
|
|
//
|
|
|
|
// You'd think we'd be able to just call window->GetBoundsInScreen(), but we
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git desktop_aura/desktop_window_tree_host_win.cc desktop_aura/desktop_window_tree_host_win.cc
|
2014-10-10 19:54:35 +02:00
|
|
|
index d184ae4..92ffd42 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- desktop_aura/desktop_window_tree_host_win.cc
|
|
|
|
+++ desktop_aura/desktop_window_tree_host_win.cc
|
2014-09-27 01:48:19 +02:00
|
|
|
@@ -131,7 +131,9 @@ void DesktopWindowTreeHostWin::Init(aura::Window* content_window,
|
2014-02-19 17:27:54 +01:00
|
|
|
native_widget_delegate_);
|
|
|
|
|
|
|
|
HWND parent_hwnd = NULL;
|
2014-04-04 18:50:38 +02:00
|
|
|
- if (params.parent && params.parent->GetHost())
|
|
|
|
+ if (params.parent_widget)
|
2014-02-19 17:27:54 +01:00
|
|
|
+ parent_hwnd = params.parent_widget;
|
2014-04-04 18:50:38 +02:00
|
|
|
+ else if (params.parent && params.parent->GetHost())
|
|
|
|
parent_hwnd = params.parent->GetHost()->GetAcceleratedWidget();
|
|
|
|
|
|
|
|
message_handler_->set_remove_standard_frame(params.remove_standard_frame);
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -822,6 +824,7 @@ void DesktopWindowTreeHostWin::HandleFrameChanged() {
|
2014-06-06 21:04:21 +02:00
|
|
|
|
|
|
|
void DesktopWindowTreeHostWin::HandleNativeFocus(HWND last_focused_window) {
|
|
|
|
// TODO(beng): inform the native_widget_delegate_.
|
|
|
|
+ GetWidget()->GetNativeWindow()->Focus();
|
|
|
|
InputMethod* input_method = GetInputMethod();
|
|
|
|
if (input_method)
|
|
|
|
input_method->OnFocus();
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -829,6 +832,7 @@ void DesktopWindowTreeHostWin::HandleNativeFocus(HWND last_focused_window) {
|
2014-06-06 21:04:21 +02:00
|
|
|
|
|
|
|
void DesktopWindowTreeHostWin::HandleNativeBlur(HWND focused_window) {
|
|
|
|
// TODO(beng): inform the native_widget_delegate_.
|
|
|
|
+ GetWidget()->GetNativeWindow()->Blur();
|
|
|
|
InputMethod* input_method = GetInputMethod();
|
|
|
|
if (input_method)
|
|
|
|
input_method->OnBlur();
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git desktop_aura/desktop_window_tree_host_x11.cc desktop_aura/desktop_window_tree_host_x11.cc
|
2014-10-10 19:54:35 +02:00
|
|
|
index 9831992..081a56a0 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- desktop_aura/desktop_window_tree_host_x11.cc
|
|
|
|
+++ desktop_aura/desktop_window_tree_host_x11.cc
|
2014-09-27 01:48:19 +02:00
|
|
|
@@ -147,7 +147,8 @@ DesktopWindowTreeHostX11::DesktopWindowTreeHostX11(
|
2014-05-29 19:15:34 +02:00
|
|
|
window_shape_(NULL),
|
|
|
|
custom_window_shape_(false),
|
2014-10-10 19:54:35 +02:00
|
|
|
urgency_hint_set_(false),
|
|
|
|
- close_widget_factory_(this) {
|
|
|
|
+ close_widget_factory_(this),
|
2014-05-22 23:01:22 +02:00
|
|
|
+ xwindow_destroyed_(false) {
|
|
|
|
}
|
|
|
|
|
|
|
|
DesktopWindowTreeHostX11::~DesktopWindowTreeHostX11() {
|
2014-09-27 01:48:19 +02:00
|
|
|
@@ -350,7 +351,8 @@ void DesktopWindowTreeHostX11::CloseNow() {
|
2014-05-22 23:01:22 +02:00
|
|
|
// Actually free our native resources.
|
|
|
|
if (ui::PlatformEventSource::GetInstance())
|
|
|
|
ui::PlatformEventSource::GetInstance()->RemovePlatformEventDispatcher(this);
|
|
|
|
- XDestroyWindow(xdisplay_, xwindow_);
|
|
|
|
+ if (!xwindow_destroyed_)
|
|
|
|
+ XDestroyWindow(xdisplay_, xwindow_);
|
|
|
|
xwindow_ = None;
|
|
|
|
|
|
|
|
desktop_native_widget_aura_->OnHostClosed();
|
2014-09-27 01:48:19 +02:00
|
|
|
@@ -444,6 +446,8 @@ void DesktopWindowTreeHostX11::GetWindowPlacement(
|
2014-07-09 00:37:06 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
gfx::Rect DesktopWindowTreeHostX11::GetWindowBoundsInScreen() const {
|
|
|
|
+ if (!screen_bounds_.IsEmpty())
|
|
|
|
+ return screen_bounds_;
|
|
|
|
return bounds_;
|
|
|
|
}
|
|
|
|
|
2014-09-27 01:48:19 +02:00
|
|
|
@@ -456,6 +460,8 @@ gfx::Rect DesktopWindowTreeHostX11::GetClientAreaBoundsInScreen() const {
|
2014-07-09 00:37:06 +02:00
|
|
|
// Attempts to calculate the rect by asking the NonClientFrameView what it
|
|
|
|
// thought its GetBoundsForClientView() were broke combobox drop down
|
|
|
|
// placement.
|
|
|
|
+ if (!screen_bounds_.IsEmpty())
|
|
|
|
+ return screen_bounds_;
|
|
|
|
return bounds_;
|
|
|
|
}
|
|
|
|
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -933,6 +939,8 @@ void DesktopWindowTreeHostX11::SetBounds(const gfx::Rect& requested_bounds) {
|
2014-07-09 00:37:06 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
gfx::Point DesktopWindowTreeHostX11::GetLocationOnNativeScreen() const {
|
|
|
|
+ if (!screen_bounds_.IsEmpty())
|
|
|
|
+ return screen_bounds_.origin();
|
|
|
|
return bounds_.origin();
|
|
|
|
}
|
|
|
|
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -1085,10 +1093,14 @@ void DesktopWindowTreeHostX11::InitX11Window(
|
2014-05-29 19:15:34 +02:00
|
|
|
}
|
|
|
|
}
|
2014-05-22 23:01:22 +02:00
|
|
|
|
|
|
|
+ gfx::AcceleratedWidget parent_widget = params.parent_widget;
|
|
|
|
+ if (parent_widget == gfx::kNullAcceleratedWidget)
|
|
|
|
+ parent_widget = x_root_window_;
|
|
|
|
+
|
2014-09-04 19:53:40 +02:00
|
|
|
bounds_ = gfx::Rect(params.bounds.origin(),
|
|
|
|
AdjustSize(params.bounds.size()));
|
2014-05-22 23:01:22 +02:00
|
|
|
xwindow_ = XCreateWindow(
|
|
|
|
- xdisplay_, x_root_window_,
|
|
|
|
+ xdisplay_, parent_widget,
|
|
|
|
bounds_.x(), bounds_.y(),
|
|
|
|
bounds_.width(), bounds_.height(),
|
|
|
|
0, // border width
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -1706,6 +1718,10 @@ uint32_t DesktopWindowTreeHostX11::DispatchEvent(
|
2014-05-22 23:01:22 +02:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
+ case DestroyNotify:
|
|
|
|
+ xwindow_destroyed_ = true;
|
|
|
|
+ CloseNow();
|
|
|
|
+ break;
|
|
|
|
case FocusOut:
|
|
|
|
if (xev->xfocus.mode != NotifyGrab) {
|
|
|
|
ReleaseCapture();
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git desktop_aura/desktop_window_tree_host_x11.h desktop_aura/desktop_window_tree_host_x11.h
|
2014-10-10 19:54:35 +02:00
|
|
|
index 8a5e51f..4d5a777 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- desktop_aura/desktop_window_tree_host_x11.h
|
|
|
|
+++ desktop_aura/desktop_window_tree_host_x11.h
|
|
|
|
@@ -85,6 +85,8 @@ class VIEWS_EXPORT DesktopWindowTreeHostX11
|
2014-07-09 00:37:06 +02:00
|
|
|
// Deallocates the internal list of open windows.
|
|
|
|
static void CleanUpWindowList();
|
|
|
|
|
|
|
|
+ void set_screen_bounds(const gfx::Rect& bounds) { screen_bounds_ = bounds; }
|
|
|
|
+
|
|
|
|
protected:
|
|
|
|
// Overridden from DesktopWindowTreeHost:
|
|
|
|
virtual void Init(aura::Window* content_window,
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -256,6 +258,9 @@ class VIEWS_EXPORT DesktopWindowTreeHostX11
|
2014-07-09 00:37:06 +02:00
|
|
|
// The bounds of |xwindow_|.
|
|
|
|
gfx::Rect bounds_;
|
|
|
|
|
|
|
|
+ // Override the screen bounds when the host is a child window.
|
|
|
|
+ gfx::Rect screen_bounds_;
|
|
|
|
+
|
|
|
|
// Whenever the bounds are set, we keep the previous set of bounds around so
|
|
|
|
// we can have a better chance of getting the real |restored_bounds_|. Window
|
|
|
|
// managers tend to send a Configure message with the maximized bounds, and
|
2014-10-10 19:54:35 +02:00
|
|
|
@@ -340,6 +345,9 @@ class VIEWS_EXPORT DesktopWindowTreeHostX11
|
2014-09-04 19:53:40 +02:00
|
|
|
|
2014-10-10 19:54:35 +02:00
|
|
|
base::WeakPtrFactory<DesktopWindowTreeHostX11> close_widget_factory_;
|
2014-05-22 23:01:22 +02:00
|
|
|
|
|
|
|
+ // True if the xwindow has already been destroyed.
|
|
|
|
+ bool xwindow_destroyed_;
|
|
|
|
+
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(DesktopWindowTreeHostX11);
|
|
|
|
};
|
|
|
|
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git widget.cc widget.cc
|
2014-09-27 01:48:19 +02:00
|
|
|
index 8a9fa71..1e7536e 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- widget.cc
|
|
|
|
+++ widget.cc
|
|
|
|
@@ -116,6 +116,7 @@ Widget::InitParams::InitParams()
|
2014-02-07 00:36:29 +01:00
|
|
|
show_state(ui::SHOW_STATE_DEFAULT),
|
|
|
|
double_buffer(false),
|
|
|
|
parent(NULL),
|
2014-05-22 23:01:22 +02:00
|
|
|
+ parent_widget(gfx::kNullAcceleratedWidget),
|
2014-02-07 00:36:29 +01:00
|
|
|
native_widget(NULL),
|
2014-02-19 17:27:54 +01:00
|
|
|
desktop_window_tree_host(NULL),
|
2014-06-12 22:28:58 +02:00
|
|
|
layer_type(aura::WINDOW_LAYER_TEXTURED),
|
2014-09-04 19:53:40 +02:00
|
|
|
@@ -140,6 +141,7 @@ Widget::InitParams::InitParams(Type type)
|
2014-02-06 23:33:18 +01:00
|
|
|
show_state(ui::SHOW_STATE_DEFAULT),
|
|
|
|
double_buffer(false),
|
|
|
|
parent(NULL),
|
2014-05-22 23:01:22 +02:00
|
|
|
+ parent_widget(gfx::kNullAcceleratedWidget),
|
2014-02-06 23:33:18 +01:00
|
|
|
native_widget(NULL),
|
2014-02-19 17:27:54 +01:00
|
|
|
desktop_window_tree_host(NULL),
|
2014-06-12 22:28:58 +02:00
|
|
|
layer_type(aura::WINDOW_LAYER_TEXTURED),
|
2014-09-04 19:53:40 +02:00
|
|
|
@@ -314,7 +316,7 @@ void Widget::Init(const InitParams& in_params) {
|
2014-06-12 22:28:58 +02:00
|
|
|
InitParams params = in_params;
|
|
|
|
|
|
|
|
params.child |= (params.type == InitParams::TYPE_CONTROL);
|
|
|
|
- is_top_level_ = !params.child;
|
|
|
|
+ is_top_level_ = !params.child || params.parent_widget;
|
|
|
|
|
|
|
|
if (params.opacity == views::Widget::InitParams::INFER_OPACITY &&
|
|
|
|
params.type != views::Widget::InitParams::TYPE_WINDOW &&
|
2014-09-04 19:53:40 +02:00
|
|
|
@@ -375,7 +377,12 @@ void Widget::Init(const InitParams& in_params) {
|
2014-03-12 15:36:18 +01:00
|
|
|
Minimize();
|
|
|
|
} else if (params.delegate) {
|
|
|
|
SetContentsView(params.delegate->GetContentsView());
|
|
|
|
- SetInitialBoundsForFramelessWindow(params.bounds);
|
|
|
|
+ if (params.parent_widget) {
|
|
|
|
+ // Set the bounds directly instead of applying an inset.
|
|
|
|
+ SetBounds(params.bounds);
|
|
|
|
+ } else {
|
|
|
|
+ SetInitialBoundsForFramelessWindow(params.bounds);
|
|
|
|
+ }
|
|
|
|
}
|
2014-07-02 20:25:22 +02:00
|
|
|
// This must come after SetContentsView() or it might not be able to find
|
|
|
|
// the correct NativeTheme (on Linux). See http://crbug.com/384492
|
2014-09-04 19:53:40 +02:00
|
|
|
diff --git widget.h widget.h
|
2014-09-27 01:48:19 +02:00
|
|
|
index 96ab8b2..1cbd5d8 100644
|
2014-09-04 19:53:40 +02:00
|
|
|
--- widget.h
|
|
|
|
+++ widget.h
|
|
|
|
@@ -225,6 +225,7 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
|
2013-12-07 02:55:22 +01:00
|
|
|
// Should the widget be double buffered? Default is false.
|
|
|
|
bool double_buffer;
|
|
|
|
gfx::NativeView parent;
|
|
|
|
+ gfx::AcceleratedWidget parent_widget;
|
|
|
|
// Specifies the initial bounds of the Widget. Default is empty, which means
|
|
|
|
// the NativeWidget may specify a default size. If the parent is specified,
|
|
|
|
// |bounds| is in the parent's coordinate system. If the parent is not
|