2014-05-29 19:15:34 +02:00
|
|
|
Index: desktop_aura/desktop_screen_win.cc
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- desktop_aura/desktop_screen_win.cc (revision 280796)
|
2014-05-29 19:15:34 +02:00
|
|
|
+++ desktop_aura/desktop_screen_win.cc (working copy)
|
|
|
|
@@ -54,6 +54,8 @@
|
2013-12-07 02:55:22 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
HWND DesktopScreenWin::GetHWNDFromNativeView(gfx::NativeView window) const {
|
|
|
|
+ if (!window)
|
|
|
|
+ return NULL;
|
2014-04-04 18:50:38 +02:00
|
|
|
aura::WindowTreeHost* host = window->GetHost();
|
|
|
|
return host ? host->GetAcceleratedWidget() : NULL;
|
2013-12-07 02:55:22 +01:00
|
|
|
}
|
2014-07-01 00:30:29 +02:00
|
|
|
Index: desktop_aura/desktop_screen_x11.cc
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- desktop_aura/desktop_screen_x11.cc (revision 280796)
|
2014-07-01 00:30:29 +02:00
|
|
|
+++ desktop_aura/desktop_screen_x11.cc (working copy)
|
|
|
|
@@ -220,6 +220,9 @@
|
|
|
|
|
|
|
|
gfx::Display DesktopScreenX11::GetDisplayNearestWindow(
|
|
|
|
gfx::NativeView window) const {
|
|
|
|
+ if (!window)
|
|
|
|
+ return GetPrimaryDisplay();
|
|
|
|
+
|
|
|
|
// Getting screen bounds here safely is hard.
|
|
|
|
//
|
|
|
|
// You'd think we'd be able to just call window->GetBoundsInScreen(), but we
|
2014-05-29 19:15:34 +02:00
|
|
|
Index: desktop_aura/desktop_window_tree_host_win.cc
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- desktop_aura/desktop_window_tree_host_win.cc (revision 280796)
|
2014-05-29 19:15:34 +02:00
|
|
|
+++ desktop_aura/desktop_window_tree_host_win.cc (working copy)
|
|
|
|
@@ -129,7 +129,9 @@
|
2014-02-19 17:27:54 +01:00
|
|
|
native_widget_delegate_);
|
|
|
|
|
|
|
|
HWND parent_hwnd = NULL;
|
2014-04-04 18:50:38 +02:00
|
|
|
- if (params.parent && params.parent->GetHost())
|
|
|
|
+ if (params.parent_widget)
|
2014-02-19 17:27:54 +01:00
|
|
|
+ parent_hwnd = params.parent_widget;
|
2014-04-04 18:50:38 +02:00
|
|
|
+ else if (params.parent && params.parent->GetHost())
|
|
|
|
parent_hwnd = params.parent->GetHost()->GetAcceleratedWidget();
|
|
|
|
|
|
|
|
message_handler_->set_remove_standard_frame(params.remove_standard_frame);
|
2014-06-12 22:28:58 +02:00
|
|
|
@@ -770,6 +772,7 @@
|
2014-06-06 21:04:21 +02:00
|
|
|
|
|
|
|
void DesktopWindowTreeHostWin::HandleNativeFocus(HWND last_focused_window) {
|
|
|
|
// TODO(beng): inform the native_widget_delegate_.
|
|
|
|
+ GetWidget()->GetNativeWindow()->Focus();
|
|
|
|
InputMethod* input_method = GetInputMethod();
|
|
|
|
if (input_method)
|
|
|
|
input_method->OnFocus();
|
2014-06-12 22:28:58 +02:00
|
|
|
@@ -777,6 +780,7 @@
|
2014-06-06 21:04:21 +02:00
|
|
|
|
|
|
|
void DesktopWindowTreeHostWin::HandleNativeBlur(HWND focused_window) {
|
|
|
|
// TODO(beng): inform the native_widget_delegate_.
|
|
|
|
+ GetWidget()->GetNativeWindow()->Blur();
|
|
|
|
InputMethod* input_method = GetInputMethod();
|
|
|
|
if (input_method)
|
|
|
|
input_method->OnBlur();
|
2014-05-29 19:15:34 +02:00
|
|
|
Index: desktop_aura/desktop_window_tree_host_x11.cc
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- desktop_aura/desktop_window_tree_host_x11.cc (revision 280796)
|
2014-05-29 19:15:34 +02:00
|
|
|
+++ desktop_aura/desktop_window_tree_host_x11.cc (working copy)
|
2014-06-12 22:28:58 +02:00
|
|
|
@@ -148,7 +148,8 @@
|
2014-05-22 23:01:22 +02:00
|
|
|
window_parent_(NULL),
|
2014-05-29 19:15:34 +02:00
|
|
|
window_shape_(NULL),
|
|
|
|
custom_window_shape_(false),
|
2014-05-22 23:01:22 +02:00
|
|
|
- urgency_hint_set_(false) {
|
|
|
|
+ urgency_hint_set_(false),
|
|
|
|
+ xwindow_destroyed_(false) {
|
|
|
|
}
|
|
|
|
|
|
|
|
DesktopWindowTreeHostX11::~DesktopWindowTreeHostX11() {
|
2014-07-02 20:25:22 +02:00
|
|
|
@@ -347,7 +348,8 @@
|
2014-05-22 23:01:22 +02:00
|
|
|
// Actually free our native resources.
|
|
|
|
if (ui::PlatformEventSource::GetInstance())
|
|
|
|
ui::PlatformEventSource::GetInstance()->RemovePlatformEventDispatcher(this);
|
|
|
|
- XDestroyWindow(xdisplay_, xwindow_);
|
|
|
|
+ if (!xwindow_destroyed_)
|
|
|
|
+ XDestroyWindow(xdisplay_, xwindow_);
|
|
|
|
xwindow_ = None;
|
|
|
|
|
|
|
|
desktop_native_widget_aura_->OnHostClosed();
|
2014-07-02 20:25:22 +02:00
|
|
|
@@ -1042,9 +1044,13 @@
|
2014-05-29 19:15:34 +02:00
|
|
|
}
|
|
|
|
}
|
2014-05-22 23:01:22 +02:00
|
|
|
|
|
|
|
+ gfx::AcceleratedWidget parent_widget = params.parent_widget;
|
|
|
|
+ if (parent_widget == gfx::kNullAcceleratedWidget)
|
|
|
|
+ parent_widget = x_root_window_;
|
|
|
|
+
|
|
|
|
bounds_ = params.bounds;
|
|
|
|
xwindow_ = XCreateWindow(
|
|
|
|
- xdisplay_, x_root_window_,
|
|
|
|
+ xdisplay_, parent_widget,
|
|
|
|
bounds_.x(), bounds_.y(),
|
|
|
|
bounds_.width(), bounds_.height(),
|
|
|
|
0, // border width
|
2014-07-02 20:25:22 +02:00
|
|
|
@@ -1600,6 +1606,10 @@
|
2014-05-22 23:01:22 +02:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
+ case DestroyNotify:
|
|
|
|
+ xwindow_destroyed_ = true;
|
|
|
|
+ CloseNow();
|
|
|
|
+ break;
|
|
|
|
case FocusOut:
|
|
|
|
if (xev->xfocus.mode != NotifyGrab) {
|
|
|
|
ReleaseCapture();
|
2014-05-29 19:15:34 +02:00
|
|
|
Index: desktop_aura/desktop_window_tree_host_x11.h
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- desktop_aura/desktop_window_tree_host_x11.h (revision 280796)
|
2014-05-29 19:15:34 +02:00
|
|
|
+++ desktop_aura/desktop_window_tree_host_x11.h (working copy)
|
2014-07-02 20:25:22 +02:00
|
|
|
@@ -331,6 +331,9 @@
|
2014-05-22 23:01:22 +02:00
|
|
|
// the frame when |xwindow_| gains focus or handles a mouse button event.
|
|
|
|
bool urgency_hint_set_;
|
|
|
|
|
|
|
|
+ // True if the xwindow has already been destroyed.
|
|
|
|
+ bool xwindow_destroyed_;
|
|
|
|
+
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(DesktopWindowTreeHostX11);
|
|
|
|
};
|
|
|
|
|
2014-05-29 19:15:34 +02:00
|
|
|
Index: widget.cc
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- widget.cc (revision 280796)
|
2014-05-29 19:15:34 +02:00
|
|
|
+++ widget.cc (working copy)
|
|
|
|
@@ -116,6 +116,7 @@
|
2014-02-07 00:36:29 +01:00
|
|
|
show_state(ui::SHOW_STATE_DEFAULT),
|
|
|
|
double_buffer(false),
|
|
|
|
parent(NULL),
|
2014-05-22 23:01:22 +02:00
|
|
|
+ parent_widget(gfx::kNullAcceleratedWidget),
|
2014-02-07 00:36:29 +01:00
|
|
|
native_widget(NULL),
|
2014-02-19 17:27:54 +01:00
|
|
|
desktop_window_tree_host(NULL),
|
2014-06-12 22:28:58 +02:00
|
|
|
layer_type(aura::WINDOW_LAYER_TEXTURED),
|
|
|
|
@@ -140,6 +141,7 @@
|
2014-02-06 23:33:18 +01:00
|
|
|
show_state(ui::SHOW_STATE_DEFAULT),
|
|
|
|
double_buffer(false),
|
|
|
|
parent(NULL),
|
2014-05-22 23:01:22 +02:00
|
|
|
+ parent_widget(gfx::kNullAcceleratedWidget),
|
2014-02-06 23:33:18 +01:00
|
|
|
native_widget(NULL),
|
2014-02-19 17:27:54 +01:00
|
|
|
desktop_window_tree_host(NULL),
|
2014-06-12 22:28:58 +02:00
|
|
|
layer_type(aura::WINDOW_LAYER_TEXTURED),
|
|
|
|
@@ -314,7 +316,7 @@
|
|
|
|
InitParams params = in_params;
|
|
|
|
|
|
|
|
params.child |= (params.type == InitParams::TYPE_CONTROL);
|
|
|
|
- is_top_level_ = !params.child;
|
|
|
|
+ is_top_level_ = !params.child || params.parent_widget;
|
|
|
|
|
|
|
|
if (params.opacity == views::Widget::InitParams::INFER_OPACITY &&
|
|
|
|
params.type != views::Widget::InitParams::TYPE_WINDOW &&
|
2014-07-02 20:25:22 +02:00
|
|
|
@@ -375,7 +377,12 @@
|
2014-03-12 15:36:18 +01:00
|
|
|
Minimize();
|
|
|
|
} else if (params.delegate) {
|
|
|
|
SetContentsView(params.delegate->GetContentsView());
|
|
|
|
- SetInitialBoundsForFramelessWindow(params.bounds);
|
|
|
|
+ if (params.parent_widget) {
|
|
|
|
+ // Set the bounds directly instead of applying an inset.
|
|
|
|
+ SetBounds(params.bounds);
|
|
|
|
+ } else {
|
|
|
|
+ SetInitialBoundsForFramelessWindow(params.bounds);
|
|
|
|
+ }
|
|
|
|
}
|
2014-07-02 20:25:22 +02:00
|
|
|
// This must come after SetContentsView() or it might not be able to find
|
|
|
|
// the correct NativeTheme (on Linux). See http://crbug.com/384492
|
2014-05-29 19:15:34 +02:00
|
|
|
Index: widget.h
|
|
|
|
===================================================================
|
2014-07-02 20:25:22 +02:00
|
|
|
--- widget.h (revision 280796)
|
2014-05-29 19:15:34 +02:00
|
|
|
+++ widget.h (working copy)
|
2014-06-12 22:28:58 +02:00
|
|
|
@@ -222,6 +222,7 @@
|
2013-12-07 02:55:22 +01:00
|
|
|
// Should the widget be double buffered? Default is false.
|
|
|
|
bool double_buffer;
|
|
|
|
gfx::NativeView parent;
|
|
|
|
+ gfx::AcceleratedWidget parent_widget;
|
|
|
|
// Specifies the initial bounds of the Widget. Default is empty, which means
|
|
|
|
// the NativeWidget may specify a default size. If the parent is specified,
|
|
|
|
// |bounds| is in the parent's coordinate system. If the parent is not
|