When we detected a playback error due to a too small downloaded file
the user had the choice to try again to play the video. On OSMC+raspi3
it was leading to a crash everytime the user was trying to play again
the video.
To avoid this now the user is only offered the option to pause or not
the download: the user will have to manually play again the video.
Depending on the user feedbacks and the test on other platforms (for
instance if the code that was removed is actually working on other
platforms), we may enable back this feature.
Now torrents are downloaded with vfs.libtorrent[1].
Some parts of the code were removed as they will probably be useless
in the future. For instance, the service is disabled (temporarily?)
because the download in background/foreground is now managed by
vfs.libtorrent.
Use the Read() API of vfs.libtorrent to retrieve the path where the
torrent was downloaded.
Also:
* Display a warning if there are more than 1 file in the torrent
because the add-on will play only the first file
* Remove the "start downloading" notification since an equivalent
message is now displayed by vfs.libtorrent
[1]:https://framagit.org/thombet/vfs.libtorrent
* Convert settings.xml to the new format supported in Kodi 19
* Create help strings to guide the users
Note: the translation of the new help strings in German is missing.
* Remove empty tags in addon.xml and add a disclaimer
* Update the description of the add-on in addon.xml
* Move icon.png into the "resources" folder to match Kodi guidelines (a
solid white background is added automatically by Kodi so the icon was
modified with a white background to avoid unexpected display and to
match Kodi guidelines)
* Improve the translation guidelines
* Add a missing dot in a localized string
* Localize all the strings so that the whole add-on can be translated
(menus, notifications, etc.)
* Translate all the strings into French
* Add advice for future translators in the contribution guidelines
* List the supported languages in the README and a link to the
translation guidelines
* Rearrange the parts of the README to have the most used information at
the top
Display a notification when the PeerTube service started so that the
user is aware that the add-on can be used.
This notification will be useful especially on slow devices.
The notification can be disabled in the settings.
* Turn the name of the main category of the settings into a localized
string
* Add separators to group settings per theme
* Make some settings name more explicit
* Translate the possible values of the settings video_filter and
video_sort_method
See merge request StCyr/plugin.video.peertube!20 for more information
Use "local" instead of "all-local" by default because "all-local"
requires admin privileges
Other improvements:
* Replace urllib with requests to make the management of the HTTP
requests simpler (better error handling and easier implementation of
complex requests in the future)
* Refactor the functions used to build the HTTP request to improve
maintainability (don't know if it makes sense to keep a single
function for the "search" and the "list videos" request).
* Use "urlencode" to generate the Kodi URL using a dict to make it more
generic.
* Create a function to log messages easily in Kodi's debug log. It will
decrease the amount of duplicate code.
* Fix some errors reported by pylint with regards to PEP 8
- when browsing ( and not searching ) it is possible to select
filter=local that will show only local video
- create dedicated method to build kodi and peertube api url
- bumped version to 0.3.1.1 to indicate this change
- if selected upstream might want to change it to 0.3.2
Thomas Bétous
DavidHenryThoreau
philippe lhardy
Cyrille Bollu
Famille Bollu