Also serve /favicon.ico directly as 404 to avoid pointless requests

This commit is contained in:
southerntofu 2021-07-28 19:43:35 -04:00 committed by metalune
parent 3040a8f320
commit 404b6e73f6
1 changed files with 10 additions and 6 deletions

16
main.py
View File

@ -157,12 +157,7 @@ async def simpleer_search(query, page):
@app.route("/<string:domain>/") @app.route("/<string:domain>/")
async def instance(domain): async def instance(domain):
# favicon.ico is not a domain name # favicon.ico is not a domain name
if domain == "favicon.ico": if domain == "favicon.ico": return await favicon()
return await render_template(
"error.html",
error_number = "404",
error_reason = "We don't have a favicon yet. If you would like to contribute one, please send it to ~metalune/public-inbox@lists.sr.ht"
), 404
return redirect("/" + domain + "/videos/trending") return redirect("/" + domain + "/videos/trending")
@app.route("/<string:domain>/videos/local", defaults = {"page": 1}) @app.route("/<string:domain>/videos/local", defaults = {"page": 1})
@ -430,6 +425,15 @@ async def subtitles(domain, id, lang):
error_reason = e error_reason = e
), 500 ), 500
# --- Favicon ---
@app.route("/favicon.ico")
async def favicon():
return await render_template(
"error.html",
error_number = "404",
error_reason = "We don't have a favicon yet. If you would like to contribute one, please send it to ~metalune/public-inbox@lists.sr.ht"
), 404
if __name__ == "__main__": if __name__ == "__main__":
if len(sys.argv) == 3: if len(sys.argv) == 3:
interface = sys.argv[1] interface = sys.argv[1]