558c9147a2
Move sub icon visibility line
2021-12-28 15:54:36 -05:00
fc0e709817
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00
b67bf16d4f
Minified code
2021-12-26 23:57:54 +01:00
fb3be544ce
Fixed code styling
2021-12-26 00:12:48 -05:00
53f5741317
Fixes view of sub-channel icon when not in use
2021-12-25 18:10:05 -05:00
07015973d2
Added ability to see pinned comment
2021-12-24 11:29:34 -06:00
215880207e
Merge pull request #7562 from TeamNewPipe/code-quality
...
Small improvements to code quality and readability
2021-12-23 23:54:29 +01:00
989bcbf895
Add Already playing in background toast
2021-12-23 22:12:38 +01:00
05370dbb94
Merge pull request #7556 from Jaspann/improve-hashtags
...
Fixes hashtags that use non-English characters.
2021-12-23 11:45:52 +01:00
f6cad2d9cf
Merge pull request #7555 from litetex/remove-mediaparser
...
Remove/Revert MediaParser support (Android 11+) due to bugs
2021-12-22 17:32:28 +01:00
37b8a9375f
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
d71af9a625
Introduce constants for some Strings that indicate no data in Tab class
2021-12-21 20:53:17 +01:00
a163d5461d
Make PlayerHolder.bound private
2021-12-21 20:51:18 +01:00
a274baf5cd
Adds comment to HASHTAGS_PATTERN
2021-12-20 14:13:40 -05:00
361760be0a
Allows multilingual support in hashtags
2021-12-19 20:33:55 -05:00
eea2768633
Removed/Reverted MediaParser support (Android 11+) due to bugs
2021-12-19 20:16:10 +01:00
d3562c70f5
Merge pull request #7451 from Cheechaii/respect-cutout-in-multiwindow
...
Respect cutouts when playing in MultiWindow
2021-12-19 13:23:28 +01:00
b21d231e3a
Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found
...
Show an alert-dialog when no appropriate file-manager was found
2021-12-14 20:01:02 +01:00
4058277b7a
Merge pull request #7482 from TeamNewPipe/unify-error-reporting
...
Unify error reporting and add error notification
2021-12-14 19:58:41 +01:00
dd9772cde2
Merge pull request #7491 from Stypox/fix-search-order
...
Fix order of local search results
2021-12-14 09:07:17 -05:00
b056faa97f
Merge pull request #7500 from TacoTheDank/bumpKtlint
...
Bump ktlint, Checkstyle, Java version
2021-12-12 15:07:24 +01:00
3ff00ff50e
Fix lambda code formatting
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 13:04:32 +00:00
baee915db5
Remove unecessary line
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 12:51:01 +00:00
c92a90749e
Respect cutouts when playing in MultiWindow
2021-12-09 20:58:05 +01:00
e806f8c4e6
Android 10+ only allows SAF -> Respect that in the dialog
2021-12-08 20:22:26 +01:00
8a5e2ffa57
Fix order of local search results
2021-12-08 13:59:32 +01:00
bb49b1cfb1
Add javadoc to ErrorUtil and ErrorActivity
2021-12-07 18:14:53 +01:00
75db002369
Update ktlint to 0.43.2
2021-12-04 21:22:29 -05:00
41a0dc1abd
Disable media tunneling on Philips QM16XE
2021-12-04 22:23:09 +01:00
950956ebf2
Also show a toast on error notification
...
since the notification is silent, also show a toast, otherwise the user is confused
2021-12-04 10:50:27 +01:00
c8e2ab4c83
Remove PlayerErrorHandler and correctly set ErrorInfo msg
2021-12-04 10:36:36 +01:00
397f93b079
Prevent exception from being serialized in ErrorInfo
...
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
2021-12-04 10:36:36 +01:00
09d137f740
Add PendingIntent to ErrorUtil.createNotification
2021-12-04 10:36:36 +01:00
81f740d409
Replace ErrorActivity with ErrorUtil
2021-12-04 10:36:36 +01:00
1d2642f1e3
Create ErrorUtil class with three ways to report errors
...
Activity, snackbar and notification
2021-12-04 10:36:31 +01:00
7cd3603bbb
Fetch sparse items when playing in background or popup
2021-12-03 22:38:03 +00:00
ec7de2a6dc
Fix StreamType check, missing import, and styling errors
2021-12-03 21:53:36 +00:00
3d1a3606c9
Remove unused variable
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-03 21:30:26 +00:00
6472e9b6b6
Remove unused code
2021-12-03 21:29:34 +00:00
744cfe5672
Removed unused import
2021-11-29 21:13:22 +01:00
17724a901c
Removed annotations due to wrong warnings
2021-11-29 21:03:59 +01:00
b2323859e5
Refactoring + deduplicated code
2021-11-28 14:07:45 +01:00
4c8dca5300
Fixed NPE + Problems with context
2021-11-28 13:42:26 +01:00
68e7fcf8ee
Fixed typos
2021-11-27 23:39:17 +01:00
f78983b16b
Show an alert/dialog when no appropriate file-manager was found
2021-11-27 15:52:54 +01:00
2f99a217c3
Fixed build
2021-11-23 20:21:59 +01:00
0d51eefbb9
Refactoring
2021-11-23 20:12:16 +01:00
aa28a85747
Added a workaround for not serializable exceptions
2021-11-23 20:12:14 +01:00
f18ee8e83d
Added a bit more documentation
2021-11-23 20:12:13 +01:00
fb58967766
PlayerErrorHandler refactor + docs
2021-11-23 20:12:12 +01:00
e5c00a7ef4
Added some doc
2021-11-23 20:12:10 +01:00
769791af7a
Added a "Crash the player" debug option
2021-11-23 20:12:09 +01:00
e632fab4d0
Added option to report player errors
...
* Added a new setting so that player errors are reported (under Video and Audio > Player)
* Moved the player error logic to separate class specially created for this purpose
2021-11-23 20:12:07 +01:00
91611fcae4
Don't fetch uneeded stream info for live streams
...
Co-authored-by: Stypox <stypox@pm.me>
2021-11-23 15:22:11 +00:00
6cd25d7e55
Merge pull request #7412 from litetex/code-cleanup
...
Some code cleanup(s)
2021-11-23 08:59:34 +01:00
c9488eb042
Removed useless lines
2021-11-22 19:49:52 +01:00
c8516a04dc
Formatted code
2021-11-21 19:56:50 +01:00
02d1b98b1c
Removed useless doc
2021-11-21 19:46:11 +01:00
d8236bbedd
Merge pull request #7406 from Redirion/usedefaultloadcontrol
...
Use DefaultLoadcontrol
2021-11-21 15:11:21 +01:00
bd9dcfb28a
Merge pull request #7381 from litetex/prevent-automatic-replay-after-returning-from-background
...
Prevent automatic replay after returning from background
2021-11-17 09:38:09 +01:00
d5199eac3e
Merge pull request #7050 from litetex/feed-refactor-new-items-handling
...
Rework feed new items handling
2021-11-15 23:20:07 +01:00
7638d229c0
Fixed typo
2021-11-15 20:24:40 +01:00
a641c5bb58
Update Groupie to 2.9.0
2021-11-15 20:24:39 +01:00
1e0c9f46ad
Improved highlighting in FeedFragment
...
Now keeps the ``selectableItemBackground`` when highligthing an item.
2021-11-15 20:22:23 +01:00
4eb02f584e
Fixed default visibility of "new feed items" button
...
Fixed/Avoid NPEs
2021-11-15 20:22:22 +01:00
700c1b4b25
Removed unnecessary layout
...
Moved the feed button up a bit
2021-11-15 20:22:21 +01:00
4b4337e078
Used more understandable kotlin methods
2021-11-15 20:22:20 +01:00
38ce800685
Fixed feed when animations are off
...
Introduced a check if corresponding animations on the devices are enabled
2021-11-15 20:22:20 +01:00
2310e8c1d6
Made ``hideNewItemsLoaded`` more null safe
2021-11-15 20:22:19 +01:00
1b2b3a4f88
Make new feed items bold
2021-11-15 20:22:18 +01:00
d11129a76b
Fixed StackOverflow
2021-11-15 20:22:17 +01:00
02789122a0
Implemented UI highlighting and "new feed items"-notification
...
Fixed format
2021-11-15 20:22:17 +01:00
676bc02d52
No more reaction to unnecessary feed db-changes
...
This caused duplicate events (https://github.com/TeamNewPipe/NewPipe/pull/6686#issuecomment-909575283 ) and unnecessary processing of items
2021-11-15 20:21:23 +01:00
8b807b0706
Enhanced ``View.slideUp``
2021-11-15 20:21:21 +01:00
316db0e4c6
setRecovery: Remove checks and use Math.min/max
2021-11-15 19:56:14 +01:00
010c607e40
Prevent automatic replay after returning from background
...
See also https://github.com/TeamNewPipe/NewPipe/pull/7195#issuecomment-962624380
2021-11-15 19:47:08 +01:00
3e099fb2a3
Fixed Period Transition
2021-11-14 21:19:36 +01:00
9c9730b152
Use DefaultLoadcontrol
2021-11-14 20:12:12 +01:00
9e44053e22
Merge pull request #7160 from nschulzke/mark-as-watched-everywhere
...
Enable Mark as Watched in all the other playlist fragments.
2021-11-13 20:37:59 +01:00
dee32c3dc5
Factor out shouldAddMarkAsWatched as a shared function
2021-11-13 10:18:17 -07:00
344fbff59a
Merge pull request #7363 from litetex/playback-speed-ctrls-simple-landscape-improvements
...
Simple playback-speed-controls improvements
2021-11-12 21:19:17 +01:00
48a1ab64b0
Refactored ``PlaybackResolver``
...
* fixes the deprecation of ``setTag``
* makes the code more consistent
* de-duplicates some code
2021-11-12 20:14:39 +01:00
dd2cde3c1a
De-duplicated PlayerDataSource-code
2021-11-12 19:40:00 +01:00
1b9c2b37c5
Use Android11+ extractors
2021-11-12 19:17:52 +01:00
eae1f8b597
Update ExoPlayer to 2.14.2
2021-11-12 19:17:51 +01:00
adf9badbf6
Fixed toggle not in sync with list after app restart + refactored the code a bit
2021-11-11 19:46:15 +01:00
c35fe4f3f1
moved preference key from viewmodel to settings_keys.xml
2021-11-10 16:16:17 -05:00
63291f8101
added show watched items toggle preference
...
default sharedpreference is used to persist and retrieve show watched menu option toggle state
2021-11-07 23:11:10 -05:00
62efb588ef
Removed obvious title from the "Playback Speed Controls"
2021-11-07 13:51:43 +01:00
203ca9afc6
Removed unused imports
2021-11-06 21:07:00 +01:00
a23f941ac8
Simplified some code and added some comments
2021-11-05 19:07:56 +01:00
b0a10f0542
Merged extremely similar code together / parity between video and popup player
...
* Removed ``player.getPlayPauseButton().requestFocus();`` as there is no reason why it was introduced there documented
* Use the same delay to hide the controls on both players
2021-11-05 18:10:55 +01:00
478ad42977
De-Duplicated some code
2021-11-05 18:07:21 +01:00
0764983ac6
Why log double?
2021-11-05 18:06:32 +01:00
2b2f1ee8f5
Added some doc
2021-11-05 18:06:10 +01:00
28f167fd99
Removed dead code
2021-11-05 18:04:57 +01:00
272be36dd9
Removed ``e.printStacktrace`` and used an proper logger
2021-11-05 18:04:49 +01:00
f933db8117
Added a custom title
...
to also save some margin/padding/etc
2021-11-04 19:47:08 +01:00
2e862b4ccc
Merge pull request #6844 from 0x416c6578/shuffle-mode-ui-fix
...
Fixed shuffle button opacity UI bug
2021-11-03 18:18:31 +01:00
ecac897e7b
Fixed typo
2021-11-03 17:30:30 +01:00
c0f7b123a3
Merge pull request #7296 from vhouriet/vhouriet_feature_issue6049
...
Add "Check for updates" button in update settings
2021-11-01 23:17:25 +01:00
bc2f0f9f3e
Update stream state in database after loading
2021-10-28 01:11:53 +01:00
e9e2afa61a
Merge pull request #7061 from TiA4f8R/custom-textview-edittext
...
Use custom TextViews and EditTexts in all XML resources
2021-10-27 20:47:15 +02:00
403154b2e1
Less indents and code -> better readable
...
Also removed a useless variable
2021-10-26 20:47:15 +02:00
e5fd24b0d1
Make naming great again
...
When we build APKs in PRs it's also a GITHUB_APK...
2021-10-26 20:47:14 +02:00
8dc34274a1
Removed dead code
2021-10-26 20:47:13 +02:00
467bd21de2
Cleanup up some code
2021-10-26 20:47:13 +02:00
5c9705d94e
Change check for updates button to trigger a version check
2021-10-26 20:47:12 +02:00
85fb5827aa
Add Check for updates button
2021-10-26 20:47:11 +02:00
7067deb328
Merge pull request #7261 from TacoTheDank/bumpRecyclerView
...
Update RecyclerView & Groupie libraries
2021-10-24 21:22:04 +02:00
af936bc646
Always create a backup list when shuffling
...
The backup-list has to be created at all cost (even when current list size <= 2). Otherwise it's not possible to enter shuffle-mode (as ``isShuffled()`` always returns false)!
2021-10-23 17:35:42 +02:00
d66f933c69
Fixing the shuffle button on the UI is enough.
...
No need for doing the heavier method ``onShuffleModeEnabledChanged(false);``
2021-10-23 16:46:56 +02:00
cf81c37683
Removed changes to the intent handler
2021-10-23 16:43:29 +02:00
d2306b0fd7
Fixed shuffle button opacity bug
...
Parameterised shuffle state into initPlayback for potentially passing the shuffle state into the player in the future
2021-10-23 16:43:28 +02:00
44cad27d0a
Merge pull request #7268 from TeamNewPipe/release/0.21.13
...
Release 0.21.13
- Fix playback resume
- Ensure that the service for new version checks is not started in background
2021-10-21 20:51:01 +02:00
768bb0bbcd
Start service for update checks in onPastCreate()
2021-10-20 23:55:18 +02:00
ac071b383f
Revert part of #6872 and fix playback resuming
2021-10-20 23:20:26 +02:00
b6b19b474e
Update RecyclerView & Groupie
2021-10-19 17:31:59 -04:00
28c72e7f63
Fix new version check still occassionally started in background
2021-10-17 12:55:06 +02:00
5fcc3b4dab
[Player] Fix resuming playback
...
This was caused by #6872
2021-10-17 12:13:38 +02:00
51837ce36f
Get rid of setUserVisibleHint
2021-10-16 15:33:45 -04:00
ddaafb68c8
Adress new requested changes
2021-10-16 15:32:56 +02:00
a744775fe7
Adress requested changes and remove an unused return value in NewPipeTextViewHelper
2021-10-16 13:41:05 +02:00
50b85a7734
Simplify code
2021-10-16 13:41:05 +02:00
aab09c0c65
Merge the Share process of the two classes into one
...
A new class has been added in the util package: NewPipeTextViewHelper.
It shares the selected text of a TextView with ShareUtils#shareText (with the created shareSelectedTextWithShareUtils static method).
Only this static method can be used by other classes, other methods are private.
2021-10-16 13:41:04 +02:00
3ded6feddb
Improve code of created views
...
Use the same logic as Android TextViews
2021-10-16 13:41:04 +02:00
c8802fe5d0
Add JavaDocs on created views
2021-10-16 13:41:04 +02:00
411b3129f9
Use a custom EditText everywhere to be able to share with ShareUtils the selected text
...
This EditText class extends the AppCompatEditText class from androidx.
These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:41:03 +02:00
a55acd38df
Use a custom TextView everywhere to be able to share with ShareUtils the selected text
...
This TextView class extends the AppCompatTextView class from androidx.
These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:40:54 +02:00
7edef8d5a2
Merge pull request #7222 from ktprograms/queue-menu-channel-details
...
Added the 'Show Channel Details' menu item to the Queue long press menu
2021-10-15 20:28:18 +02:00
03d2ca9f9f
Fixed format of code
2021-10-15 20:18:52 +02:00
2271ea4281
Improved documentation
2021-10-15 20:16:34 +02:00
afc8db8f81
Add reasoning for separate openChannelFragmentUsingIntent method
2021-10-14 09:51:25 +08:00
4af49ee5a6
Merge pull request #7194 from KalleStruik/add-to-playlist-in-share
...
Add a "add to playlist" option in the share menu
2021-10-13 20:34:07 +02:00
d7b29aae5c
Merge branch 'master' into dev
2021-10-12 20:03:42 +02:00
9f7a8407ca
Merge pull request #7224 from vhouriet/vhouriet_fix_check-background-player-type
...
Check if background player already active before displaying player toast
2021-10-12 19:47:50 +02:00
54d3bff26d
Move checking for new version to MainAcitvity
...
When the service is started from the Application class, the app might be still in the background. This is definetly not the case when MainActivity.onCreate() is called.
Fixes #7227
2021-10-12 16:45:01 +02:00
a2050a5211
Merge pull request #7215 from litetex/code-cleanup-drawer-main-activity
...
Deduplicated drawer code in MainActivity
2021-10-11 21:29:42 +02:00
e9bd2934c3
Merge pull request #7202 from vhouriet/vhouriet_bug_issue-6662
...
Fix clicking timestamp shows Toast "Playing in popup mode"
2021-10-11 21:20:26 +02:00
50634eb2b3
Check player type before displaying background player toast
2021-10-11 19:41:22 +02:00
a2ff770afc
Added the 'Show Channel Details' menu item to the Queue long press menu
...
Created a method in NavigationHelper that opens the channel fragment using an Intent to MainActivity instead of replacing fragments.
2021-10-11 14:47:37 +08:00
658d988254
Simplify code and add annotations
2021-10-10 20:33:05 +02:00
9d7e9289bb
Fix cursor color in PlaylistCreationDialog
2021-10-10 12:32:57 +02:00
d7d87691cb
Add to playlist - Showing toast that this may take a moment
2021-10-09 18:47:36 +02:00
731640997e
Cleaned up PlaylistDialog-related code
2021-10-09 18:46:20 +02:00
64d7432852
Deduplicated drawer code in MainActivity
2021-10-09 16:37:34 +02:00
e6fffc0d5b
Fix crash on missing title when sharing livestream
2021-10-08 21:42:01 +02:00
1c9f68bcae
Fix clicking timestamp shows Toast "Playing in popup mode"
...
Fixes #6662
2021-10-05 18:15:36 +02:00
b633108a4c
Use the correct TAG in NavigationHelper
2021-10-03 22:04:34 +02:00
ceb55d0ede
Set the theme for PlaylistCreationDialog explicitly.
2021-10-03 14:25:50 +02:00
Jaspann
litetex
David Kramer
Tobi
vhouriet
XiangRongLin
Robin
Douile
Cheechaii
Stypox
TacoTheDank
Robin
Nathan Schulzke
Baji Shaik
vhouriet
0x416c6578
TiA4f8R
ktprograms
Kalle Struik