a44b7c9c9e
Disabled animations for subscription fragment
2022-10-28 04:54:33 +11:00
4b32890b5f
Fix random crash in SubscriptionFragment
2022-10-27 18:45:06 +02:00
a41aa01461
Solve two SonarCloud smells
2022-10-27 17:52:17 +02:00
ea875c59af
Deduplicate isGridLayout calls
2022-10-27 17:25:06 +02:00
83d16dc656
Fix flickering in channel groups list
2022-10-27 14:01:04 +02:00
8ceefee1e3
Put "New feed group" item at the top
2022-10-27 13:51:56 +02:00
0e169951f7
Fix grid/list toggle implementation of feed
2022-10-26 23:20:32 +02:00
f7e10eb094
Fully working card and list view
2022-10-26 21:05:55 +11:00
0d73d193ad
Added Toast Notification "Hold to enqueue" ( #9196 )
...
* Added Toast Notification "Hold to enqueue"
* Check if enqueue tips are enabled
* created function showHoldToAppendTipIfNeeded() for toast message
2022-10-26 11:35:03 +02:00
c607089cbb
Altered grid view similar to Youtube app layout
2022-10-26 00:06:48 +11:00
28464344c1
Finalized design for vertical card view and removed unneeded variables in SubscriptionFragment.kt
2022-10-25 11:43:25 +11:00
ed68e3bd46
Fully working toggle button that change between vertical and horizontal view
2022-10-25 10:54:27 +11:00
082d7a3f18
Added working binding for a "new" button that works in the list layout.
2022-10-25 02:38:31 +11:00
6eddaa0d38
Added boolean to handle feed groups. May need a better solution for this
2022-10-25 02:20:14 +11:00
1aa1a0287e
Could toggle between list view and grid view...once. Requires bug fixing on refreshing
2022-10-25 02:01:57 +11:00
3bfcb16f9a
Bug: SubscriptionViewModel.kt did not map values for FeedGroupCardVerticalItem in line 26
2022-10-25 00:32:21 +11:00
f37d869ea2
Button can be toggled but not all strings have been fed
2022-10-24 23:01:02 +11:00
78547b4fa4
Created a list view for channel group.
2022-10-24 18:55:08 +11:00
29e56b9f2d
Created a button in SubscriptionFragment.kt that reads whether button is clicked
2022-10-24 16:55:12 +11:00
8482bf9fed
Created a non-functional button in HeaderWithMenuItem.kt
2022-10-23 23:43:52 +11:00
ed4eb124e4
Merge pull request #8734 from Stypox/feed-group-factory
...
Improve `FeedGroupDialogViewModel` factory
2022-10-09 19:35:47 +02:00
489f052ef9
Fix feed menu tooltips (silly copy-paste error)
2022-09-19 11:21:42 +02:00
051c572e7f
Show correct tooltips for actions in feed
2022-09-13 15:26:04 +02:00
52dbfdee00
Keep strong references to Picasso notification icon loading targets
...
Before the Target would sometimes be garbage collected before being called with the loaded channel icon, since Picasso holds weak references to targets. This meant that sometimes a new streams notification would not be shown, because the lambda that should have shown it had already been garbage collected.
2022-08-25 16:41:51 +02:00
6399e39507
Remove from playlist only upon selecting the option and not afterwards.
2022-08-15 07:26:36 +05:30
f9443f7421
Refactor removeWatchedStreams() in LocalPlaylistFragment.
2022-08-15 07:26:36 +05:30
e136a6f915
Use range-limiting methods in more places.
2022-08-08 07:10:16 +05:30
ee6a279596
Remove unused methods in HistoryRecordManager.
2022-08-06 05:09:54 +05:30
8dce66d76f
Improve FeedGroupDialogViewModel factory
2022-08-04 10:49:33 +02:00
7f018b90db
Merge branch 'dev' into OnClickGesture_interface
2022-08-04 06:10:39 +05:30
47f58040d1
Make OnClickGesture an interface.
2022-08-01 06:47:00 +05:30
311d392386
Use Application instead of Context in FeedViewModel.
2022-07-31 08:37:16 +05:30
404c13d4c1
Improve FeedViewModel factory
2022-07-31 08:30:17 +05:30
5c68c8ece8
Update Lifecycle to 2.5.1.
2022-07-31 08:30:17 +05:30
8f37015dbb
Merge pull request #8621 from Stypox/deduplicate-feed
...
Deduplicate SQL queries to get feed streams
2022-07-24 14:52:35 +02:00
37275e8fe3
Fix wrong thumbnail used as placeholder for channel
2022-07-22 15:13:47 +02:00
e8669d4ab5
Deduplicate SQL queries to get feed streams
2022-07-18 23:39:57 +02:00
8b209df253
Changed the code accordingly
...
+ Removed some unused code
2022-07-15 19:55:19 +02:00
b7a44560f5
Merge pull request #8170 from Stypox/player-refactor
...
Refactor player and extract UI components
2022-07-15 19:41:23 +02:00
6ea85e6380
Rename dummy_* and more to placeholder_*
2022-07-14 14:27:33 +02:00
70e3c9805a
Merge pull request #8542 from carmebar/share-playlist
...
Add 'Share playlist' option to Playlist fragment
2022-07-13 23:45:08 +02:00
8187a3bc04
Move PlayerType into its own class and add documentation
...
Also replace some `isPlayerOpen` with direct `playerType == null` checks.
2022-07-13 23:33:18 +02:00
61c1da144e
Some refactorings after review comments
2022-07-13 23:33:18 +02:00
4979f84e41
Solve some Sonarlint warnings
2022-07-13 23:33:16 +02:00
76ced59b62
Refactor player: separate UIs and more
2022-07-13 23:25:26 +02:00
99104fc11d
Clean up pre-Lollipop checks
2022-07-13 19:02:24 +02:00
d0b6d95f1b
Add Share option to local playlists
...
A newline-separated text is shared
2022-07-13 14:32:23 +02:00
b96c8a0c2f
Merge pull request #8545 from carmebar/hide-future-videos
...
Add option to hide future videos in feed
2022-07-13 11:07:38 +02:00
4e285a4e70
Fix compile errors
2022-07-04 23:19:41 +02:00
085d1e0d38
Actually fix wrong view count
2022-07-01 16:07:19 +02:00
f22417e7e7
Add option to hide future videos in feed
2022-06-24 18:03:48 +02:00
8ad7bf60d7
Delete saveImmediate warnings & add comments
2022-06-23 23:31:56 +08:00
898a936064
Update index modification logic & redo sorting in the merge algorithm
2022-06-23 23:19:59 +08:00
4e401bc059
Update playlists in parallel
2022-06-23 20:36:21 +08:00
9ecef6f011
Add abstract methods in PlaylistLocalItem & rename setIsModified
2022-06-23 19:20:16 +08:00
210834fbe9
Add support of other delivery methods than progressive HTTP (in the player only)
...
Detailed changes:
- External players:
- Add a message instruction about stream selection;
- Add a message when there is no stream available for external players;
- Return now HLS, DASH and SmoothStreaming URL contents, in addition to progressive HTTP ones.
- Player:
- Support DASH, HLS and SmoothStreaming streams for videos, whether they are content URLs or the manifests themselves, in addition to progressive HTTP ones;
- Use a custom HttpDataSource to play YouTube contents, based of ExoPlayer's default one, which allows better spoofing of official clients (custom user-agent and headers (depending of the client used), use of range and rn (set dynamically by the DataSource) parameters);
- Fetch YouTube progressive contents as DASH streams, like official clients, support fully playback of livestreams which have ended recently and OTF streams;
- Use ExoPlayer's default retries count for contents on non-fatal errors (instead of Integer.MAX_VALUE for non-live contents and 5 for live contents).
- Download dialog:
- Add message about support of progressive HTTP streams only for downloading;
- Remove several duplicated code and update relevant usages;
- Support downloading of contents with an unknown media format.
- ListHelper:
- Catch NumberFormatException when trying to compare two video streams between them.
- Tests:
- Update ListHelperTest and StreamItemAdapterTest to fix breaking changes in the extractor.
- Other places:
- Fixes deprecation of changes made in the extractor;
- Improve some code related to the files changed.
- Issues fixed and/or improved with the changes:
- Seeking of PeerTube HLS streams (the duration shown was the one from the stream duration and not the one parsed, incomplete because HLS streams are fragmented MP4s with multiple sidx boxes, for which seeking is not supported by ExoPlayer) (the app now uses the HLS manifest returned for each quality, in the master playlist (not fetched and computed by the extractor));
- Crash when loading PeerTube streams with a separated audio;
- Lack of some streams on some YouTube videos (OTF streams);
- Loading times of YouTube streams, after a quality change or a playback start;
- View count of YouTube ended livestreams interpreted as watching count (this type of streams is not interpreted anymore as livestreams);
- Watchable time of YouTube ended livestreams;
- Playback of SoundCloud HLS-only tracks (which cannot be downloaded anymore because the workaround which was used is being removed by SoundCloud, so it has been removed from the extractor).
2022-06-17 22:00:22 +02:00
21d2ae709f
Merge branch 'dev' into Use_AppCompatResources
...
# Conflicts:
# app/src/main/java/org/schabi/newpipe/fragments/list/playlist/PlaylistFragment.java
2022-05-16 12:36:00 +05:30
c5e509f069
Use AppCompatResources.
2022-05-16 12:27:44 +05:30
d32490a4be
Create sub-package and default interval for DebounceSaver & sort playlists in db
2022-05-11 16:47:34 +08:00
69f95f4148
Use better way to get services
2022-05-09 20:58:10 +02:00
de4b5a8f0f
Remove not required use of supplier
...
from code review
2022-05-07 15:08:38 +02:00
7de17ad949
Icons for import/export
2022-05-07 15:08:36 +02:00
7ab11a8379
Used service icons for import
2022-05-07 15:08:36 +02:00
1d69bd48be
Moved import/export options to menu
2022-05-07 15:08:34 +02:00
59d8c570b7
Readd spaces
2022-05-05 18:04:33 +02:00
c2762d3b5e
Update LocalPlaylistFragment.java
2022-05-03 09:37:35 +08:00
01d996a5c0
Merge branch 'TeamNewPipe:dev' into dev
2022-05-03 09:26:32 +08:00
50739277c4
Update LocalPlaylistFragment.java
2022-05-03 09:21:43 +08:00
8ea98b64aa
fix issue #7563
2022-04-17 22:23:03 +08:00
6526ff1612
Add tests
2022-04-17 20:20:20 +08:00
bb5390d63a
Reuse DebounceSaver
2022-04-17 14:53:02 +08:00
1dc146322c
Merged ``DrawableResolver`` into ``ThemeHelper``
2022-04-16 21:21:57 +02:00
44dada9e60
Use better Kotlin syntax
...
From the PR review
2022-04-16 21:21:54 +02:00
4b06536582
Reworked switching to semitones
...
Using an expandable Tab-like component instead of a combobox
2022-04-16 21:21:51 +02:00
bd1aae8d66
Fix sonar warning
2022-04-16 12:44:24 +08:00
c24aed054f
Fix sonar warning and typo
2022-04-16 12:00:02 +08:00
0aa08a5e40
Use new item holder
2022-04-15 23:19:24 +08:00
3c48825699
Debounced saver & bugfix & clean code
2022-04-15 20:44:54 +08:00
bfb56b4144
UI design and behavior
2022-04-14 16:59:52 +08:00
ba8370bcfd
Save changes to the database and bugfix
2022-04-14 12:13:42 +08:00
813f55152a
Merge branch 'TeamNewPipe:dev' into feature-7870
2022-04-13 22:48:26 +08:00
c34549a47d
Update database migrations and getter/setter
2022-04-13 21:35:38 +08:00
638f227b51
Use newInstance in PlaylistDialog
2022-04-04 13:50:27 +08:00
6e8c9f92cb
Merge branch 'dev' into pr2335
2022-03-19 22:29:10 +01:00
3d9d25df52
Remove backoff criteria: it never kicked in
...
It never kicked in since we are never returning a retry() Result, but always either success() or failure() (see createWork() function). Also, there is already a default (exponential backoff starting from 30 seconds), so no need to override it.
2022-03-19 21:55:00 +01:00
70d9a77e9b
Merge pull request #8073 from Stypox/bump-checkstyle
...
Update checkstyle to 10.0 and fix various related issues
2022-03-19 14:37:52 +01:00
53f8415e9b
Use @SuppressWarnings for checkstyle suppressions & warnings
...
It's better to use @SuppressWarnings instead of the suppressions file, so that the warning suppression is at the place where it acts.
2022-03-18 23:57:11 +01:00
cf213affa2
Annotate some NonNulls, some lint cleaning
2022-03-18 13:15:44 -04:00
5f16e4ef87
Replace R.string.yes with R.string.ok
...
Android doesn't use yes/no but ok/cancel usually, so this should be done here, too
2022-03-02 12:21:25 +01:00
678edb1846
Update ktlint to 0.44.0
2022-02-26 16:08:10 -05:00
37517c7dd1
Merge pull request #7570 from TeamNewPipe/improvement/infoItemDialogBuilder
...
Refactor generating InfoItemDialog's
2022-02-26 16:18:39 +01:00
5fea12d8eb
Small code improvements
...
Removed some non-translatable strings and just hardcoded them in the code, like it's being done for other string separators. This also deduplicates some code by using Localization.
Used some Kotlin feature to reduce code.
2022-02-26 10:40:24 +01:00
277f21d5b2
Move Classes related to InfoItemDIalog into own package
2022-02-20 20:17:04 +01:00
fd0d76e866
Apply feedback
...
Return this in InfoIrtemDialog.Builder methoods.
Move null checks for InfoIrtemDialog.Builder into constructor.
Fix and add some more docs.
2022-02-20 20:17:04 +01:00
646d8f431c
Use identical method names for creating the InfoItemDialog in Fragments
2022-02-20 20:17:04 +01:00
962fe9c36d
Use Context instead of Activity
...
Improve docs
2022-02-20 20:17:04 +01:00
50e2385e82
Add default entries automatically
2022-02-20 20:17:04 +01:00
1cd3ef5dba
Extract entries into beginning and end category
2022-02-20 20:17:04 +01:00
80157fc1be
Refactor generating InfoItemDialog's
...
This commit refactors the way `InfoItemDialog`s are generated. This is necessary because the old way used the `StreamDialogEntry` enum for most of the dialogs' content generation process. This required static variables and methods to store the entries which are used for the dialog to be build (See e.g.`enabledEntries` and methods like `generateCommands()`). In other words, `StreamDialogEntry` wasn't an enumeration anymore.
To address this issue, a `Builder` is introduced for the `InfoItemDialog`'s genration. The builder also comes with some default entries and and a specific order. Both can be used, but are not enforced.
A second problem that introduced a structure which was atypical for an enumeration was the usage of non-final attributes within `StreamDialogEntry` instances. These were needed, because the default actions needed to overriden in some cases.
To address this problem, the `StreamDialogEntry` enumeration was renamed to `StreamDialogDefaultEntry` and a new `StreamDialogEntry` class is used instead.
2022-02-20 20:17:04 +01:00
62abfa96b8
Solve Java warning "Raw use of parameterized class"
2022-02-19 17:30:38 +01:00
ff8e44e4f3
Merge branch 'dev' into feature/notifications
2022-02-19 12:34:44 +01:00
71c5aaa11e
Do not show enqueue button if play queue not ready
2022-01-27 17:11:16 +01:00
d5cfcb28fc
Merge branch 'dev' into pr2335
2022-01-24 10:25:07 +01:00
40ea51e622
Add more checking frequencies, use DurationListPreference
2022-01-24 10:12:25 +01:00
402990dd9d
Fix false warning
2022-01-18 07:40:59 +03:00
ccbc3af964
Show error notification when new streams notifications failed
2021-12-31 20:04:56 +01:00
cd95ec4e12
Merge branch 'dev' into pr2335
2021-12-31 19:20:18 +01:00
fcd2d63df4
Don't show any channel notification thumbnail if it could not be loaded
2021-12-31 18:38:35 +01:00
e68d49e7df
Do not fetch all streams when disabling notifications for a channel
2021-12-31 18:34:02 +01:00
37b8a9375f
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
b21d231e3a
Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found
...
Show an alert-dialog when no appropriate file-manager was found
2021-12-14 20:01:02 +01:00
4058277b7a
Merge pull request #7482 from TeamNewPipe/unify-error-reporting
...
Unify error reporting and add error notification
2021-12-14 19:58:41 +01:00
dd9772cde2
Merge pull request #7491 from Stypox/fix-search-order
...
Fix order of local search results
2021-12-14 09:07:17 -05:00
01f3ed0e5e
Fix loading icon in streams notifications
2021-12-12 20:18:16 +01:00
19fd7bc37e
Reduce power consumption
...
Only schedule the chek for new streams if the user enaled the check. Cancel the worker when the user disables the notifications.
2021-12-10 23:52:37 +01:00
8a5e2ffa57
Fix order of local search results
2021-12-08 13:59:32 +01:00
3ade2bb6ec
Merge remote-tracking branch 'origin/dev' into notifications
2021-12-07 17:29:37 +01:00
75db002369
Update ktlint to 0.43.2
2021-12-04 21:22:29 -05:00
397f93b079
Prevent exception from being serialized in ErrorInfo
...
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
2021-12-04 10:36:36 +01:00
81f740d409
Replace ErrorActivity with ErrorUtil
2021-12-04 10:36:36 +01:00
fd1155928e
Fix deciding which streams are new
2021-11-30 23:31:44 +01:00
a8fe2d7e83
Fix "unsage use" warnings
2021-11-28 17:09:20 +01:00
b2323859e5
Refactoring + deduplicated code
2021-11-28 14:07:45 +01:00
68e7fcf8ee
Fixed typos
2021-11-27 23:39:17 +01:00
f78983b16b
Show an alert/dialog when no appropriate file-manager was found
2021-11-27 15:52:54 +01:00
6cd25d7e55
Merge pull request #7412 from litetex/code-cleanup
...
Some code cleanup(s)
2021-11-23 08:59:34 +01:00
8ce996e065
Only check for new streams of subscriptions with enabled notifications automatically
2021-11-21 22:53:10 +01:00
892a1df280
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-11-21 22:15:09 +01:00
7638d229c0
Fixed typo
2021-11-15 20:24:40 +01:00
a641c5bb58
Update Groupie to 2.9.0
2021-11-15 20:24:39 +01:00
1e0c9f46ad
Improved highlighting in FeedFragment
...
Now keeps the ``selectableItemBackground`` when highligthing an item.
2021-11-15 20:22:23 +01:00
4eb02f584e
Fixed default visibility of "new feed items" button
...
Fixed/Avoid NPEs
2021-11-15 20:22:22 +01:00
700c1b4b25
Removed unnecessary layout
...
Moved the feed button up a bit
2021-11-15 20:22:21 +01:00
4b4337e078
Used more understandable kotlin methods
2021-11-15 20:22:20 +01:00
38ce800685
Fixed feed when animations are off
...
Introduced a check if corresponding animations on the devices are enabled
2021-11-15 20:22:20 +01:00
2310e8c1d6
Made ``hideNewItemsLoaded`` more null safe
2021-11-15 20:22:19 +01:00
1b2b3a4f88
Make new feed items bold
2021-11-15 20:22:18 +01:00
02789122a0
Implemented UI highlighting and "new feed items"-notification
...
Fixed format
2021-11-15 20:22:17 +01:00
676bc02d52
No more reaction to unnecessary feed db-changes
...
This caused duplicate events (https://github.com/TeamNewPipe/NewPipe/pull/6686#issuecomment-909575283 ) and unnecessary processing of items
2021-11-15 20:21:23 +01:00
9e44053e22
Merge pull request #7160 from nschulzke/mark-as-watched-everywhere
...
Enable Mark as Watched in all the other playlist fragments.
2021-11-13 20:37:59 +01:00
dee32c3dc5
Factor out shouldAddMarkAsWatched as a shared function
2021-11-13 10:18:17 -07:00
adf9badbf6
Fixed toggle not in sync with list after app restart + refactored the code a bit
2021-11-11 19:46:15 +01:00
c35fe4f3f1
moved preference key from viewmodel to settings_keys.xml
2021-11-10 16:16:17 -05:00
63291f8101
added show watched items toggle preference
...
default sharedpreference is used to persist and retrieve show watched menu option toggle state
2021-11-07 23:11:10 -05:00
272be36dd9
Removed ``e.printStacktrace`` and used an proper logger
2021-11-05 18:04:49 +01:00
1289b1a283
Code cleanup
2021-11-05 13:17:33 +01:00
f0112a2de2
Added some lines to improve code-readability
2021-11-02 23:36:46 +01:00
58418bcf46
Improved code readability
2021-11-02 22:57:31 +01:00
1130aba7ca
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-11-02 07:56:09 +01:00
2d2b96420f
Add comments and improve code formatting
2021-10-25 15:06:18 +02:00
Samuel Wu
Stypox
Jfax510
Tobi
Isira Seneviratne
litetex
Carlos Melero
GGAutomaton
AudricV
LingYinTianMeng
LingYinTianMeng
TacoTheDank
mhmdanas
XiangRongLin
Nathan Schulzke
Baji Shaik