402990dd9d
Fix false warning
2022-01-18 07:40:59 +03:00
41faf70da1
Workaround: Set recovery before switching player
...
Quick fix
2022-01-17 20:52:07 +01:00
15e3b6301c
Merge pull request #7662 from TiA4f8R/fix-npe-share-button-playlists
...
Fix crash when sharing a playlist which is loading
2022-01-16 19:47:55 +01:00
5b9c28b93b
Replace JUnit asserts with AssertJ in HistoryRecordManagerTest ( #7654 )
...
* Replace JUnit asserts with AssertJ in HistoryRecordManagerTest
They provide a wider range of assertions, which allow for more detailed error messages.
Also convert SearchHistoryEntry to kotlin data class for better error messages, since toString() is implemented.
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-01-16 09:10:45 +01:00
6672169707
Fix NullPointerException when sharing a playlist which is loading
...
Prevent a NullPointerException by adding a null check for currentInfo when sharing a playlist.
2022-01-15 21:19:04 +01:00
7907182e7e
Merge pull request #7036 from Douile/fix/queue-metadata
...
Load full stream info when enqueuing a stream
2022-01-07 21:57:30 +01:00
cc34734131
Refactored ``initNotificationChannels``
2022-01-05 15:48:46 +01:00
6dcde96f85
Fixed some Sonarlint warnings
2022-01-05 15:31:55 +01:00
064242d962
Remove unecessary interface InfoCallback
...
Co-authored-by: Stypox <stypox@pm.me>
Replace the unecessary callback interface InfoCallback in favour of the
standard type Consumer<SinglePlayQueue>
2022-01-03 17:52:27 +00:00
ddcbe27fd3
Fixed search not accepting key input after closing player overlay ( #7607 )
...
* Fixed search not accepting key input after closing player overlay
* Made comments easier to understand
* More comments
2022-01-03 11:52:08 +01:00
ccbc3af964
Show error notification when new streams notifications failed
2021-12-31 20:04:56 +01:00
cd95ec4e12
Merge branch 'dev' into pr2335
2021-12-31 19:20:18 +01:00
fcd2d63df4
Don't show any channel notification thumbnail if it could not be loaded
2021-12-31 18:38:35 +01:00
e68d49e7df
Do not fetch all streams when disabling notifications for a channel
2021-12-31 18:34:02 +01:00
ee19ea66b3
Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud
...
Add Already playing in background toast
2021-12-31 14:54:05 +01:00
6b490ee547
Merge pull request #7582 from Jaspann/sub-channel-tumbnail-view-fix
...
Fixes view of sub-channel icon when not in use
2021-12-31 14:52:32 +01:00
558c9147a2
Move sub icon visibility line
2021-12-28 15:54:36 -05:00
fc0e709817
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00
b67bf16d4f
Minified code
2021-12-26 23:57:54 +01:00
fb3be544ce
Fixed code styling
2021-12-26 00:12:48 -05:00
53f5741317
Fixes view of sub-channel icon when not in use
2021-12-25 18:10:05 -05:00
5134080f87
Merge branch 'TeamNewPipe:dev' into dev
2021-12-25 15:14:24 +01:00
07015973d2
Added ability to see pinned comment
2021-12-24 11:29:34 -06:00
215880207e
Merge pull request #7562 from TeamNewPipe/code-quality
...
Small improvements to code quality and readability
2021-12-23 23:54:29 +01:00
989bcbf895
Add Already playing in background toast
2021-12-23 22:12:38 +01:00
3e44856d01
Merge branch 'TeamNewPipe:dev' into dev
2021-12-23 15:44:09 +01:00
05370dbb94
Merge pull request #7556 from Jaspann/improve-hashtags
...
Fixes hashtags that use non-English characters.
2021-12-23 11:45:52 +01:00
f6cad2d9cf
Merge pull request #7555 from litetex/remove-mediaparser
...
Remove/Revert MediaParser support (Android 11+) due to bugs
2021-12-22 17:32:28 +01:00
37b8a9375f
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
d71af9a625
Introduce constants for some Strings that indicate no data in Tab class
2021-12-21 20:53:17 +01:00
a163d5461d
Make PlayerHolder.bound private
2021-12-21 20:51:18 +01:00
5514616372
Change pitch by semitones
2021-12-21 18:17:48 +01:00
a274baf5cd
Adds comment to HASHTAGS_PATTERN
2021-12-20 14:13:40 -05:00
361760be0a
Allows multilingual support in hashtags
2021-12-19 20:33:55 -05:00
eea2768633
Removed/Reverted MediaParser support (Android 11+) due to bugs
2021-12-19 20:16:10 +01:00
d3562c70f5
Merge pull request #7451 from Cheechaii/respect-cutout-in-multiwindow
...
Respect cutouts when playing in MultiWindow
2021-12-19 13:23:28 +01:00
b21d231e3a
Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found
...
Show an alert-dialog when no appropriate file-manager was found
2021-12-14 20:01:02 +01:00
4058277b7a
Merge pull request #7482 from TeamNewPipe/unify-error-reporting
...
Unify error reporting and add error notification
2021-12-14 19:58:41 +01:00
dd9772cde2
Merge pull request #7491 from Stypox/fix-search-order
...
Fix order of local search results
2021-12-14 09:07:17 -05:00
01f3ed0e5e
Fix loading icon in streams notifications
2021-12-12 20:18:16 +01:00
b056faa97f
Merge pull request #7500 from TacoTheDank/bumpKtlint
...
Bump ktlint, Checkstyle, Java version
2021-12-12 15:07:24 +01:00
3ff00ff50e
Fix lambda code formatting
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 13:04:32 +00:00
baee915db5
Remove unecessary line
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 12:51:01 +00:00
19fd7bc37e
Reduce power consumption
...
Only schedule the chek for new streams if the user enaled the check. Cancel the worker when the user disables the notifications.
2021-12-10 23:52:37 +01:00
c92a90749e
Respect cutouts when playing in MultiWindow
2021-12-09 20:58:05 +01:00
e806f8c4e6
Android 10+ only allows SAF -> Respect that in the dialog
2021-12-08 20:22:26 +01:00
8a5e2ffa57
Fix order of local search results
2021-12-08 13:59:32 +01:00
bb49b1cfb1
Add javadoc to ErrorUtil and ErrorActivity
2021-12-07 18:14:53 +01:00
3ade2bb6ec
Merge remote-tracking branch 'origin/dev' into notifications
2021-12-07 17:29:37 +01:00
75db002369
Update ktlint to 0.43.2
2021-12-04 21:22:29 -05:00
41a0dc1abd
Disable media tunneling on Philips QM16XE
2021-12-04 22:23:09 +01:00
950956ebf2
Also show a toast on error notification
...
since the notification is silent, also show a toast, otherwise the user is confused
2021-12-04 10:50:27 +01:00
c8e2ab4c83
Remove PlayerErrorHandler and correctly set ErrorInfo msg
2021-12-04 10:36:36 +01:00
397f93b079
Prevent exception from being serialized in ErrorInfo
...
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
2021-12-04 10:36:36 +01:00
09d137f740
Add PendingIntent to ErrorUtil.createNotification
2021-12-04 10:36:36 +01:00
81f740d409
Replace ErrorActivity with ErrorUtil
2021-12-04 10:36:36 +01:00
1d2642f1e3
Create ErrorUtil class with three ways to report errors
...
Activity, snackbar and notification
2021-12-04 10:36:31 +01:00
7cd3603bbb
Fetch sparse items when playing in background or popup
2021-12-03 22:38:03 +00:00
ec7de2a6dc
Fix StreamType check, missing import, and styling errors
2021-12-03 21:53:36 +00:00
3d1a3606c9
Remove unused variable
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-03 21:30:26 +00:00
6472e9b6b6
Remove unused code
2021-12-03 21:29:34 +00:00
fd1155928e
Fix deciding which streams are new
2021-11-30 23:31:44 +01:00
744cfe5672
Removed unused import
2021-11-29 21:13:22 +01:00
17724a901c
Removed annotations due to wrong warnings
2021-11-29 21:03:59 +01:00
a8fe2d7e83
Fix "unsage use" warnings
2021-11-28 17:09:20 +01:00
b2323859e5
Refactoring + deduplicated code
2021-11-28 14:07:45 +01:00
4c8dca5300
Fixed NPE + Problems with context
2021-11-28 13:42:26 +01:00
68e7fcf8ee
Fixed typos
2021-11-27 23:39:17 +01:00
f78983b16b
Show an alert/dialog when no appropriate file-manager was found
2021-11-27 15:52:54 +01:00
2f99a217c3
Fixed build
2021-11-23 20:21:59 +01:00
0d51eefbb9
Refactoring
2021-11-23 20:12:16 +01:00
aa28a85747
Added a workaround for not serializable exceptions
2021-11-23 20:12:14 +01:00
f18ee8e83d
Added a bit more documentation
2021-11-23 20:12:13 +01:00
fb58967766
PlayerErrorHandler refactor + docs
2021-11-23 20:12:12 +01:00
e5c00a7ef4
Added some doc
2021-11-23 20:12:10 +01:00
769791af7a
Added a "Crash the player" debug option
2021-11-23 20:12:09 +01:00
e632fab4d0
Added option to report player errors
...
* Added a new setting so that player errors are reported (under Video and Audio > Player)
* Moved the player error logic to separate class specially created for this purpose
2021-11-23 20:12:07 +01:00
91611fcae4
Don't fetch uneeded stream info for live streams
...
Co-authored-by: Stypox <stypox@pm.me>
2021-11-23 15:22:11 +00:00
6cd25d7e55
Merge pull request #7412 from litetex/code-cleanup
...
Some code cleanup(s)
2021-11-23 08:59:34 +01:00
c9488eb042
Removed useless lines
2021-11-22 19:49:52 +01:00
8ce996e065
Only check for new streams of subscriptions with enabled notifications automatically
2021-11-21 22:53:10 +01:00
892a1df280
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-11-21 22:15:09 +01:00
c8516a04dc
Formatted code
2021-11-21 19:56:50 +01:00
02d1b98b1c
Removed useless doc
2021-11-21 19:46:11 +01:00
d8236bbedd
Merge pull request #7406 from Redirion/usedefaultloadcontrol
...
Use DefaultLoadcontrol
2021-11-21 15:11:21 +01:00
bd9dcfb28a
Merge pull request #7381 from litetex/prevent-automatic-replay-after-returning-from-background
...
Prevent automatic replay after returning from background
2021-11-17 09:38:09 +01:00
d5199eac3e
Merge pull request #7050 from litetex/feed-refactor-new-items-handling
...
Rework feed new items handling
2021-11-15 23:20:07 +01:00
7638d229c0
Fixed typo
2021-11-15 20:24:40 +01:00
a641c5bb58
Update Groupie to 2.9.0
2021-11-15 20:24:39 +01:00
1e0c9f46ad
Improved highlighting in FeedFragment
...
Now keeps the ``selectableItemBackground`` when highligthing an item.
2021-11-15 20:22:23 +01:00
4eb02f584e
Fixed default visibility of "new feed items" button
...
Fixed/Avoid NPEs
2021-11-15 20:22:22 +01:00
700c1b4b25
Removed unnecessary layout
...
Moved the feed button up a bit
2021-11-15 20:22:21 +01:00
4b4337e078
Used more understandable kotlin methods
2021-11-15 20:22:20 +01:00
38ce800685
Fixed feed when animations are off
...
Introduced a check if corresponding animations on the devices are enabled
2021-11-15 20:22:20 +01:00
2310e8c1d6
Made ``hideNewItemsLoaded`` more null safe
2021-11-15 20:22:19 +01:00
1b2b3a4f88
Make new feed items bold
2021-11-15 20:22:18 +01:00
d11129a76b
Fixed StackOverflow
2021-11-15 20:22:17 +01:00
02789122a0
Implemented UI highlighting and "new feed items"-notification
...
Fixed format
2021-11-15 20:22:17 +01:00
676bc02d52
No more reaction to unnecessary feed db-changes
...
This caused duplicate events (https://github.com/TeamNewPipe/NewPipe/pull/6686#issuecomment-909575283 ) and unnecessary processing of items
2021-11-15 20:21:23 +01:00
8b807b0706
Enhanced ``View.slideUp``
2021-11-15 20:21:21 +01:00
316db0e4c6
setRecovery: Remove checks and use Math.min/max
2021-11-15 19:56:14 +01:00
010c607e40
Prevent automatic replay after returning from background
...
See also https://github.com/TeamNewPipe/NewPipe/pull/7195#issuecomment-962624380
2021-11-15 19:47:08 +01:00
3e099fb2a3
Fixed Period Transition
2021-11-14 21:19:36 +01:00
9c9730b152
Use DefaultLoadcontrol
2021-11-14 20:12:12 +01:00
9e44053e22
Merge pull request #7160 from nschulzke/mark-as-watched-everywhere
...
Enable Mark as Watched in all the other playlist fragments.
2021-11-13 20:37:59 +01:00
dee32c3dc5
Factor out shouldAddMarkAsWatched as a shared function
2021-11-13 10:18:17 -07:00
344fbff59a
Merge pull request #7363 from litetex/playback-speed-ctrls-simple-landscape-improvements
...
Simple playback-speed-controls improvements
2021-11-12 21:19:17 +01:00
48a1ab64b0
Refactored ``PlaybackResolver``
...
* fixes the deprecation of ``setTag``
* makes the code more consistent
* de-duplicates some code
2021-11-12 20:14:39 +01:00
dd2cde3c1a
De-duplicated PlayerDataSource-code
2021-11-12 19:40:00 +01:00
1b9c2b37c5
Use Android11+ extractors
2021-11-12 19:17:52 +01:00
eae1f8b597
Update ExoPlayer to 2.14.2
2021-11-12 19:17:51 +01:00
adf9badbf6
Fixed toggle not in sync with list after app restart + refactored the code a bit
2021-11-11 19:46:15 +01:00
c35fe4f3f1
moved preference key from viewmodel to settings_keys.xml
2021-11-10 16:16:17 -05:00
63291f8101
added show watched items toggle preference
...
default sharedpreference is used to persist and retrieve show watched menu option toggle state
2021-11-07 23:11:10 -05:00
62efb588ef
Removed obvious title from the "Playback Speed Controls"
2021-11-07 13:51:43 +01:00
203ca9afc6
Removed unused imports
2021-11-06 21:07:00 +01:00
a23f941ac8
Simplified some code and added some comments
2021-11-05 19:07:56 +01:00
b0a10f0542
Merged extremely similar code together / parity between video and popup player
...
* Removed ``player.getPlayPauseButton().requestFocus();`` as there is no reason why it was introduced there documented
* Use the same delay to hide the controls on both players
2021-11-05 18:10:55 +01:00
478ad42977
De-Duplicated some code
2021-11-05 18:07:21 +01:00
0764983ac6
Why log double?
2021-11-05 18:06:32 +01:00
2b2f1ee8f5
Added some doc
2021-11-05 18:06:10 +01:00
28f167fd99
Removed dead code
2021-11-05 18:04:57 +01:00
272be36dd9
Removed ``e.printStacktrace`` and used an proper logger
2021-11-05 18:04:49 +01:00
7b4e5dd107
Reworked player-notfication
...
* Fixed ``release`` ``main_settings.xml``
* Renamed "Notification" to "Player-Notification" (also reset all translations)
2021-11-05 14:10:53 +01:00
1289b1a283
Code cleanup
2021-11-05 13:17:33 +01:00
f933db8117
Added a custom title
...
to also save some margin/padding/etc
2021-11-04 19:47:08 +01:00
2e862b4ccc
Merge pull request #6844 from 0x416c6578/shuffle-mode-ui-fix
...
Fixed shuffle button opacity UI bug
2021-11-03 18:18:31 +01:00
ecac897e7b
Fixed typo
2021-11-03 17:30:30 +01:00
2934841152
Enable play/pause with space key even when not in fullscreen player
2021-11-03 08:26:13 +08:00
f0112a2de2
Added some lines to improve code-readability
2021-11-02 23:36:46 +01:00
94219b78e7
Fixed typos
2021-11-02 23:22:59 +01:00
0f4b6d7d9f
Improved code readablity
2021-11-02 23:22:52 +01:00
58418bcf46
Improved code readability
2021-11-02 22:57:31 +01:00
e4cd52060c
Reformatted code so that it's better readable
2021-11-02 22:48:49 +01:00
1130aba7ca
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-11-02 07:56:09 +01:00
c0f7b123a3
Merge pull request #7296 from vhouriet/vhouriet_feature_issue6049
...
Add "Check for updates" button in update settings
2021-11-01 23:17:25 +01:00
34ab93c9bd
Fix player controls not hiding if resumed from media button
2021-11-01 11:50:33 +08:00
bc2f0f9f3e
Update stream state in database after loading
2021-10-28 01:11:53 +01:00
e9e2afa61a
Merge pull request #7061 from TiA4f8R/custom-textview-edittext
...
Use custom TextViews and EditTexts in all XML resources
2021-10-27 20:47:15 +02:00
403154b2e1
Less indents and code -> better readable
...
Also removed a useless variable
2021-10-26 20:47:15 +02:00
e5fd24b0d1
Make naming great again
...
When we build APKs in PRs it's also a GITHUB_APK...
2021-10-26 20:47:14 +02:00
8dc34274a1
Removed dead code
2021-10-26 20:47:13 +02:00
467bd21de2
Cleanup up some code
2021-10-26 20:47:13 +02:00
5c9705d94e
Change check for updates button to trigger a version check
2021-10-26 20:47:12 +02:00
85fb5827aa
Add Check for updates button
2021-10-26 20:47:11 +02:00
2d2b96420f
Add comments and improve code formatting
2021-10-25 15:06:18 +02:00
77aaa15082
Fix toggling the system's settings for app notification
...
Do not open the setting for a specific notification channel (Settings.ACTION_CHANNEL_NOTIFICATION_SETTINGS), but the settings for all notifications by the app (Settings.ACTION_APP_NOTIFICATION_SETTINGS)
2021-10-25 13:59:55 +02:00
7067deb328
Merge pull request #7261 from TacoTheDank/bumpRecyclerView
...
Update RecyclerView & Groupie libraries
2021-10-24 21:22:04 +02:00
af936bc646
Always create a backup list when shuffling
...
The backup-list has to be created at all cost (even when current list size <= 2). Otherwise it's not possible to enter shuffle-mode (as ``isShuffled()`` always returns false)!
2021-10-23 17:35:42 +02:00
d66f933c69
Fixing the shuffle button on the UI is enough.
...
No need for doing the heavier method ``onShuffleModeEnabledChanged(false);``
2021-10-23 16:46:56 +02:00
cf81c37683
Removed changes to the intent handler
2021-10-23 16:43:29 +02:00
d2306b0fd7
Fixed shuffle button opacity bug
...
Parameterised shuffle state into initPlayback for potentially passing the shuffle state into the player in the future
2021-10-23 16:43:28 +02:00
80bf47493e
Fix check wether the app's notifications are disabled via system settings
...
Add comments
Rename a few methods
2021-10-22 21:24:43 +02:00
44cad27d0a
Merge pull request #7268 from TeamNewPipe/release/0.21.13
...
Release 0.21.13
- Fix playback resume
- Ensure that the service for new version checks is not started in background
2021-10-21 20:51:01 +02:00
768bb0bbcd
Start service for update checks in onPastCreate()
2021-10-20 23:55:18 +02:00
ac071b383f
Revert part of #6872 and fix playback resuming
2021-10-20 23:20:26 +02:00
e0b1a6b88b
Merge pull request #7149 from TacoTheDank/updateFragWorkaround
...
Update pager workaround code to Fragment 1.3.6
2021-10-20 19:44:35 +02:00
ed86b1c572
Update pager workaround to Fragment 1.3.6
2021-10-19 17:39:38 -04:00
b6b19b474e
Update RecyclerView & Groupie
2021-10-19 17:31:59 -04:00
7d4c7718aa
comments & rename
2021-10-18 13:11:50 +02:00
28c72e7f63
Fix new version check still occassionally started in background
2021-10-17 12:55:06 +02:00
5fcc3b4dab
[Player] Fix resuming playback
...
This was caused by #6872
2021-10-17 12:13:38 +02:00
51837ce36f
Get rid of setUserVisibleHint
2021-10-16 15:33:45 -04:00
ddaafb68c8
Adress new requested changes
2021-10-16 15:32:56 +02:00
a744775fe7
Adress requested changes and remove an unused return value in NewPipeTextViewHelper
2021-10-16 13:41:05 +02:00
50b85a7734
Simplify code
2021-10-16 13:41:05 +02:00
aab09c0c65
Merge the Share process of the two classes into one
...
A new class has been added in the util package: NewPipeTextViewHelper.
It shares the selected text of a TextView with ShareUtils#shareText (with the created shareSelectedTextWithShareUtils static method).
Only this static method can be used by other classes, other methods are private.
2021-10-16 13:41:04 +02:00
3ded6feddb
Improve code of created views
...
Use the same logic as Android TextViews
2021-10-16 13:41:04 +02:00
c8802fe5d0
Add JavaDocs on created views
2021-10-16 13:41:04 +02:00
411b3129f9
Use a custom EditText everywhere to be able to share with ShareUtils the selected text
...
This EditText class extends the AppCompatEditText class from androidx.
These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:41:03 +02:00
a55acd38df
Use a custom TextView everywhere to be able to share with ShareUtils the selected text
...
This TextView class extends the AppCompatTextView class from androidx.
These changes (only in XML ressources) allow us to share the selected text by using ShareUtils.shareText, which opens the Android system chooser instead of the Huawei system chooser on EMUI devices.
2021-10-16 13:40:54 +02:00
793ff1a728
Add a few comments and rename a few methods
2021-10-15 20:57:54 +02:00
7edef8d5a2
Merge pull request #7222 from ktprograms/queue-menu-channel-details
...
Added the 'Show Channel Details' menu item to the Queue long press menu
2021-10-15 20:28:18 +02:00
4f7cdcce55
Update app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelFragment.java
...
Co-authored-by: litetex <40789489+litetex@users.noreply.github.com>
2021-10-15 20:22:12 +02:00
03d2ca9f9f
Fixed format of code
2021-10-15 20:18:52 +02:00
2271ea4281
Improved documentation
2021-10-15 20:16:34 +02:00
64a7978c7f
Rename NotificationMode.ENABLED_DEFAULT to NotificationMode.ENABLED
2021-10-15 19:59:06 +02:00
16d4a034e2
Merge remote-tracking branch 'origin/dev' into notifications
2021-10-14 21:15:43 +02:00
afc8db8f81
Add reasoning for separate openChannelFragmentUsingIntent method
2021-10-14 09:51:25 +08:00
4af49ee5a6
Merge pull request #7194 from KalleStruik/add-to-playlist-in-share
...
Add a "add to playlist" option in the share menu
2021-10-13 20:34:07 +02:00
d7b29aae5c
Merge branch 'master' into dev
2021-10-12 20:03:42 +02:00
9f7a8407ca
Merge pull request #7224 from vhouriet/vhouriet_fix_check-background-player-type
...
Check if background player already active before displaying player toast
2021-10-12 19:47:50 +02:00
54d3bff26d
Move checking for new version to MainAcitvity
...
When the service is started from the Application class, the app might be still in the background. This is definetly not the case when MainActivity.onCreate() is called.
Fixes #7227
2021-10-12 16:45:01 +02:00
55c51ad49d
Rename isStreamExist -> doesStreamExist
2021-10-11 23:20:52 +02:00
a2050a5211
Merge pull request #7215 from litetex/code-cleanup-drawer-main-activity
...
Deduplicated drawer code in MainActivity
2021-10-11 21:29:42 +02:00
e9bd2934c3
Merge pull request #7202 from vhouriet/vhouriet_bug_issue-6662
...
Fix clicking timestamp shows Toast "Playing in popup mode"
2021-10-11 21:20:26 +02:00
50634eb2b3
Check player type before displaying background player toast
2021-10-11 19:41:22 +02:00
cea14c9d0d
Merge remote-tracking branch 'origin/dev' into notifications-1
2021-10-11 16:37:49 +02:00
a2ff770afc
Added the 'Show Channel Details' menu item to the Queue long press menu
...
Created a method in NavigationHelper that opens the channel fragment using an Intent to MainActivity instead of replacing fragments.
2021-10-11 14:47:37 +08:00
658d988254
Simplify code and add annotations
2021-10-10 20:33:05 +02:00
9d7e9289bb
Fix cursor color in PlaylistCreationDialog
2021-10-10 12:32:57 +02:00
d7d87691cb
Add to playlist - Showing toast that this may take a moment
2021-10-09 18:47:36 +02:00
731640997e
Cleaned up PlaylistDialog-related code
2021-10-09 18:46:20 +02:00
64d7432852
Deduplicated drawer code in MainActivity
2021-10-09 16:37:34 +02:00
e6fffc0d5b
Fix crash on missing title when sharing livestream
2021-10-08 21:42:01 +02:00
1c9f68bcae
Fix clicking timestamp shows Toast "Playing in popup mode"
...
Fixes #6662
2021-10-05 18:15:36 +02:00
b633108a4c
Use the correct TAG in NavigationHelper
2021-10-03 22:04:34 +02:00
ceb55d0ede
Set the theme for PlaylistCreationDialog explicitly.
2021-10-03 14:25:50 +02:00
87c958b2e7
Rename the "append_playlist" string to "add_to_playlist"
2021-10-03 13:27:24 +02:00
d844e0aba6
Add a add to playlist option in the share menu.
2021-10-02 19:21:25 +02:00
4fc9f2e5fd
Merge pull request #7176 from litetex/fix-progress-bar-end-not-synced
...
Fixed seekbar not completed after video end
2021-10-02 09:24:59 +02:00
ce592f4baf
Merge pull request #6980 from bravenewpipe/check-for-update-after-toggle-and-restart
...
resets the expire date for checking for updates
2021-10-02 09:07:05 +02:00
2b3edcf2d1
Add a comment
2021-10-02 08:53:03 +02:00
672eb34049
Merge pull request #7150 from TacoTheDank/groupieBump
...
Update Groupie library to 2.9.0
2021-09-30 21:26:58 +02:00
b753705a84
Merge pull request #7178 from Redirion/dsblmdtnnelrealtekatv
...
Disable media tunneling on RealtekATV
2021-09-28 07:53:11 +02:00
f48ff610a3
Merge pull request #7166 from litetex/various-fixes-for-mediasession-player
...
Various fixes related to MediasessionManager
2021-09-27 23:45:38 +02:00
3cf94382e6
Disable media tunneling on RealtekATV
2021-09-27 13:21:04 +02:00
f52cb3bbe0
Make requested changes
2021-09-27 01:45:33 +05:30
d45182cb5c
Referenced issue in code
2021-09-26 20:58:49 +02:00
22847c6c92
Fixed progress bar not completing after video end
2021-09-26 20:50:24 +02:00
bc3139e5f9
Fix Settings import
2021-09-25 15:37:07 +05:30
72dbb9441e
Improved streamType check and documentation
2021-09-25 10:31:42 +02:00
bbc13756f3
Removed useless check for livestreams
2021-09-25 00:04:53 +02:00
ba0876b43b
Reformatted MediaSessionManager code
2021-09-24 23:55:06 +02:00
c0d41661e8
Fixed performance problems with mediaSessionManager
...
* Built on top of Redirons changes
* MediaSessionManager-Metadata get's only update when metadata changes - not every second as it only changes when the metadata changes
* Reworked mediasessionmanager
2021-09-24 23:40:12 +02:00
b2e2551e33
Two fixes for setMetadata
2021-09-24 23:28:55 +02:00
108af48b76
Enable Mark as Watched in all the other playlist fragments.
2021-09-23 21:39:47 -06:00
920695f90a
Regenerate some drawables to their latest design
2021-09-22 23:38:01 -04:00
b61d44aaa6
Update Groupie to 2.9.0
2021-09-22 19:08:03 -04:00
fb0473da39
Merge branch 'dev' of https://github.com/TeamNewPipe/NewPipe into feature/notifications
2021-09-20 07:26:01 +03:00
7e26748dc4
Merge branch 'master' into dev
2021-09-19 22:37:00 +02:00
7667b2ce59
Fix restoring orientation in onBack
2021-09-19 19:09:11 +02:00
62d36126ea
Load full stream info when enqueuing a stream
...
This commit calls getStreamInfo causing a full network fetch of stream
info (I believe only if required) when adding a stream item to the
queue. This should prevent UI issues of missing metadata when queueing
videos that have been fast-loaded and are missing metadata.
Fixes #7035
2021-09-19 00:15:56 +01:00
70354eb73e
Add play next to long press menu & refactor enqueue methods ( #6872 )
...
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings
* changed line length for checkstyle pass
* cleaned comments, moved strings
* Update app/src/main/res/values/strings.xml
to make long press entry more descriptive
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
* Update app/src/main/res/values/strings.xml
Co-authored-by: Stypox <stypox@pm.me>
* replace redundant nextOnVideoPlayer methods
Co-authored-by: Stypox <stypox@pm.me>
* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments
* removed deprecated methods
removed redundant methods
* removed deprecated methods
removed redundant methods
* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods
* now works with playlists
* renamed dialog entry
* checking for >1 items in the queue using the PlayerHolder
* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)
* corrected strings
* improve getQueueSize in PlayerHolder
* long press to enqueue only if queue isnt empty
* add Whitespace
Co-authored-by: Stypox <stypox@pm.me>
* clarify comments / add spaces
* PlayerType as parameter of the enqueueOnPlayer method
add Helper method
* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle
* assimilated the enqueue*OnPlayer methods
* removed redundant comment, variable
* simplify code line
Co-authored-by: Stypox <stypox@pm.me>
* move if
* replace workaround for isPlayerOpen()
Co-authored-by: Stypox <stypox@pm.me>
* replaced workarounds (getType), corrected static access with getInstance
* remove unused imports
* changed method call to original, new method doesnt exist yet.
* Use getter method instead of property access syntax.
* improve conditional for play next entry
Co-authored-by: Stypox <stypox@pm.me>
* show play next btn in feed fragment
Co-authored-by: Stypox <stypox@pm.me>
* add play next to local playlist and statistics fragment
Co-authored-by: Stypox <stypox@pm.me>
* formating
Co-authored-by: Stypox <stypox@pm.me>
* correcting logic
Co-authored-by: Stypox <stypox@pm.me>
* remove 2 year old unused string, formating
Co-authored-by: Stypox <stypox@pm.me>
* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.
* remove player open checks from button long press enqueue actions
* improve log msg
* Rename next to enqueue_next
* Refactor kotlin
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
2021-09-18 11:22:49 +02:00
a2887034a6
Merge pull request #7068 from litetex/fix-restart
...
Fixed restarting not working properly
2021-09-11 12:51:38 +02:00
7eb5aa1bc5
Merge pull request #7056 from TeamNewPipe/fix/playOnPopup
...
Fix handling exception in `playOnPopup` and toggle description tab
2021-09-10 18:21:41 +02:00
9d249904bd
Toggle all subscriptions notification mode
2021-09-07 13:30:26 +03:00
111dc4963d
Ignore feed update threshold when run from NotificationWorker
2021-09-07 13:30:26 +03:00
5a6d0455ec
Migrate NotificationIcon to Picasso
2021-09-07 13:30:26 +03:00
a5b9fe4c35
Refactor FeedLoadService to use it within the notification worker
2021-09-07 13:30:26 +03:00
e0c674bc9e
Move player notification settings into appearance section
2021-09-07 13:30:25 +03:00
da9bd1d420
Notifications about new streams
2021-09-07 13:30:16 +03:00
892b4a15f6
Change player progress bar update from 500 ms to 1 s
...
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062 , this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
2021-09-07 00:04:05 +02:00
fda0a550fd
Fixed the app restarting not working properly
...
* Using [``process-phoenix``](https://github.com/JakeWharton/ProcessPhoenix )
2021-09-06 20:47:44 +02:00
4d51ebc37a
Fix a few SonarLint warnings
2021-09-05 19:54:28 +02:00
433c6dc33b
Fix OnErrorNotImplementedException in SearchFragment.initSuggestionObserver()
...
Hopefully also fix the cause of the original error.
2021-09-05 19:54:28 +02:00
ed4fdadd4d
Fix OnErrorNotImplementedException in playOnPopup
2021-09-05 19:54:28 +02:00
298e96b821
Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment
...
The comments tab was updated although the settings for the description tab were changed.
2021-09-04 22:36:47 +02:00
8dd617fc6b
Merge pull request #7043 from Stypox/optimize-resources
...
Remove unused resources
2021-09-04 20:57:07 +02:00
3a09039b93
Remove unused resources
2021-09-02 21:13:54 +02:00
669a35bc78
check immediately for updates if user enables 'check for updates setting'
...
- Convert CheckForNewAppVersion to IntentService
- reset expire date to 0 after user enables check for updates setting
2021-09-02 07:20:35 +02:00
ed408b2094
Move fullscreen-related comments to javadocs
2021-09-01 20:13:27 +02:00
3bc661f583
Fix null pointer exception in player initialization
2021-09-01 20:13:27 +02:00
cf9b482be2
Completely close player when changing stream w/o autoplay
2021-09-01 20:13:27 +02:00
1d935b46f9
Open fullscreen when switching from popup to main player
2021-09-01 20:13:24 +02:00
520ac2e935
Fix bottom sheet state after automatic fullscreen
2021-09-01 20:12:14 +02:00
c6316abbce
Fix opening directly fullscreen on tablets
2021-09-01 20:12:09 +02:00
2dfe837c35
Extract isLandscape and isInMultiWindow to DeviceUtils
2021-09-01 20:09:08 +02:00
3c2ea7697c
Add option to directly open fullscreen when the main player starts
2021-09-01 20:08:37 +02:00
faa7a91764
Merge pull request #7004 from litetex/fix-showTextError-and-rework-ErrorPanel
...
Reworked the ErrorPanel
2021-08-31 18:26:51 +02:00
f629a4d206
Merge pull request #6993 from Redirion/closeaudioeffectsession
...
Close audio effect control session properly
2021-08-31 12:37:20 +02:00
4b7c37e919
Merge pull request #6955 from ktprograms/queue-long-press-menu
...
Show popup menu when long pressing in play queue (Full screen player)
2021-08-31 12:22:59 +02:00
f8f2dfce4b
Merge pull request #6882 from talanc/dev
...
Add support for CSV+ZIP subscriptions (Google Takeout)
2021-08-31 12:10:12 +02:00
5284072b8d
Improve mime type deduction on subscription import
2021-08-31 12:07:34 +02:00
e603dddc54
Added support for CSV+ZIP subscriptions
...
Updated import instructions string
2021-08-31 12:07:34 +02:00
a555aab3e7
Merge pull request #7024 from Stypox/string-fixes
...
Never use ``android.R.string``s; remove unused ``add`` string
2021-08-31 12:00:07 +02:00
88f1c3a808
Merge pull request #6985 from litetex/set-seekbarjump-when-using-dpad-to-seek-duration-from-preferences
...
Set ``KeyProgressIncrement`` manually / Fix long seekbar jumps when using a DPad
2021-08-30 23:36:29 +02:00
0e6668636d
Merge pull request #6986 from litetex/fix-build-problems-update-kotlin
...
Fix build problems and updated kotlin
2021-08-30 21:20:45 +02:00
cfdcb92fa3
Always use our strings, not android ones
2021-08-30 16:37:01 +02:00
039bd5d413
Rename string finish to ok, as its content was "OK"
2021-08-30 16:36:57 +02:00
57ca281c80
Merge pull request #6634 from Isira-Seneviratne/Use_PackageInfoCompat
...
Use PackageInfoCompat.getSignatures().
2021-08-29 23:13:12 +02:00
703f1550d8
Fixed double tapping the replay button
2021-08-29 17:53:09 +02:00
8bfd380b89
Merge pull request #6515 from Redirion/buffersharmonization
...
Use ExoPlayer default values for buffers
2021-08-29 17:44:43 +02:00
43e91ae4ae
Added plural forms for download related strings ( #6930 )
...
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2021-08-29 13:28:01 +02:00
d931d058d9
Reworked the ErrorPanel
...
* All element on the error panel are now hidden by default (expect for the ``errorTextView``) as they are only optional shown
* Added a method to ensure the above
* This deduplicates a lot of code
* Fixed format of some LoC
* Added new method: ``showAndSetErrorButtonAction``
* Fixed ``showTextError``
* Named buttons more logically: ``errorButtonAction`` -> ``errorActionButton``
2021-08-28 17:05:12 +02:00
d9086300f3
Re-add sharing of the content name with the "Share" command ( #6957 )
...
The title of the content is re-added as the EXTRA_SUBJECT of the share intent.
2021-08-27 19:26:32 +02:00
f18a7c91ca
Suppressed warning
...
There seems to be a bug in the kotlin plugin as it tells you when building that this can't be null:
"Condition 'throwable != null' is always 'true'"
However it can indeed be null as seen in https://github.com/TeamNewPipe/NewPipe/pull/6986#issuecomment-906822218
2021-08-27 16:32:59 +02:00
43d0543b9f
close audio effect control session properly
2021-08-27 10:53:44 +02:00
0787d62254
Merge pull request #6820 from Stypox/picker-mime-type
...
Provide mime type to file picker to gray out unselectable files
2021-08-26 21:39:35 +02:00
b061423847
Changed package as the old one is deprecated
2021-08-26 18:09:27 +02:00
c6ead351c0
Set ``KeyProgressIncrement`` manually
...
* Set ``KeyProgressIncrement`` manually to the value of the seek duration in the settings so that it works when using the DPad
* consolidated code inside a new method to avoid duplication
2021-08-26 17:16:51 +02:00
a4503eb609
Remove TAG parameter, refactor method calls
2021-08-25 17:04:15 +08:00
a1cb3e59d6
Move opening popup menu to utility class
2021-08-25 09:30:40 +08:00
1b05c404d5
Remove Details option in Main Player Queue menu
2021-08-25 08:56:26 +08:00
5de455bb86
Change type of themeWrapper to ContextThemeWrapper
2021-08-25 08:56:26 +08:00
acdfee5c25
Show popup menu when long pressing in play queue (Full screen player)
2021-08-25 08:56:26 +08:00
87e7d95966
Do not show suggestions error snackbar for interrupted I/O
...
Fix formatting
2021-08-24 18:16:17 +02:00
d37ee1e0dc
First run migrations, then setDefaultValues, since the latter requires the correct types
2021-08-24 18:16:17 +02:00
1d33e7ab49
Allow choosing which types of search suggestions to show
...
local, remote, both, none
Replacing the old on-off setting
2021-08-24 18:16:16 +02:00
2027b743b4
Merge pull request #6919 from ktprograms/channel-details-all-places
...
Add Show Channel Details where it's missing
2021-08-24 16:43:21 +02:00
2928df0cc9
Fix checkstyle ParenPad error
2021-08-24 21:17:08 +08:00
44128f9145
Remove placeholder image while loading thumbnails
2021-08-24 10:56:25 +02:00
6eaff5ca6a
Apply review: move thumbnail loading out of Player
2021-08-24 10:56:25 +02:00
c0664c1cb6
Add Picasso to licences and remove Universal Image Loader
2021-08-24 10:56:25 +02:00
e229e5355d
Always create new bitmap when resizing thumbnail
...
This prevents strange crashes on some devices, fixes #4638
2021-08-24 10:56:25 +02:00
52189fc5df
Add debug setting to enable Picasso indicators
2021-08-24 10:56:25 +02:00
314964c5f9
Recycle Bitmap in transformation
2021-08-24 10:56:25 +02:00
fcef783bbb
Replace UniversalImageLoader with Picasso
2021-08-24 10:56:25 +02:00
bdbb9bead2
Merge pull request #6848 from Stypox/somali-cancel
...
Use custom cancel string everywhere
2021-08-22 22:36:14 +02:00
6fbb601802
Merge branch 'master' into dev
2021-08-22 22:22:37 +02:00
8715e7dd98
Only show "mark as watched" context menu entry when watch history is enabled
2021-08-22 22:15:05 +02:00
a209e87c69
Add Loading Channel Details Toast
2021-08-21 09:30:40 +08:00
967bdf8f08
Remove migration test, add manual testing reminder to Migrations.java
2021-08-17 08:57:03 +08:00
712985ced1
Save uploader url when adding from PlayQueueItem
2021-08-16 08:08:50 +08:00
0683dafa55
Merge pull request #6851 from litetex/make-parsing-of-timestamp-links-more-robust
...
Catch errors while processing timestamp-links
2021-08-14 21:10:20 +02:00
6f1958d398
Remove setting uploaderUrl to empty string if null
2021-08-14 20:59:38 +08:00
21bcadeecb
Make uploader_url column nullable
2021-08-14 17:48:35 +08:00
bd0427c79f
Refactor duplicated code into method
2021-08-14 17:32:38 +08:00
241054fd26
Remove hardcoded string
2021-08-14 15:38:57 +08:00
d8888e3495
Catch error from ExtractorHelper.getStreamInfo, remove blockingGet
2021-08-14 09:07:27 +08:00
mhmdanas
litetex
XiangRongLin
TiA4f8R
Stypox
Douile
Jaspann
Martin
David Kramer
Tobi
vhouriet
Robin
Cheechaii
TacoTheDank
Robin
Nathan Schulzke
Baji Shaik
ktprograms
vhouriet
0x416c6578
Kalle Struik
Laksh
Koitharu
z3r0r4
thefalsedev
evermind
talanc
Agnieszka C
acti0