hide error messages before request & show console.error not for group not found error

This commit is contained in:
Daniel Waxweiler 2022-06-09 19:15:48 +02:00
parent 5a0757092b
commit 55fcf4c756
3 changed files with 22 additions and 1 deletions

View File

@ -4,6 +4,7 @@ import browserEnv from 'browser-env'
import {
displayEvents,
displayErrorMessage,
hideErrorMessages,
showLoadingIndicator,
} from './events-displayer.js'
@ -106,3 +107,16 @@ test('#showLoadingIndicator remove events', (t) => {
showLoadingIndicator(container)
t.is(loadingIndicator.style.display, 'block')
})
test('#hideErrorMessages remove events', (t) => {
const container = t.context.container
const generalErrorMessage = container.querySelector('.general-error')
const groupNotFoundErrorMessage = container.querySelector('.group-not-found')
generalErrorMessage.style.display = 'block'
groupNotFoundErrorMessage.style.display = 'block'
t.is(generalErrorMessage.style.display, 'block')
t.is(groupNotFoundErrorMessage.style.display, 'block')
hideErrorMessages(container)
t.is(generalErrorMessage.style.display, 'none')
t.is(groupNotFoundErrorMessage.style.display, 'none')
})

View File

@ -63,7 +63,6 @@ export function displayEvents({ data, document, container }) {
export function displayErrorMessage({ data, container }) {
hideLoadingIndicator(container)
console.error(data)
if (
Object.prototype.hasOwnProperty.call(data, 'response') &&
Object.prototype.hasOwnProperty.call(data.response, 'errors') &&
@ -76,6 +75,7 @@ export function displayErrorMessage({ data, container }) {
} else {
const message = container.querySelector('.general-error')
message.style.display = 'block'
console.error(data)
}
}
@ -88,3 +88,8 @@ function hideLoadingIndicator(container) {
const indicator = container.querySelector('.loading-indicator')
indicator.style.display = 'none'
}
export function hideErrorMessages(container) {
container.querySelector('.group-not-found').style.display = 'none'
container.querySelector('.general-error').style.display = 'none'
}

View File

@ -2,6 +2,7 @@ import {
clearEventsList,
displayEvents,
displayErrorMessage,
hideErrorMessages,
showLoadingIndicator,
} from './events-displayer.js'
import * as GraphqlWrapper from './graphql-wrapper.js'
@ -22,6 +23,7 @@ export function loadEventList(container) {
const url = MOBILIZON_CONNECTOR.url + URL_SUFFIX
const limit = parseInt(container.getAttribute('data-maximum'))
const groupName = container.getAttribute('data-group-name')
hideErrorMessages(container)
clearEventsList(container)
showLoadingIndicator(container)
if (groupName) {