Merge pull request #9 from comatory/improvement-add-code-split-when-fetching-event

Improvement add code split when fetching event
This commit is contained in:
Ondrej Synacek 2020-12-25 14:51:32 +01:00 committed by GitHub
commit 824db0b6f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 24 additions and 6 deletions

View File

@ -21,12 +21,14 @@
</style> </style>
<script> <script>
import { createEvent } from '../actions'
import logger from '../services/logger' import logger from '../services/logger'
export let error export let error
export let pending export let pending
export let pendingRequest export let pendingRequest
export let onModuleLoadStart
export let onModuleLoadStop
export let onModuleLoadError
let value = '' let value = ''
$: value = error && pendingRequest && pendingRequest.url || '' $: value = error && pendingRequest && pendingRequest.url || ''
@ -38,15 +40,24 @@
pending ? 'input--pending': '', pending ? 'input--pending': '',
].join(' ') ].join(' ')
const handleSubmit = (e) => { const handleSubmit = async (e) => {
if (!form.reportValidity()) { if (!form.reportValidity()) {
return return
} }
e.preventDefault() e.preventDefault()
createEvent(value, { logger }) try {
value = '' onModuleLoadStart()
const module = await import('../actions')
onModuleLoadStop()
module.createEvent(value, { logger })
value = ''
} catch (importError) {
onModuleLoadError(importError)
console.error(importError)
}
} }
const handleChange = (e) => { const handleChange = (e) => {

View File

@ -8,6 +8,10 @@
$: pendingRequest = $requestStore $: pendingRequest = $requestStore
$: status = $parseStatusStore $: status = $parseStatusStore
$: swStatus = $swStatusStore $: swStatus = $swStatusStore
const handleModuleLoadStart = () => parseStatusStore.set('Loading application data.')
const handleModuleLoadEnd = () => parseStatusStore.set(null)
const handleModuleLoadError = (error) => parseStatusStore.set('Failed to load application data.')
</script> </script>
<div class="input-container"> <div class="input-container">
@ -15,6 +19,9 @@
{pending} {pending}
{pendingRequest} {pendingRequest}
{error} {error}
onModuleLoadStart={handleModuleLoadStart}
onModuleLoadStop={handleModuleLoadEnd}
onModuleLoadError={handleModuleLoadError}
/> />
<Status <Status
{error} {error}

2
package-lock.json generated
View File

@ -1,6 +1,6 @@
{ {
"name": "facebook-events-ical-converter", "name": "facebook-events-ical-converter",
"version": "1.4.1", "version": "1.4.2",
"lockfileVersion": 1, "lockfileVersion": 1,
"requires": true, "requires": true,
"dependencies": { "dependencies": {

View File

@ -1,6 +1,6 @@
{ {
"name": "facebook-events-ical-converter", "name": "facebook-events-ical-converter",
"version": "1.4.1", "version": "1.4.2",
"private": true, "private": true,
"description": "App that converts events on Facebook event page to iCal file.", "description": "App that converts events on Facebook event page to iCal file.",
"main": "lib/index.js", "main": "lib/index.js",