Some code cleaning

app/src/main/java/fr/gouv/etalab/mastodon/activities/AboutActivity.java

@@ -22,7 +22,6 @@ import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Bundle;
 import android.support.v4.content.ContextCompat;
-import android.support.v7.app.AppCompatActivity;
 import android.view.MenuItem;
 import android.view.View;
 import android.widget.Button;

app/src/main/java/fr/gouv/etalab/mastodon/activities/HashTagActivity.java

@@ -20,7 +20,6 @@ import android.content.SharedPreferences;
 import android.os.AsyncTask;
 import android.os.Bundle;
 import android.support.v4.widget.SwipeRefreshLayout;
-import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.DividerItemDecoration;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;

app/src/main/java/fr/gouv/etalab/mastodon/activities/InstanceActivity.java

@@ -22,7 +22,6 @@ import android.os.AsyncTask;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.design.widget.FloatingActionButton;
-import android.support.v7.app.AppCompatActivity;
 import android.text.Html;
 import android.view.MenuItem;
 import android.view.View;

app/src/main/java/fr/gouv/etalab/mastodon/activities/InstanceHealthActivity.java

@@ -30,7 +30,6 @@ import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.v4.content.ContextCompat;
-import android.support.v7.app.AppCompatActivity;
 import android.text.SpannableString;
 import android.text.style.UnderlineSpan;
 import android.view.MenuItem;

app/src/main/java/fr/gouv/etalab/mastodon/activities/ListActivity.java

@@ -46,7 +46,6 @@ import fr.gouv.etalab.mastodon.asynctasks.RetrieveFeedsAsyncTask;
 import fr.gouv.etalab.mastodon.client.APIResponse;
 import fr.gouv.etalab.mastodon.client.Entities.Status;
 import fr.gouv.etalab.mastodon.drawers.StatusListAdapter;
-import fr.gouv.etalab.mastodon.fragments.DisplayListsFragment;
 import fr.gouv.etalab.mastodon.helper.Helper;
 import fr.gouv.etalab.mastodon.interfaces.OnListActionInterface;
 

app/src/main/java/fr/gouv/etalab/mastodon/activities/LoginActivity.java

@@ -21,7 +21,6 @@ import android.graphics.Paint;
 import android.os.AsyncTask;
 import android.os.Bundle;
 import android.support.v4.content.ContextCompat;
-import android.support.v7.app.AppCompatActivity;
 import android.text.Editable;
 import android.text.TextWatcher;
 import android.view.Menu;
@@ -34,8 +33,6 @@ import android.widget.EditText;
 import android.widget.TextView;
 import android.widget.Toast;
 
-import org.conscrypt.Conscrypt;
-import org.conscrypt.OpenSSLProvider;
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -43,7 +40,6 @@ import org.json.JSONObject;
 import java.io.UnsupportedEncodingException;
 import java.net.URLEncoder;
 
-import java.security.Security;
 import java.util.HashMap;
 
 import fr.gouv.etalab.mastodon.R;

app/src/main/java/fr/gouv/etalab/mastodon/activities/ManageAccountsInListActivity.java

@@ -61,6 +61,7 @@ public class ManageAccountsInListActivity extends BaseActivity implements OnList
     private java.util.List<Account> accounts;
     private AccountsInAListAdapter accountsInAListAdapter;
 
+
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);

app/src/main/java/fr/gouv/etalab/mastodon/activities/MediaActivity.java

@@ -30,7 +30,6 @@ import android.support.annotation.Nullable;
 import android.support.v4.app.ActivityCompat;
 import android.support.v4.content.ContextCompat;
 import android.support.v7.app.ActionBar;
-import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.Toolbar;
 import android.view.LayoutInflater;
 import android.view.MotionEvent;

app/src/main/java/fr/gouv/etalab/mastodon/activities/PrivacyActivity.java

@@ -17,7 +17,6 @@ package fr.gouv.etalab.mastodon.activities;
 
 import android.content.SharedPreferences;
 import android.os.Bundle;
-import android.support.v7.app.AppCompatActivity;
 import android.view.MenuItem;
 
 import fr.gouv.etalab.mastodon.R;

app/src/main/java/fr/gouv/etalab/mastodon/activities/RemoteFollowActivity.java

@@ -27,7 +27,6 @@ import android.os.Bundle;
 import android.support.design.widget.FloatingActionButton;
 import android.support.v4.content.ContextCompat;
 import android.support.v7.app.ActionBar;
-import android.support.v7.app.AppCompatActivity;
 import android.text.Editable;
 import android.text.TextWatcher;
 import android.view.LayoutInflater;

app/src/main/java/fr/gouv/etalab/mastodon/activities/SearchResultActivity.java

@@ -18,7 +18,6 @@ import android.content.Context;
 import android.content.SharedPreferences;
 import android.os.AsyncTask;
 import android.os.Bundle;
-import android.support.v7.app.AppCompatActivity;
 import android.view.MenuItem;
 import android.view.View;
 import android.widget.ListView;

app/src/main/java/fr/gouv/etalab/mastodon/activities/ShowAccountActivity.java

@@ -25,8 +25,6 @@ import android.graphics.ColorFilter;
 import android.graphics.LightingColorFilter;
 import android.graphics.Matrix;
 import android.graphics.Paint;
-import android.graphics.PorterDuff;
-import android.graphics.PorterDuffXfermode;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
 import android.os.AsyncTask;
@@ -45,7 +43,6 @@ import android.support.v4.graphics.drawable.RoundedBitmapDrawableFactory;
 import android.support.v4.view.PagerAdapter;
 import android.support.v4.view.ViewPager;
 import android.support.v7.app.AlertDialog;
-import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.PopupMenu;
 import android.text.SpannableString;
 import android.text.method.LinkMovementMethod;

app/src/main/java/fr/gouv/etalab/mastodon/activities/ShowConversationActivity.java

@@ -25,7 +25,6 @@ import android.os.Bundle;
 import android.os.Handler;
 import android.support.v4.widget.SwipeRefreshLayout;
 import android.support.v7.app.ActionBar;
-import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.DividerItemDecoration;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;

app/src/main/java/fr/gouv/etalab/mastodon/activities/TootActivity.java

@@ -46,12 +46,10 @@ import android.os.Build;
 import android.os.Bundle;
 import android.speech.RecognizerIntent;
 import android.support.v7.app.ActionBar;
-import android.support.v7.app.AppCompatActivity;
 import android.text.Editable;
 import android.text.Html;
 import android.text.InputFilter;
 import android.text.InputType;
-import android.text.SpannableString;
 import android.text.TextWatcher;
 import android.text.method.ScrollingMovementMethod;
 import android.view.LayoutInflater;

app/src/main/java/fr/gouv/etalab/mastodon/activities/WebviewActivity.java

@@ -24,7 +24,6 @@ import android.os.Build;
 import android.os.Bundle;
 import android.support.v4.app.ActivityCompat;
 import android.support.v4.content.ContextCompat;
-import android.support.v7.app.AppCompatActivity;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;

app/src/main/java/fr/gouv/etalab/mastodon/activities/WebviewConnectActivity.java

@@ -24,7 +24,6 @@ import android.os.AsyncTask;
 import android.os.Build;
 import android.os.Bundle;
 import android.support.v7.app.AlertDialog;
-import android.support.v7.app.AppCompatActivity;
 import android.webkit.CookieManager;
 import android.webkit.CookieSyncManager;
 import android.webkit.WebChromeClient;

app/src/main/java/fr/gouv/etalab/mastodon/drawers/AccountsListAdapter.java

@@ -24,7 +24,6 @@ import android.support.design.widget.FloatingActionButton;
 import android.support.v7.widget.RecyclerView;
 import android.text.Html;
 import android.text.util.Linkify;
-import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;

app/src/main/java/fr/gouv/etalab/mastodon/drawers/AccountsSearchAdapter.java

@@ -37,7 +37,6 @@ import java.util.List;
 
 import fr.gouv.etalab.mastodon.R;
 import fr.gouv.etalab.mastodon.client.Entities.Account;
-import fr.gouv.etalab.mastodon.client.Entities.Mention;
 import fr.gouv.etalab.mastodon.helper.Helper;
 import fr.gouv.etalab.mastodon.sqlite.AccountDAO;
 import fr.gouv.etalab.mastodon.sqlite.Sqlite;
@@ -100,11 +99,11 @@ public class AccountsSearchAdapter extends ArrayAdapter<Account> implements Filt
         if (convertView == null) {
             convertView = layoutInflater.inflate(R.layout.drawer_account_search, parent, false);
             holder = new ViewHolder();
-            holder.account_pp = (ImageView) convertView.findViewById(R.id.account_pp);
+            holder.account_pp = convertView.findViewById(R.id.account_pp);
-            holder.account_dn = (TextView) convertView.findViewById(R.id.account_dn);
+            holder.account_dn = convertView.findViewById(R.id.account_dn);
-            holder.account_un = (TextView) convertView.findViewById(R.id.account_un);
+            holder.account_un = convertView.findViewById(R.id.account_un);
 
-            holder.account_container = (LinearLayout) convertView.findViewById(R.id.account_container);
+            holder.account_container = convertView.findViewById(R.id.account_container);
             convertView.setTag(holder);
         } else {
             holder = (ViewHolder) convertView.getTag();

app/src/main/java/fr/gouv/etalab/mastodon/drawers/CustomEmojiAdapter.java

@@ -43,13 +43,11 @@ public class CustomEmojiAdapter extends ArrayAdapter {
 
     private Context context;
     private List<Emojis> emojis;
-    private CustomEmojiAdapter customEmojiAdapter;
 
     public CustomEmojiAdapter(@NonNull Context context, int resource, List<Emojis> emojis) {
         super(context, resource, resource);
         this.context = context;
         this.emojis = emojis;
-        customEmojiAdapter = this;
     }
 
     @Override

app/src/main/java/fr/gouv/etalab/mastodon/drawers/EmojisSearchAdapter.java

@@ -45,12 +45,10 @@ public class EmojisSearchAdapter extends ArrayAdapter<Emojis> implements Filtera
 
     private List<Emojis> emojis, tempEmojis, suggestions ;
     private LayoutInflater layoutInflater;
-    private Context context;
 
     public EmojisSearchAdapter(Context context, List<Emojis> emojis){
         super(context, android.R.layout.simple_list_item_1, emojis);
         this.emojis = emojis;
-        this.context = context;
         this.tempEmojis = new ArrayList<>(emojis);
         this.suggestions = new ArrayList<>(emojis);
         layoutInflater = LayoutInflater.from(context);

app/src/main/java/fr/gouv/etalab/mastodon/drawers/NotificationsListAdapter.java

@@ -68,7 +68,6 @@ import fr.gouv.etalab.mastodon.client.APIResponse;
 import fr.gouv.etalab.mastodon.client.Entities.Attachment;
 import fr.gouv.etalab.mastodon.client.Entities.Emojis;
 import fr.gouv.etalab.mastodon.client.Entities.Error;
-import fr.gouv.etalab.mastodon.client.Entities.Mention;
 import fr.gouv.etalab.mastodon.helper.CrossActions;
 import fr.gouv.etalab.mastodon.interfaces.OnPostActionInterface;
 import fr.gouv.etalab.mastodon.interfaces.OnPostNotificationsActionInterface;

app/src/main/java/fr/gouv/etalab/mastodon/drawers/SearchListAdapter.java

@@ -136,10 +136,12 @@ public class SearchListAdapter extends BaseAdapter {
             final float scale = context.getResources().getDisplayMetrics().density;
             if( !status.getIn_reply_to_account_id().equals("null") || !status.getIn_reply_to_id().equals("null") ){
                 Drawable img = ContextCompat.getDrawable(context, R.drawable.ic_reply);
+                assert img != null;
                 img.setBounds(0,0,(int) (20 * scale + 0.5f),(int) (15 * scale + 0.5f));
                 holder.status_account_displayname.setCompoundDrawables( img, null, null, null);
             }else if( status.getReblog() != null){
                 Drawable img = ContextCompat.getDrawable(context, R.drawable.ic_repeat);
+                assert img != null;
                 img.setBounds(0,0,(int) (20 * scale + 0.5f),(int) (15 * scale + 0.5f));
                 holder.status_account_displayname.setCompoundDrawables( img, null, null, null);
             }else{

app/src/main/java/fr/gouv/etalab/mastodon/drawers/StatusListAdapter.java

@@ -84,7 +84,6 @@ import fr.gouv.etalab.mastodon.client.APIResponse;
 import fr.gouv.etalab.mastodon.client.Entities.Attachment;
 import fr.gouv.etalab.mastodon.client.Entities.Emojis;
 import fr.gouv.etalab.mastodon.client.Entities.Error;
-import fr.gouv.etalab.mastodon.client.Entities.Mention;
 import fr.gouv.etalab.mastodon.client.Entities.Status;
 import fr.gouv.etalab.mastodon.fragments.DisplayStatusFragment;
 import fr.gouv.etalab.mastodon.helper.CrossActions;
@@ -117,7 +116,6 @@ public class StatusListAdapter extends RecyclerView.Adapter implements OnPostAct
     private final int DISPLAYED_STATUS = 1;
     private List<Status> pins;
     private int conversationPosition;
-    private String bookmark = null;
 
     public StatusListAdapter(Context context, RetrieveFeedsAsyncTask.Type type, String targetedId, boolean isOnWifi, int behaviorWithAttachments, int translator, List<Status> statuses){
         super();
@@ -131,9 +129,6 @@ public class StatusListAdapter extends RecyclerView.Adapter implements OnPostAct
         this.targetedId = targetedId;
         this.translator = translator;
         pins = new ArrayList<>();
-        if( context instanceof BaseMainActivity){
-            bookmark = ((BaseMainActivity) context).getBookmark();
-        }
     }
 
     public StatusListAdapter(Context context, int position, String targetedId, boolean isOnWifi, int behaviorWithAttachments, int translator, List<Status> statuses){
@@ -148,9 +143,6 @@ public class StatusListAdapter extends RecyclerView.Adapter implements OnPostAct
         this.targetedId = targetedId;
         this.translator = translator;
         pins = new ArrayList<>();
-        if( context instanceof BaseMainActivity){
-            bookmark = ((BaseMainActivity) context).getBookmark();
-        }
     }
 
     @Override