* Add serialization of the meta-data and focus objects
These objects are added in some attachments. This commit adds data
classes which are able to serialize these (partially) in preparation
for the ability to honour the focal point information in image
previews.
* Implement correctly honouring the focal point meta-data in previews
This commit adds code which ensures that the image previews of media
attachments to toots are correctly cropped to always show the focal
point of the image (if it is specified). It should not in any way
influence how previews of media without a focal point are shown.
To achieve the correct crop on the image a few components were
needed:
First of all we needed a way to influence how the image is cropped
into the ImageView. It turns out that the preferred way to do this is
by setting the ScaleType to MATRIX and adjusting the matrix of the
image as needed. This matrix allows us to scale and transform the
image in the way we need to make sure that the focal point is visible
within the view. For this purpose we have the FocalPointEnforcer which
can calculate and set the appropriate matrix on an ImageView as soon
as the image is loaded.
However a second problem is that we need to make sure that this matrix
is updated whenever the size of the ImageView changes. The size might
change for example because the orientation of the device changed from
portrait to landscape or vice versas, or for a number of other reasons
such as the screen being split vertically or something like that.
To be able to hook onto this event we need to create a new extended
version of the ImageView class, which we call
MediaPreviewImageView. This class behaves exactly the same as a normal
ImageView, however if the focalPointEnforcer of this view is set, then
it will call this enforcer to update the image matrix any time the
size is changed.
So this commit changes all media previews in the item_status.xml and
item_status_detailled.xml layout files to the new
MediaPreviewImageView class. Additionally in the code for loading the
images into the previews a new case is added which tests if there is a
focus attribute in the meta-data. If so it makes sure to create and
set the FocalPointEnforcer.
* Fix typos in documentation comment
"to" -> "too"
* Use static imports to remove clutter in FocalPointEnforcerTest
Instead of duplication Assert. in front of every assertEquals, simply
statically import it.
* Move the MetaData and Focus classes into the Attachment class
Since they are very strongly linked to the attachment class and are
themselves very small.
* Refactor the focal point handling code
- All the code modifying the actual members of the
MediaPreviewImageView is now in this class itself. This class still
uses the FocalPointUtil to calculate the new Matrix, but it now
handles setting this new Matrix itself.
- The FocalPointEnforcer has been renamed to the FocalPointUtil to
reflect that it only calculates the correct matrix, but doesn't set
anything on the MediaPreviewImageView.
- The Matrix used to control the cropping of the
MediaPreviewImageViews is now only allocated a single time per view
instead of each time the view is resized. This is done by caching
the Matrix and passing it to the FocalPointUtil to update on each
resize.
* Only reallocate focalMatrix if it is not yet initialized
This helps prevent unnecessary allocations in the case where
setFocalPoint is called multiple times.
* Change checking of availability of objects to use != null
As pointed out, the 'is' keyword is meant for checking types, not for
checking non-nullness.
* Make updateFocalPointMatrix() return nothing
This makes it clearer that it actually mutates the matrix it is
given.
* Fix bug with transitions crashing the PhotoView
Due to the android transitions for some reason copying the scaletype
from the MediaPreviewImageView to the PhotoView during the transition,
the PhotoView would crash on pictures with a focal point, since
PhotoView doesn't support ScaleType.MATRIX.
This is solved by the workaround of overriding both the getScaleType
and setScaleType methods to ensure that we use the MATRIX type in the
preview and the center_crop type in the PhotoView.
Additionally this commit also makes sure to remove the focal point
when the MediaPreviewImageView is recycled.
* Fix bug in overriden getScaleType
Instead of simply returning the scaleType we need to return the
super.getScaleType() method, to avoid crashing.
* Merge changes from master
Mainly the migration to androidx.
* move reblog/fav count up in detailed status view and make them clickable
* use status object returned by api when reblogging/faving
* Reblogs -> Boosts
* add support for viewing who faved/reblogged a status
* add onShowReblogs/onShowFavs to listener, fix display bug
* remove unneeded icon from previous revision
* small code improvements
* fix liking/boosting toot with card
* upgrade to AndroidX, upgrade libraries
* move to MaterialComponents theme
* make sure the compose button looks good everywhere
* fix tollbar title/button alignment on tablet
* move to new material color theming, consolidate colors and themes
* fix build, fix imports
* set error on TextInputLayout instead of EditText
* fix imports, TootButton when
* improve snackbar style
* fix task description color
* WIP: still display mentions when toot content is hidden
* WIP: still display mentions when toot content is hidden (2)
* Still display mentions when toot content is hidden (3)
* Factorize code for setting content and spoiler on a toot
* Factorize condition
* Add visibility icons to statuses
* Remove visibility icons from timeline statuses
* Dynamically scale visibility icon according to timestamp font size
* Remove visibility icon selection logic from Status model
* Migrate visibility icon logic to StatusDetailedViewHolder
* Simplify/improve performance of visibility icon layout
* Use text size for visibility icon size (instead of view size)
* Remove unnecessary LayoutListener
* Remove unnecessary visibilityIcon check
* Enforce 420-character limit on media descriptions in the UI
* Persist media descriptions with drafts
* Defer media description update until after upload finishes
* Make description field 2 lines for better visibility of hint text
* Reuse Gson instance
* Force retranslation of modified string "hint_describe_for_visually_impaired"
* Add bounds check when reading serialized media descriptions
* Fix media transitions, reduce code duplication between media fragments
* Remove redundant helper
* Fix occasional crash when swiping between mixed media
* Hide controls when swiping between media
* Migrate ImagePagerAdapter to kotlin
* Migrate ViewMediaFragment to kotlin
* Make images and videos share the same activity/pager
* Show descriptions above videos
* Cleanup
* Address code review feedback
* Migrate media fragments to constraint layout
* Update Gradle plugin to work with Android Studio 3.3 Canary
Android Studio 3.1.4 Stable doesn't render layout previews in this project
for whatever reason. Switching to the latest 3.3 Canary release fixes the
issue without affecting Gradle scripts but requires the new Android Gradle
plugin to match the new Android Studio release.
This commit will be reverted once development on the feature is done.
* Update gradle build script to allow installing debug builds alongside store version
This will allow developers, testers, etc to work on Tusky will not having to worry
about overwriting, uninstalling, fiddling with a preinstalled application which would
mean having to login again every time the development cycle starts/finishes and
manually reinstalling the app.
* Add UI changes to support collapsing statuses
The button uses subtle styling to not be distracting like the CW button on the timeline
The button is toggleable, full width to match the status textbox hitbox width and also
is shorter to not be too intrusive between the status text and images, or the post below
* Update status data model to store whether the message has been collapsed
* Update status action listener to notify of collapsed state changing
Provide stubs in all implementing classes and mark as TODO the stubs that
require a proper implementation for the feature to work.
* Add implementation code to handle status collapse/expand in timeline
Code has not been added elsewhere to simplify testing.
Once the code will be considered stable it will be also included in other
status action listener implementers.
* Add preferences so that users can toggle the collapsing of long posts
This is currently limited to a simple toggle, it would be nice to implement
a more advanced UI to offer the user more control over the feature.
* Update Gradle plugin to work with latest Android Studio 3.3 Canary 8
Just like the other commit, this will be reverted once the feature is working.
I simply don't want to deal with what changes in my installation of Android
Studio 3.1.4 Stable which breaks the layout preview rendering.
* Update data models and utils for statuses to better handle collapsing
I forgot that data isn't available from the API and can't really be built
from scratch using existing data due to preferences.
A new, extra boolean should fix the issue.
* Fix search breaking due to newly introduced variables in utils classes
* Fix timeline breaking due to newly introduced variables in utils classes
* Fix item status text for collapsed toggle being shown in the wrong state
* Update timeline fragment to refresh the list when collapsed settings change
* Add support for status content collapse in timeline viewholder
* Fix view holder truncating posts using temporary debug settings at 50 chars
* Add toggle support to notification layout as well
* Add support for collapsed statuses to search results
* Add support for expandable content to notifications too
* Update codebase with some suggested changes by @charlang
* Update more code with more suggestions and move null-safety into view data
* Update even more code with even more suggested code changes
* Revert a0a41ca and 0ee004d (Android Studio 3.1 to Android Studio 3.3 updates)
* Add an input filter utility class to reuse code for trimming statuses
* Update UI of statuses to show a taller collapsible button
* Update notification fragment logging to simplify null checks
* Add smartness to SmartLengthInputFilter such as word trimming and runway
* Fix posts with show more button even if bad ratio didn't collapse
* Fix thread view showing button but not collapsing by implementing the feature
* Fix spannable losing spans when collapsed and restore length to 500 characters
* Remove debug build suffix as per request
* Fix all the merging happened in f66d689, 623cad2 and 7056ba5
* Fix notification button spanning full width rather than content width
* Add a way to access a singleton to smart filter and use clearer code
* Update view holders using smart input filters to use more singletons
* Fix code style lacking spaces before boolean checks in ifs and others
* Remove all code related to collapsibility preferences, strings included
* Update style to match content warning toggle button
* Update strings to give cleaner differentiation between CW and collapse
* Update smart filter code to use fully qualified names to avoid confusion
* set minSdkVersion to 21
* use elevation instead of additional views for shadow
* clean up code occurrences
* remove drawable compat code
* remove no longer needed resources
* remove unneeded android:clipChildren="false"
* Revert "remove no longer needed resources"
This reverts commit 67a4d6f8d87b3f116b95d90dfb48f350d342f503.
* remove no longer needed resources (this time the right ones)
* fix progressbars of footer and fragment overlapping
* add progressbar to bottom of notification list again
* fix bottom loading getting stuck sometimes
* upgrade MaterialDrawer
* improve CustomEmojiHelper so now any parent view can be used for invalidation
* cleanup MainActivity a bit
* add emojiList to account database and show compatEmojis and custom emojis in drawer
* improve perf of drawer profile update
* fix account switching
* reuse gson, break after profile item was found
* Add black theme
On amoled screens a completely black theme helps save battery,
besides looking awesome!
* Fix first set of merge request issues except the dialog.
* Black theme inherits from dark and only the different values
are declared
* Make nav bar translucent (for some reason content does not
go behind it in main activity. Need to investigate)
* Remove nav bar line
* Fix toolbar color
* Fix dialog issue with black theme.
Revert translucent navigation.
* Translations updated, as well as possible from online sources.
* Make login screen respect black theme
* Refactor-all-the-things version of the fix for issue #573
* Migrate SpanUtils to kotlin because why not
* Minimal fix for issue #573
* Add tests for compose spanning
* Clean up code suggestions
* Make FakeSpannable.getSpans implementation less awkward
* Add secondary validation pass for urls
* Address code review feedback
* Fixup type filtering in FakeSpannable again
* Make all mentions in compose activity use the default link color
* new layout for AccountActivity
* fix the light theme
* convert AccountActivity to Kotlin
* introduce AccountViewModel
* Merge branch 'master' into account-activity-redesign
# Conflicts:
# app/src/main/java/com/keylesspalace/tusky/AccountActivity.java
* add Bot badge to profile
* parse custom emojis in usernames
* add possibility to cancel follow request
* add third tab on profiles
* add account fields to profile
* add support for moved accounts
* set click listener on account moved view
* fix tests
* use 24dp as statusbar size
* add ability to hide reblogs from followed accounts
* add button to edit own account to AccountActivity
* set toolbar top margin programmatically
* fix crash
* add shadow behind statusbar
* introduce ViewExtensions to clean up code
* move code out of offsetChangedListener for perf reasons
* clean up stuff
* add error handling
* improve type safety
* fix ConstraintLayout warning
* remove unneeded ressources
* fix event dispatching
* fix crash in event handling
* set correct emoji on title
* improve some things
* wrap follower/foillowing/status views
* Isolate usernames when formatting, to improve interaction of RTL usernames with LTR locales (and vice versa)
* Add bidirectionality safeguards in NotificationHelper
* Cache bidirectionality formatter instance in NotificationsAdapter
* Refactor-all-the-things version of the fix for issue #573
* Migrate SpanUtils to kotlin because why not
* Minimal fix for issue #573
* Add tests for compose spanning
* Clean up code suggestions
* Make FakeSpannable.getSpans implementation less awkward
* Add secondary validation pass for urls
* Address code review feedback
* Fixup type filtering in FakeSpannable again
* Make all mentions in compose activity use the default link color
* Add circleci
* Commit to maybe fix ci
* Suppress false positives in lint
* Disable linting for tests in ci
* Add image descriptions to gallery
* Fix test
* [CI] Attempt to fix OOM error
* [CI] Attempt to fix OOM error, 2
* Add option to open status from media
* fix theme issue
* increase linespacing on media description
* Add EmojiCompat
* EmojiCompat doesn' replace all emojis anymore
* This app should be now capable of loading a EmojiCompat-font located in a file somewhere inside the device's storage
* Should now replace all emojis
* Add EmojiCompat support to EditTextTyped
* Provide EmojiCompat fonts
* The app won't crash anymore when no emoji font is available.
Emoji font should now be located at [Private external app directory]/files/EmojiCompat.ttf
* Removed BundledEmojiCompat dependency
Since this EmojiCompat-implementation does not rely on BundledEmojiCompat, there's no reason to have it enabled.
* Update EditTextTyped.kt
Since connection isn't assigned to (I tried doing so), it can be declared final/val again.
* Update README.md
* Add some non-working emoji preferences
* Add a short font list for testing
* Finished implementation
* Add Twemoji to font list
* Update documentation, more comments
* Delete AssetEmojiCompat which is obsolete now
* Update the font list
* Update the font list
* Fix font list & add Exception handling for malformed JSON files (hopefully)
* More fixes. It should work now...
* Removed AssetEmojiCompat (again)
* Add most of the changes
* Improved the EmojiCompat dialog's style
* The font list is now based on a static layout without external files
* Re-add the real font URL for Twemoji
* Emoji-font captions are now translatable
* Removed one unused String (loading)
* Removed emoji fonts from this repo
* Applied changes from the PR change requests
* The correct emoji font will be selected after cancelling a change
* Add details on the EmojiCompat fonts available (not shown yet)
* Add licensing information on Twemoji and Blobmoji
* Reworked some strings
* Moved FileEmojiCompat to its own library
* Update FileEmojiCompat to the latest version (1.0.3)
* EmojiCompat bug should be fixed
* Better handling of failed downloads
* Removed one TODO
Signed-off-by: Constantin A <10349490+C1710@users.noreply.github.com>
* Update emoji attribution strings
Signed-off-by: Constantin A <10349490+C1710@users.noreply.github.com>
* Fixed some misspelled strings
Signed-off-by: Constantin A <10349490+C1710@users.noreply.github.com>
Konrad Pozniak
Ivan Kupalov
jchmrt
kyori19
Conny Duck
Mélanie Chauvel (ariasuni)
Billy Brawner
Levi Bard
Prat
HellPie
Gian Sass
eleete0712
qwazix
Ivan Kupalov
Paul
Constantin A