Commit Graph

1476 Commits

Author SHA1 Message Date
Nik Clayton 0def7e7230
Provide default text sizes in TuskyBaseTheme (#3108)
These aren't necessary for the app, and are overwritten with the actual style
in `BaseActivity.onCreate()`.

But if they're missing the Android Studio layout preview renderer crashes.
2022-12-30 13:11:26 +01:00
Nik Clayton 62a8a4a60a
Leave the "edit scheduled status" button enabled after clicking (#3100)
* Leave the "edit scheduled status" button enabled after clicking

If the user submits an edit to the scheduled status then this one will be deleted, the paging source will notice, the adapter will be notified in the normal way, and this binding will be reused.

Or the user backs out of the edit, and this adapter entry is still valid and should remain clickable.

Fixes https://github.com/tuskyapp/Tusky/issues/2705

* Remove unnecessary parameter.

* Remove unnecessary import
2022-12-30 12:09:42 +01:00
Nik Clayton 02cadd5d33
Ensure text content is always pasted as plain text (#3083)
Fixes https://github.com/tuskyapp/Tusky/issues/3082.
2022-12-30 11:41:48 +01:00
Nik Clayton c07dd0f919
Remove debug logging of keypresses (#3075)
While only present in a Log.d call, which should be stripped out of release
builds, this feels like an unnecessary privacy risk.
2022-12-30 11:41:11 +01:00
Eric Frohnhoefer 3170e1ce71
Fix auto play when swiping between attachments (#3077)
* Fix auto play when swiping between attachments

Fixes an issue where attachment doesn't autoplay when swiping left/right from initial attachment.

Fixes #3066

* Fix lint error for wild card imports
2022-12-30 11:22:39 +01:00
Eric Frohnhoefer 65e95a7858
Add FAB to self account view (#3067)
Fixes 3058
2022-12-30 11:22:01 +01:00
Konrad Pozniak abca91a420
Handoff media upload (#2947)
* handoff media upload to SendStatusService

* fix bugd

* improve code

* don't check processing state when upload returned 200
2022-12-29 19:58:23 +01:00
Nik Clayton ee765a3117
Convert AccountViewHolder from Java to Kotlin (#3044)
* Convert AccountViewHolder from Java to Kotlin

Use view binding in the converted code, which requires small changes in code
that calls constructors.

Pass showBotOverlays as a parameter, rather than having the code reach in to
the shared preferences, fixing a layering violation. This affects callers
and classes derived from AccountAdapter.

* Use 2-arg getString

* Simplify setting bot badge indicator

- Specify the drawable in the XML
- Use visible() to set visibility
- Rename ID to account_bot_badge to make it clearer that this is all it is for

* Use lateinit to avoid needing !! later
2022-12-28 19:07:43 +01:00
Nik Clayton a21f2fadf9
Remove rxjava from API calls used by AccountViewModel::changeRelationship() (#3008)
* Remove rxjava from API calls used by AccountListFragment

* Remove rxjava from API calls used by AccountViewModel::changeRelationship()

The affected API functions are also called from

- ReportViewModel.kt
- SearchViewModel.kt
- AccountListFragment.kt
- SFragment.java
- TimelineCases.kt

so they have also been updated.

This change requires bridging from Java code to Kotlin `suspend` functions,
by creating wrappers for the `mute` and `block` functions that can be
called from Java and create a coroutine scope.

I've deliberately made this fairly ugly so that it sticks out and can be
removed later.

* Use "Throwable" type and name

* Delete 46.json

Not sure where this came from.

* Emit log messages with the correct tag

* Add another log tag, and lint

* Move viewModelScope.launch in to changeRelationshop()
2022-12-28 19:06:31 +01:00
UlrichKu 6aed1c6806
issue 2890: Add an "ALT" sticker to the media preview container (#2942)
* issue 2890: Add an "ALT" sticker to the media preview container if there are descriptions

* issue 2890: Use end and start for positioning

* issue 2890: Adapt to new media view group

* issue 2890: Use an indicator overlay for every (single) preview image

* issue 2890: Reduce radius to match that of the preview layout

* issue 2890: Remove (again) unused code

* issue 2890: Set visibility in any case

* issue 2890: Use a translatable text for ALT

* issue 2890: Show ALT flag only when showing media

* issue 2890: Call doOnLayout on the layout wrapper
2022-12-18 16:50:30 +01:00
Eva Tatarka 2de2af0a8c
Fix media preview sometimes not showing (#3023) 2022-12-08 21:25:59 +01:00
Levi Bard a6b6a40ba6
Add post editing capability (#2828)
* Add post editing capability

* Don't try to reprocess already uploaded attachments.
Fixes editing posts with existing media

* Don't mark post edits as modified until editing occurs

* Disable UI for things that can't be edited when editing a post

* Finally convert SFragment to kotlin

* Use api endpoint for fetching status source for editing

* Apply review feedback
2022-12-08 10:18:12 +01:00
Levi Bard 51d02388b9
Fix tests (#3022) 2022-12-08 09:58:58 +01:00
Konrad Pozniak 88125ef7da
fix crash in TouchDelegateHelper when not all views are available (#3016)
* fix crash in TouchDelegateHelper when not all views are available

* filter views before passing to TouchDelegateHelper

* remove unused import

* fix indentation
2022-12-07 19:34:54 +01:00
Nik Clayton e20fda322e
Remove rxjava from API calls used by AccountListFragment::fetchAccounts() (#3005)
* Remove rxjava from API calls used by AccountListFragment

* Use "Throwable" type and name
2022-12-07 19:34:31 +01:00
Nik Clayton f796f77f9a
Implement getFilters() without rxjava (#2990) 2022-12-07 19:30:53 +01:00
kylegoetz 25443217c2
2952/proxy (#2961)
* replace hard-coded strings with existing constants

* proxy port

* * custom proxy port and hostname inputs
* typesafety, refactor, linting, unit tests

* relocate ProxyConfiguration in app structure

* remove unused editTextPreference fn

* allow preference category to have no title

* refactor proxy prefs hierarchy/dependency
2022-12-07 19:29:18 +01:00
Konrad Pozniak 864e72d6f3
make date converter null safe (#3006) 2022-12-06 20:32:12 +01:00
Nik Clayton 0d962c7cc1
Implement status() without rxjava (#2999)
* Implement status() without rxjava

* Use lambda param named `throwable`

* Update DraftsActivity.kt
2022-12-06 20:23:48 +01:00
UlrichKu 2accfd0712
2890 show warning on missing description (#2919)
* issue 2890: Show a warning icon if media description is missing

* issue 2890: Remove disturbing additional signs

* issue 2890: Add another icon; use a snackbar; change wording; use orange as color

* issue 2890: Remove now unneeded new resource

* issue 2890: Use a toast (also) to avoid elevation problems

* issue 2890: Use snackbar with elevation again; refactor a bit
2022-12-06 19:28:44 +01:00
Konrad Pozniak 615c7adc86
hide "take photo" button when no Photo app is installed (#2997) 2022-12-05 19:15:58 +01:00
Konrad Pozniak bdeb88c41f
respect "animate emojis" setting in emoji picker (#2996) 2022-12-05 19:15:28 +01:00
Eva Tatarka 36befdebe2
Add a touch delegate to increase action touch targets to 48dp (#2872)
* Add a touch delegate to increase action touch targets to 48dp

Fixes #2825

* Adjust layout to make action buttons larger

* Remove 4dp vertical margin
2022-12-05 19:05:46 +01:00
Nik Clayton 965d51100c
Cleanup NotificationFragment to make future conversion to Kotlin easier (#2993)
* Convert NotificationsFragment to use view binding

* Use requireContext() in places a context is required

Removes a nullness warning.

* Simplify code by using .sublist() and .contains()

Removes a lint warning.

* Add @NonNull annotations to onViewTag and onViewAccount

* Use consistent comment styles
2022-12-05 14:51:45 +01:00
Levi Bard 11de43f470
Sort language lists by the localized language name (#2991) 2022-12-05 14:49:09 +01:00
Konrad Pozniak f3962058dc
fix blocking accounts in thread view (#2988) 2022-12-05 14:44:52 +01:00
fruyek 24fccc3bbc
Show emoji codes on long press in the picker (#2981) 2022-12-05 14:36:51 +01:00
Nik Clayton 424326f99f
Add a menu option to mute / filter a hashtag from a status list (#2882)
* Add a menu option to mute / filter a hashtag from a status list

Un/muting uses the "home" filter

* Set the initial mute button visibility from existing filters

Check the user's filters to see if the tag is already filtered from HOME.

If it is then the initial button is to unmute it. If it isn't then the
initial button is to mute it.

* Avoid "mute tag" menu items "popping" in

- Initial state shows the "mute" option, disabled
- Update the state after the API call completes
2022-12-05 14:36:30 +01:00
Nik Clayton 64a06bfbe2
Support a swipe down to dismiss video (#2879)
* Support a swipe down to dismiss video

Images can already be dismissed with a swipe, this adds the same
functionality to videos.

- Add a VideoActionsListener interface for the hosting activity to dismiss
  the fragment
- Add a gesture listener for swipes
- Dismiss the fragment if a swipe has a greated Y component than X

Fixes https://github.com/tuskyapp/Tusky/issues/2833

* Scale the video view when dragging

Provides identical visual feedback to the same operation on images.
2022-12-05 14:33:38 +01:00
Konrad Pozniak 4de778d7d4
Show Avatar next to tabs when main top bar is disabled (#2973) 2022-12-03 12:16:54 +01:00
Konrad Pozniak 11cf420320
fix crash when trying to add account to list from profile (#2972) 2022-12-03 12:16:37 +01:00
Levi Bard 9e52f7acf1
Load goto social and microblog.pub urls in the app (#2945)
* Move looksLikeMastodonUrl to LinkHelper

* Add support for goto social and microblog.pub urls.
Closes #2893
2022-12-03 12:16:17 +01:00
fruyek d823052862
Status: Display indicators of edited posts (#2935)
* Add editedAt field to Status

* Status: Display indicators of edited posts

* Annotate edited posts in the Status description

* Cache info that post has been edited
2022-12-03 12:15:54 +01:00
Levi Bard 83862569e2
Nullcheck channels when reading importance. (#2971)
Fixes #2970
2022-12-02 19:46:02 +01:00
Levi Bard 588307f7a1
Enable setting the default posting language from Tusky (#2946)
* Extract locale utils

* Extract makeIcon

* Allow setting the (server-synchronized) default posting language from Tusky.
Closes #2902

* Add copyright headers

* Address review feedback
2022-12-02 19:19:17 +01:00
Eva Tatarka cc790ccf69
Add option to not crop image previews (#2832)
* Don't crop image previews with aspects between 2:1 & 1:2

Fixes #1995

* Custom media preview layout for handling various aspect ratios
2022-12-01 21:20:46 +01:00
Levi Bard 6b95790457
Add support for moderation report notifications (#2887)
* Add support for moderation report notifications

* Translate report categories

* Apply tint inside flag drawable

* Remove unused imports

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
2022-12-01 20:11:55 +01:00
kylegoetz 86e5c92a05
show "now" instead of "in 0s" timestamps (#2843)
* Add roundoff threshold for "now" (new string resource) output in getRelativeTimeSpanString

* added tests

* added string resource translation for `status_created_at_now` in DE, ES, JA

* fixed ktlint issues

* use resource file in test, linting passes

* 501ms and 999ms now show "now" instead of "0s"
2022-12-01 19:54:29 +01:00
Nik Clayton 330401c7d0
Disable tab swiping by preference in profile and search (#2889)
The "Enable swipe gesture to switch between tabs" preference was ignored
on the tabs on a profile page ("Posts", "With Replies", "Pinned", "Media"),
and search ("Posts", "Accounts", "Hashtags").

Fix this.

While I'm here, replace a string for the preference name in MainActivity.kt
with a constant.

Fixes https://github.com/tuskyapp/Tusky/issues/2874.
2022-12-01 19:51:13 +01:00
Konrad Pozniak 8c08fbddb6 fix merge conflict 2022-12-01 19:33:20 +01:00
Levi Bard 9362e59d9d
Add view for browsing and unfollowing followed hashtags (#2794)
* Add view for browsing and unfollowing followed hashtags.
Implements #2785

* Improve list interface

* Remove superfluous suspend modifier

* Migrate to paginated loading for followed tags view

* Update app/src/main/java/com/keylesspalace/tusky/components/followedtags/FollowedTagsViewModel.kt

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>

* Fix unhandled exception when opening the followed tags view while offline

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
2022-12-01 19:24:27 +01:00
Levi Bard 0126ee9500
Language selection fixes (#2917)
* Fix duplicated language entries from system and app language sets.
Closes #2900

* Prefer modern language codes.
Closes #2903

* Synchronize per-account default posting language with server.
Closes #2902

* Allow users to post in languages android doesn't know about yet (e.g. toki pona)

* Always put the preselected language at the top of the list
2022-11-24 15:45:19 +01:00
Konrad Pozniak 4f81636bbe
correctly show "nothing here" in AccountMediaFragment (#2911)
* correctly show "nothing here" in AccountMediaFragment

* remove unused imports
2022-11-23 20:07:23 +01:00
Konrad Pozniak ff4ddf90b6
fix crash when logging out while on conversations (#2895)
* fix crash when logging out while on conversations

* fix code formatting
2022-11-22 20:36:07 +01:00
Konrad Pozniak f6a5510841
respect spoiler/sensitive settings in conversations (#2891)
* respect spoiler/sensitive settings in conversations

* fix code formatting
2022-11-22 20:11:30 +01:00
Levi Bard 3fb103aa14
Prioritize users' default locales in language list (#2850)
* Prioritize users' default locales in language list.
Closes #2844

* Add the configured app languages before the configured system languages
2022-11-19 19:03:42 +01:00
Levi Bard 2676782327
Replace the default federated timeline tab with the direct messages tab. (#2866)
Closes #2552
2022-11-19 19:01:00 +01:00
Konrad Pozniak 61a1baf533
keep status state in thread view after refreshing (#2855)
* keep status state in thread view after refreshing

* add clarifying parentheses
2022-11-18 21:03:51 +01:00
Konrad Pozniak 667a728dd5
fix media permissions on Android 10+ (#2837) 2022-11-16 20:43:49 +01:00
Konrad Pozniak c96a81571c
support Android 13 per-app languages (#2829)
* support Android 13 per-app languages

* fix tests

* fix language ids in locales_config.xml

* fix language setting default in ComposeActivity
2022-11-16 19:45:18 +01:00