Fixes some odd behaviour during the login dance (possibly loading into the main activity with empty timelines).

This commit is contained in:
Vavassor 2017-03-31 19:16:10 -04:00
parent 26c722c950
commit 89e4cbb8b2
1 changed files with 30 additions and 16 deletions

View File

@ -33,6 +33,8 @@ import android.widget.TextView;
import com.keylesspalace.tusky.entity.AccessToken; import com.keylesspalace.tusky.entity.AccessToken;
import com.keylesspalace.tusky.entity.AppCredentials; import com.keylesspalace.tusky.entity.AppCredentials;
import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
@ -58,6 +60,14 @@ public class LoginActivity extends AppCompatActivity {
@BindView(R.id.button_login) Button button; @BindView(R.id.button_login) Button button;
@BindView(R.id.no_account) TextView noAccount; @BindView(R.id.no_account) TextView noAccount;
private static String urlEncode(String string) {
try {
return URLEncoder.encode(string, "UTF-8");
} catch (UnsupportedEncodingException e) {
throw new IllegalArgumentException("Failed to encode the string.", e);
}
}
/** /**
* Chain together the key-value pairs into a query string, for either appending to a URL or * Chain together the key-value pairs into a query string, for either appending to a URL or
* as the content of an HTTP request. * as the content of an HTTP request.
@ -67,9 +77,9 @@ public class LoginActivity extends AppCompatActivity {
String between = ""; String between = "";
for (Map.Entry<String, String> entry : parameters.entrySet()) { for (Map.Entry<String, String> entry : parameters.entrySet()) {
s.append(between); s.append(between);
s.append(entry.getKey()); s.append(urlEncode(entry.getKey()));
s.append("="); s.append("=");
s.append(entry.getValue()); s.append(urlEncode(entry.getValue()));
between = "&"; between = "&";
} }
return s.toString(); return s.toString();
@ -162,7 +172,6 @@ public class LoginActivity extends AppCompatActivity {
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
editText.setError(getString(R.string.error_invalid_domain)); editText.setError(getString(R.string.error_invalid_domain));
} }
} }
} }
@ -181,6 +190,10 @@ public class LoginActivity extends AppCompatActivity {
domain = savedInstanceState.getString("domain"); domain = savedInstanceState.getString("domain");
clientId = savedInstanceState.getString("clientId"); clientId = savedInstanceState.getString("clientId");
clientSecret = savedInstanceState.getString("clientSecret"); clientSecret = savedInstanceState.getString("clientSecret");
} else {
domain = null;
clientId = null;
clientSecret = null;
} }
preferences = getSharedPreferences( preferences = getSharedPreferences(
@ -222,27 +235,28 @@ public class LoginActivity extends AppCompatActivity {
super.onSaveInstanceState(outState); super.onSaveInstanceState(outState);
} }
@Override private void onLoginSuccess(String accessToken) {
protected void onStop() {
super.onStop();
SharedPreferences.Editor editor = preferences.edit(); SharedPreferences.Editor editor = preferences.edit();
editor.putString("domain", domain); editor.putString("domain", domain);
editor.putString("clientId", clientId);
editor.putString("clientSecret", clientSecret);
editor.apply();
}
private void onLoginSuccess(String accessToken) {
preferences = getSharedPreferences(
getString(R.string.preferences_file_key), Context.MODE_PRIVATE);
SharedPreferences.Editor editor = preferences.edit();
editor.putString("accessToken", accessToken); editor.putString("accessToken", accessToken);
editor.apply(); editor.commit();
Intent intent = new Intent(this, MainActivity.class); Intent intent = new Intent(this, MainActivity.class);
startActivity(intent); startActivity(intent);
finish(); finish();
} }
@Override
protected void onStop() {
super.onStop();
if (domain != null) {
SharedPreferences.Editor editor = preferences.edit();
editor.putString("domain", domain);
editor.putString("clientId", clientId);
editor.putString("clientSecret", clientSecret);
editor.apply();
}
}
@Override @Override
protected void onStart() { protected void onStart() {
super.onStart(); super.onStart();