fix warnings in test runs (#4340)

Found while working on #4026 but not directly related.

Two cases of unmocked methods and one of unclosed resource.
This commit is contained in:
Konrad Pozniak 2024-03-28 09:13:05 +01:00 committed by GitHub
parent 211983c7ee
commit b85ada930b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 14 additions and 1 deletions

View File

@ -18,6 +18,7 @@ import com.keylesspalace.tusky.entity.Notification
import com.keylesspalace.tusky.entity.TimelineAccount import com.keylesspalace.tusky.entity.TimelineAccount
import java.util.Date import java.util.Date
import kotlinx.coroutines.test.TestScope import kotlinx.coroutines.test.TestScope
import org.junit.After
import org.junit.Assert.assertEquals import org.junit.Assert.assertEquals
import org.junit.Assert.assertNotNull import org.junit.Assert.assertNotNull
import org.junit.Before import org.junit.Before
@ -60,6 +61,11 @@ class MainActivityTest {
WorkManagerTestInitHelper.initializeTestWorkManager(context) WorkManagerTestInitHelper.initializeTestWorkManager(context)
} }
@After
fun teardown() {
WorkManagerTestInitHelper.closeWorkDatabase()
}
@Test @Test
fun `clicking notification of type FOLLOW shows notification tab`() { fun `clicking notification of type FOLLOW shows notification tab`() {
val intent = showNotification(Notification.Type.FOLLOW) val intent = showNotification(Notification.Type.FOLLOW)

View File

@ -35,6 +35,7 @@ import com.keylesspalace.tusky.di.ViewModelFactory
import com.keylesspalace.tusky.entity.Instance import com.keylesspalace.tusky.entity.Instance
import com.keylesspalace.tusky.entity.InstanceConfiguration import com.keylesspalace.tusky.entity.InstanceConfiguration
import com.keylesspalace.tusky.entity.InstanceV1 import com.keylesspalace.tusky.entity.InstanceV1
import com.keylesspalace.tusky.entity.SearchResult
import com.keylesspalace.tusky.entity.StatusConfiguration import com.keylesspalace.tusky.entity.StatusConfiguration
import com.keylesspalace.tusky.network.MastodonApi import com.keylesspalace.tusky.network.MastodonApi
import java.util.Locale import java.util.Locale
@ -49,6 +50,7 @@ import org.junit.Before
import org.junit.Test import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
import org.mockito.kotlin.any import org.mockito.kotlin.any
import org.mockito.kotlin.anyOrNull
import org.mockito.kotlin.doReturn import org.mockito.kotlin.doReturn
import org.mockito.kotlin.eq import org.mockito.kotlin.eq
import org.mockito.kotlin.mock import org.mockito.kotlin.mock
@ -123,6 +125,9 @@ class ComposeActivityTest {
NetworkResult.success(instance) NetworkResult.success(instance)
} }
} }
onBlocking { search(anyOrNull(), anyOrNull(), anyOrNull(), anyOrNull(), anyOrNull(), anyOrNull()) } doReturn NetworkResult.success(
SearchResult(emptyList(), emptyList(), emptyList())
)
} }
val instanceDaoMock: InstanceDao = mock { val instanceDaoMock: InstanceDao = mock {

View File

@ -77,7 +77,9 @@ class ViewThreadViewModelTest {
fun setup() { fun setup() {
shadowOf(getMainLooper()).idle() shadowOf(getMainLooper()).idle()
api = mock() api = mock {
onBlocking { getFilters() } doReturn NetworkResult.success(emptyList())
}
eventHub = EventHub() eventHub = EventHub()
val filterModel = FilterModel() val filterModel = FilterModel()
val timelineCases = TimelineCases(api, eventHub) val timelineCases = TimelineCases(api, eventHub)