JehanneOS/newlib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Cygwin: passwd/group: allow specifying "." as local computername"

Browse Source 
This reverts commit 7c34811440be0bf1e749d9f075f54320c706cb4b.

This potentially allows to circumvent OpenSSHs user/group name matching,
unless the Admin knows to add every local user twice or to use patterns,
e.g.:

  Match user MACHINE+user,.+user
  Match user *+user

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2019-02-18 10:13:35 +01:00
parent 367c1ae161
commit 9883959f08
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
winsup/cygwin/uinfo.cc
View File

@ -2008,15 +2008,7 @@ pwdgrp::fetch_account_from_windows (fetch_user_arg_t &arg, cyg_ldap *pldap)
if ((p = wcschr (name, cygheap->pg.nss_separator ()[0])))
{
fq_name = true;
/* Convenience: Translate domain name "." to local machine. */
if (p == name + 1 && name[0] == L'.')
{
p = wcpcpy (name, cygheap->dom.account_flat_name ());
*p = L'\\';
sys_mbstowcs (p + 1, UNLEN + 1, arg.name + 2);
}
else
*p = L'\\';
*p = L'\\';
}
sid = csid;
ret = LookupAccountNameW (NULL, name, sid, &slen, dom, &dlen, &acc_type);