getrandom: it's MIN, not MAX

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
2017-03-11 10:01:47 +01:00 · 2017-03-11 10:01:47 +01:00 · 6c420fa494
parent c9e4b69e9f
commit 6c420fa494
2 changed files with 3 additions and 1 deletions
--- a/winsup/cygwin/libc/getentropy.cc
+++ b/winsup/cygwin/libc/getentropy.cc
@ -51,7 +51,7 @@ getrandom (void *ptr, size_t len, unsigned int flags)
      return -1;
    }
  /* Max. bytes returned by Linux call. */
-  len = MAX (len, (flags & GRND_RANDOM) ? 512 : 33554431);
+  len = MIN (len, (flags & GRND_RANDOM) ? 512 : 33554431);
  __try
    {
      if (!RtlGenRandom (ptr, len))
--- a/winsup/cygwin/release/2.8.0
+++ b/winsup/cygwin/release/2.8.0
@ -23,3 +23,5 @@ Bug Fixes
 - Fix a few problems which are the combined culprit of fork failing
  when called recursively from a pthread.
  Addresses: https://cygwin.com/ml/cygwin/2017-03/msg00113.html
+
+- Fix potential buffer overflow in getrandom.