kernel&all: create() syscall only sends Tcreate
In Plan9 the create syscall fallback on a open(OTRUNC) if the path provided already exists. This is actually a common requirement as most programs (editors, cat...) simply requires that a file is there and is empty, and doesn't care overwriting existing contents (note that this is particularily sensible with something like fossil). In Jehanne the application is responsible of actually handle this "file exists" error but libc provides ocreate() to mimic the Plan9 behaviour. Note that ocreate introduce a subtle race too: the path is walked several times if the file exists, thus it could misbehave on concurrent namespace changes. However I guess this is not going to happen often enough to care now. NOTE we will probably address this rare race too, with a more drammatic change to syscalls: a new walk() syscall that will provide an unopen fd.
This commit is contained in:
@ -1030,7 +1030,7 @@ syscreate(char* aname, uint32_t omode, uint32_t perm)
|
||||
int fd;
|
||||
Chan *c;
|
||||
|
||||
openmode(omode & ~OEXCL); /* error check only; OEXCL okay here */
|
||||
openmode(omode); /* error check only; OEXCL okay here */
|
||||
c = nil;
|
||||
if(waserror()) {
|
||||
if(c != nil)
|
||||
|
Reference in New Issue
Block a user